From patchwork Mon Apr 12 08:21:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: fche at redhat dot com X-Patchwork-Id: 42946 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 37180389682E; Mon, 12 Apr 2021 08:21:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 37180389682E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1618215717; bh=Bux1yvdH9HzLVbnDONJqyuIfphzO+eIxt4ZQSVnBMgA=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:From; b=Re8TVaf4/MDBwt3m9Jm7NdfnlUzbEy3getnOlHg1nO8mXujbFdrQUIS+lghtwPhVV HGbKjYGkjxAXAtp4/4QI4Lx53nKHToYJDcrigxclnxk8qIuejtm4u7+r8vpWnX945a sZuqj2Xsftkn1X+d3jEDUkNu5dlh5oWVNznmrJ1I= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: by sourceware.org (Postfix, from userid 48) id 5AC9F389682E; Mon, 12 Apr 2021 08:21:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5AC9F389682E To: libabigail@sourceware.org Subject: [Bug default/27715] Fails to detect GObjectClass ABI changes Date: Mon, 12 Apr 2021 08:21:56 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: marcandre.lureau at gmail dot com X-Bugzilla-Status: WAITING X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: "marcandre.lureau at gmail dot com via Libabigail" From: fche at redhat dot com Reply-To: "marcandre.lureau at gmail dot com" Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" https://sourceware.org/bugzilla/show_bug.cgi?id=27715 --- Comment #2 from Marc-André Lureau --- Reproducer: https://gitlab.gnome.org/GNOME/glib/ meson setup build && ninja -C build DESTDIR=/tmp/old ninja -C build install Modify a base class: ninja -C build DESTDIR=/tmp/new ninja -C build install abidiff --headers-dir1 /tmp/old/usr/include/glib-2.0/gobject --headers-dir2 /tmp/new/usr/include/glib-2.0/gobject/ --fail-no-debug-info --no-added-syms /tmp/old/usr/lib64/libgobject-2.0.so.0.6900.0 /tmp/new/usr/lib64/libgobject-2.0.so.0.6900.0 The starting point is that GTypeModuleClass isn't being used explicitely by functions. Yet it is the base class / vfunc / private of objects and should have ABI stability. diff --git a/gobject/gtypemodule.h b/gobject/gtypemodule.h index 5c4025063..f15f18a32 100644 --- a/gobject/gtypemodule.h +++ b/gobject/gtypemodule.h @@ -80,7 +80,6 @@ struct _GTypeModuleClass void (*reserved1) (void); void (*reserved2) (void); void (*reserved3) (void); - void (*reserved4) (void); };