From patchwork Fri May 19 15:26:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 69689 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8A1223858422 for ; Fri, 19 May 2023 15:27:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8A1223858422 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1684510076; bh=8wS8tu33z3i4R/QEi0lY53TNJcev8saUodBHGi+X+JQ=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=kEVJPqKDpzYO1P7K55YGXjVw79evUpBiSVjR79M68OimdLMk9iZWVmSk8UQKklM6C MOf1DhcpdP2mfrx4ZSMn2CUOVSpVGREnM0FYoXAz6+p4jCo5M8R+TSdgsOChIxzRt1 1fb0s4D+EMCdoQUMmU74l/Q/XPf6Uz7WoykKlblI= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by sourceware.org (Postfix) with ESMTPS id 760C3385842D for ; Fri, 19 May 2023 15:26:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 760C3385842D Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-76c626eb5d1so80070439f.0 for ; Fri, 19 May 2023 08:26:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684509994; x=1687101994; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8wS8tu33z3i4R/QEi0lY53TNJcev8saUodBHGi+X+JQ=; b=Ey+Uo8/vHT3hKbEENFoEcVPPuIhfA4QG85X7w+1t2n9cpl/krqtB3koXa8Ow3iHhpY ZioAPpEgaT2TIaYf2/z+OC4yBWa1jYNeHtlwROAJABti449CXG/xyzQas8PA80Dq1RAo vBwYnaKLIuCImXX4WOwUzBDSW/GDv7Oeb491P+7oqEZLi1Dho8lLbQYso+3iYZP0vDWn 1f3CovX2YMDpTLGhBYKgvFA8x2vahlJ/io68vVxH+T5jZ4X5iFZ96BrP3D/9rYXaxd8r kJowCwCLiUQ9X6TA81+SkprSlSoxA0JxWUMQD/deGNTdsE6SihTrzm8BC0kjcDarP1es HJQg== X-Gm-Message-State: AC+VfDxqKo6TqOteXTmSl3O4h2DMONUzyoLaPl3xpWlFeOrgmXaI0/dv BcxPnUFr9Jgy3PeJuvHP6n+mJpALDefJNDsdUJSPcg== X-Google-Smtp-Source: ACHHUZ7bPL7DYlfsKyjn2Q6i6+Y08dOGSaMcYfbXRRWy96+s2vu4alQoiq8xNOLkH0T33aO7rgBBVA== X-Received: by 2002:a5e:890f:0:b0:76d:6398:e6f0 with SMTP id k15-20020a5e890f000000b0076d6398e6f0mr1437881ioj.12.1684509994599; Fri, 19 May 2023 08:26:34 -0700 (PDT) Received: from localhost.localdomain (75-166-157-55.hlrn.qwest.net. [75.166.157.55]) by smtp.gmail.com with ESMTPSA id z10-20020a6b0a0a000000b007635e44126bsm1101793ioi.53.2023.05.19.08.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 08:26:34 -0700 (PDT) To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Remove some FIXME comments from DAP Date: Fri, 19 May 2023 09:26:27 -0600 Message-Id: <20230519152627.3281193-1-tromey@adacore.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" I recently added a 'dap' component to bugzilla, and I filed a few bugs there. This patch removes the corresponding FIXME comments. A few such comments still exist. In at least one case, I have a fix I'll be submitting eventually; in others I think I need to do a bit of investigation to properly file a bug report. --- gdb/python/lib/gdb/dap/bt.py | 1 - gdb/python/lib/gdb/dap/evaluate.py | 2 -- gdb/python/lib/gdb/dap/events.py | 3 --- gdb/python/lib/gdb/dap/next.py | 1 - 4 files changed, 7 deletions(-) diff --git a/gdb/python/lib/gdb/dap/bt.py b/gdb/python/lib/gdb/dap/bt.py index c5ede6e4c56..21cedb73d26 100644 --- a/gdb/python/lib/gdb/dap/bt.py +++ b/gdb/python/lib/gdb/dap/bt.py @@ -46,7 +46,6 @@ def _backtrace(thread_id, levels, startFrame): set_thread(thread_id) frames = [] current_number = 0 - # FIXME could invoke frame filters here. try: current_frame = gdb.newest_frame() except gdb.error: diff --git a/gdb/python/lib/gdb/dap/evaluate.py b/gdb/python/lib/gdb/dap/evaluate.py index 55d41b0806d..05816474688 100644 --- a/gdb/python/lib/gdb/dap/evaluate.py +++ b/gdb/python/lib/gdb/dap/evaluate.py @@ -51,7 +51,6 @@ def _repl(command, frame_id): } -# FIXME 'format' & hex # FIXME supportsVariableType handling @request("evaluate") def eval_request(*, expression, frameId=None, context="variables", **args): @@ -74,7 +73,6 @@ def _variables(ref, start, count): @request("variables") # Note that we ignore the 'filter' field. That seems to be # specific to javascript. -# FIXME: implement format def variables(*, variablesReference, start=0, count=0, **args): result = send_gdb_with_response( lambda: _variables(variablesReference, start, count) diff --git a/gdb/python/lib/gdb/dap/events.py b/gdb/python/lib/gdb/dap/events.py index 5b25470211f..d9ae603dfa4 100644 --- a/gdb/python/lib/gdb/dap/events.py +++ b/gdb/python/lib/gdb/dap/events.py @@ -140,13 +140,10 @@ def _on_stop(event): global _expected_stop obj = { "threadId": gdb.selected_thread().global_num, - # FIXME we don't support non-stop for now. "allThreadsStopped": True, } if isinstance(event, gdb.BreakpointEvent): # Ignore the expected stop, we hit a breakpoint instead. - # FIXME differentiate between 'breakpoint', 'function breakpoint', - # 'data breakpoint' and 'instruction breakpoint' here. _expected_stop = StopKinds.BREAKPOINT obj["hitBreakpointIds"] = [x.number for x in event.breakpoints] elif _expected_stop is None: diff --git a/gdb/python/lib/gdb/dap/next.py b/gdb/python/lib/gdb/dap/next.py index 33898ed6103..636dfce997d 100644 --- a/gdb/python/lib/gdb/dap/next.py +++ b/gdb/python/lib/gdb/dap/next.py @@ -47,5 +47,4 @@ def stepIn(*, threadId, granularity="statement", **args): @request("continue") def continue_request(**args): send_gdb(ExecutionInvoker("continue", None)) - # FIXME Just ignore threadId for the time being, and assume all-stop. return {"allThreadsContinued": True}