From patchwork Fri May 12 09:44:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 69235 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 31C0038C624F for ; Fri, 12 May 2023 09:45:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 31C0038C624F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1683884708; bh=i/qu4pdUlPILIBSuEDbitsX0FK3lhWNqTjEhCwidnuI=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=JvY+KOwcg7Yg2QcsRNPknnxhKY63C/46LBj8S8U9m6RTvloSunkt6kAeVEO/4b0xq QX7qjW2NcvXa4X9yA6J0e7E0rLrPXJ8Wsoz1GoaFQWetpHKfn1zhDpylHaOuZK5EOQ ZEX2+4bdWxiV08+4JVInq5Eeu6bysRKMpL8gbX6w= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 50C4E389F932 for ; Fri, 12 May 2023 09:44:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 50C4E389F932 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 849532048B for ; Fri, 12 May 2023 09:44:13 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 428AD13499 for ; Fri, 12 May 2023 09:44:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id AXjWC20KXmStSgAAMHmgww (envelope-from ) for ; Fri, 12 May 2023 09:44:13 +0000 To: gdb-patches@sourceware.org Subject: [pushed 1/2] [gdb/testsuite] Make is_64_target more robust Date: Fri, 12 May 2023 11:44:10 +0200 Message-Id: <20230512094412.24801-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom de Vries via Gdb-patches From: Tom de Vries Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" I ran test-case gdb.dwarf2/opt-out-not-implptr.exp with make-check-all.sh, and with target board dwarf64 ran into: ... FAIL: gdb.dwarf2/opt-out-not-implptr.exp: print noptr ... due to is_target_64 failing because of: ... builtin_spawn -ignore SIGHUP gcc -fno-stack-protector \ -fdiagnostics-color=never -w -c -gdwarf64 -g -o is_64_target.o \ is_64_target.c^M gcc: error: '-gdwarf64' is ambiguous; use '-gdwarf-64' for DWARF version or \ '-gdwarf -g64' for debug level^M compiler exited with status 1 ... The FAIL is the same FAIL I run into with target board unix/-m32: is_target_64 fails for both cases. The reason that is_target_64 is failing for target board dwarf64, is because of using system compiler 7.5.0 which doesn't support -gdwarf64. Fix this by making is_target_64 use nodebug instead of debug for compilation. Tested on x86_64-linux. --- gdb/testsuite/lib/gdb.exp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) base-commit: 9827805ce1eea094d5b97bf27acdd120e5cdda86 diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 50c10333df1..010da097766 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -3492,7 +3492,7 @@ gdb_caching_proc is_lp64_target {} { # This cannot be decided simply from looking at the target string, # as it might depend on externally passed compiler options like -m64. gdb_caching_proc is_64_target {} { - return [gdb_can_simple_compile is_64_target { + return [gdb_can_simple_compile_nodebug is_64_target { int function(void) { return 3; } int dummy[sizeof (&function) == 8 ? 1 : -1]; }] @@ -4736,6 +4736,13 @@ proc gdb_can_simple_compile {name code {type object} {compile_flags ""} {default return $ret } +# As gdb_can_simple_compile, but defaults to using nodebug instead of debug. +proc gdb_can_simple_compile_nodebug {name code {type object} {compile_flags ""} + {default_compile_flags "nodebug nowarning quiet"}} { + return [gdb_can_simple_compile $name $code $type $compile_flags \ + $default_compile_flags] +} + # Some targets need to always link a special object in. Save its path here. global gdb_saved_set_unbuffered_mode_obj set gdb_saved_set_unbuffered_mode_obj "" From patchwork Fri May 12 09:44:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 69241 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0FF99390BE62 for ; Fri, 12 May 2023 09:46:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0FF99390BE62 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1683884819; bh=9X7b+L0juAVdPX9yAeK3RvG8p9xdP4z7vqCZlqRN4tY=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=jIR7nEbeqVCoH3E2Fqs9R9NJaI9xBWNSSc1lTfDkd5UH8uay33Uvl/gmsgPwxVSLi FZ6lP6lgW/qn+EVxRcfN/UViOwMLczZ2B8Y1Z479D/56REM0JJsg+pAX8WFIwf1eOU s4r0cWBi3BQuYkskY+nqCeCyET/pgX13QU0b5BSE= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id B3BAA3882048 for ; Fri, 12 May 2023 09:44:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B3BAA3882048 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E31F42048D for ; Fri, 12 May 2023 09:44:13 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A34EB13499 for ; Fri, 12 May 2023 09:44:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8BfZI20KXmStSgAAMHmgww (envelope-from ) for ; Fri, 12 May 2023 09:44:13 +0000 To: gdb-patches@sourceware.org Subject: [pushed 2/2] [gdb/testsuite] Fix gdb.dwarf2/opt-out-not-implptr.exp for -m32 Date: Fri, 12 May 2023 11:44:11 +0200 Message-Id: <20230512094412.24801-2-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230512094412.24801-1-tdevries@suse.de> References: <20230512094412.24801-1-tdevries@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom de Vries via Gdb-patches From: Tom de Vries Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" When running test-case gdb.dwarf2/opt-out-not-implptr.exp with target board unix/-m32 we have: ... (gdb) print noptr^M $1 = {0, , , }^M (gdb) FAIL: gdb.dwarf2/opt-out-not-implptr.exp: print noptr ... The problem happens when evaluating this dwarf expression: ... <45> DW_AT_location : 13 byte block: 10 86 ea d7 d0 96 8e cf 92 5c 9f 93 8 \ (DW_OP_constu: 6639779683436459270; DW_OP_stack_value; DW_OP_piece: 8) ... The DW_OP_constu pushes a value with "generic type" on to the DWARF stack, and the "generic type" has the size of an address on the target machine, which for target board unix/-m32 is 4 bytes. Consequently, the constant is abbreviated. Next, the DW_OP_piece declares that the resulting 4-byte value is 8 bytes large, and we hit this clause in rw_pieced_value: ... /* Use zeroes if piece reaches beyond stack value. */ if (p->offset + p->size > stack_value_size_bits) break; ... and consequently get a zero. We could just add require is_target_64 to the test-case, but instead, add a 32-bit case and require is_target_64 just for the 64-bit case. Tested on x86_64-linux. --- .../gdb.dwarf2/opt-out-not-implptr.exp | 52 ++++++++++++++++--- 1 file changed, 45 insertions(+), 7 deletions(-) diff --git a/gdb/testsuite/gdb.dwarf2/opt-out-not-implptr.exp b/gdb/testsuite/gdb.dwarf2/opt-out-not-implptr.exp index 949bc23492a..9b240c9a2af 100644 --- a/gdb/testsuite/gdb.dwarf2/opt-out-not-implptr.exp +++ b/gdb/testsuite/gdb.dwarf2/opt-out-not-implptr.exp @@ -21,10 +21,13 @@ standard_testfile main.c -dw.S set asm_file [standard_output_file $srcfile2] +set c64 6639779683436459270 +set c32 1779823878 + Dwarf::assemble $asm_file { cu {} { compile_unit {} { - declare_labels i64_type array + declare_labels i64_type i32_type i64_array i32_array i64_type: base_type { {name "int64_t"} @@ -32,7 +35,13 @@ Dwarf::assemble $asm_file { {byte_size 8 DW_FORM_sdata} } - array: DW_TAG_array_type { + i32_type: base_type { + {name "int32_t"} + {encoding @DW_ATE_signed} + {byte_size 4 DW_FORM_sdata} + } + + i64_array: DW_TAG_array_type { {DW_AT_name array_type} {DW_AT_type :$i64_type} } { @@ -43,15 +52,36 @@ Dwarf::assemble $asm_file { } } + i32_array: DW_TAG_array_type { + {DW_AT_name array_type} + {DW_AT_type :$i32_type} + } { + DW_TAG_subrange_type { + {DW_AT_type :$i32_type} + {DW_AT_lower_bound 0 DW_FORM_data1} + {DW_AT_upper_bound 3 DW_FORM_data1} + } + } + DW_TAG_variable { - {name noptr} - {type :$array} + {name i64_noptr} + {type :$i64_array} {location { - DW_OP_constu 6639779683436459270 + DW_OP_constu $::c64 DW_OP_stack_value DW_OP_piece 8 } SPECIAL_expr} } + + DW_TAG_variable { + {name i32_noptr} + {type :$i32_array} + {location { + DW_OP_constu $::c32 + DW_OP_stack_value + DW_OP_piece 4 + } SPECIAL_expr} + } } } } @@ -72,5 +102,13 @@ if {![runto_main]} { return -1 } -gdb_test "print noptr" \ - " = \\{6639779683436459270, , , \\}" +set cmd "print i64_noptr" +if { [is_64_target] } { + gdb_test $cmd \ + " = \\{$c64, , , \\}" +} else { + unsupported $cmd +} + +gdb_test "print i32_noptr" \ + " = \\{$c32, , , \\}"