From patchwork Tue May 9 11:24:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Leoshkevich X-Patchwork-Id: 68955 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 75916385783F for ; Tue, 9 May 2023 11:24:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 75916385783F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1683631475; bh=Vd5rT0EXLAJm2/Cl+e+xkP2ngxtdFNpomylRgvAknhE=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=IOeP5jwrFxy+/siAc5mQiOcAdSRzJ1k867C2hguD4mEYOkiI5KHxMgtrL7DrNJFyE xVphubsoYrp5B/sk/rDdmZnjxQ7pXiAwoTzv0gJdTvyQnYuSnEurC847sBL7j39E5I sWgzvIaV4U9rBdWFEKWriaypATKV9b36sl6nFiQQ= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 5B23A3858D37 for ; Tue, 9 May 2023 11:24:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5B23A3858D37 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 349Avwfh026666; Tue, 9 May 2023 11:24:11 GMT Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qfkvsjj51-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 May 2023 11:24:10 +0000 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 34926nLH031989; Tue, 9 May 2023 11:24:08 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma02fra.de.ibm.com (PPS) with ESMTPS id 3qf7dg0b2u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 May 2023 11:24:08 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 349BO4vY11731608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 9 May 2023 11:24:04 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5F75F20043; Tue, 9 May 2023 11:24:04 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0C2832004B; Tue, 9 May 2023 11:24:04 +0000 (GMT) Received: from heavy.boeblingen.de.ibm.com (unknown [9.171.7.81]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 9 May 2023 11:24:03 +0000 (GMT) To: Tom Tromey Cc: gdb-patches@sourceware.org, Andreas Arnez , Ilya Leoshkevich Subject: [PATCH] gdb: Fix derive_heap_segment for PIE Date: Tue, 9 May 2023 13:24:01 +0200 Message-Id: <20230509112401.1043723-1-iii@linux.ibm.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: rJ0ywFataJ7CQ8e3XW-FqBCQ-YFfWj2u X-Proofpoint-ORIG-GUID: rJ0ywFataJ7CQ8e3XW-FqBCQ-YFfWj2u X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-09_07,2023-05-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 lowpriorityscore=0 clxscore=1011 suspectscore=0 bulkscore=0 priorityscore=1501 adultscore=0 impostorscore=0 mlxscore=0 mlxlogscore=992 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305090088 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Ilya Leoshkevich via Gdb-patches From: Ilya Leoshkevich Reply-To: Ilya Leoshkevich Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Using gcore with qemu-user gdbstub produces huge core dumps: $ qemu-s390x-static -g 1234 /bin/true $ gdb -ex 'target remote :1234' /bin/true (gdb) generate-core-file Saved corefile core.1 $ wc -c sections; sec; sec = sec->next) - { - if (bfd_section_flags (sec) & SEC_DATA - || strcmp (".bss", bfd_section_name (sec)) == 0) + for (objfile *objfile : current_program_space->objfiles ()) + if (objfile->obfd == current_program_space->exec_bfd ()) + for (obj_section *objsec : objfile->sections ()) { - sec_vaddr = bfd_section_vma (sec); - sec_size = bfd_section_size (sec); - if (sec_vaddr + sec_size > top_of_data_memory) - top_of_data_memory = sec_vaddr + sec_size; + asection *sec = objsec->the_bfd_section; + if (bfd_section_flags (sec) & SEC_DATA + || strcmp (".bss", bfd_section_name (sec)) == 0) + { + if (objsec->endaddr () > top_of_data_memory) + top_of_data_memory = objsec->endaddr (); + } } - } top_of_heap = call_target_sbrk (0); if (top_of_heap == (bfd_vma) 0) @@ -553,8 +551,7 @@ objfile_find_memory_regions (struct target_ops *self, obfd); /* Make a heap segment. */ - if (derive_heap_segment (current_program_space->exec_bfd (), &temp_bottom, - &temp_top)) + if (derive_heap_segment (&temp_bottom, &temp_top)) (*func) (temp_bottom, temp_top - temp_bottom, 1, /* Heap section will be readable. */ 1, /* Heap section will be writable. */