From patchwork Mon Apr 24 15:10:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 68217 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 02BE13858C30 for ; Mon, 24 Apr 2023 15:10:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 02BE13858C30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1682349033; bh=zXuZEg7ipsTVu8gvH7AZRT8s/WSMTxA+WhixYA04UeA=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=H7/+8Aqb+IZsE2l2wMBFNCD/OnIuSEKfWPS1OPRo+jJ+n8bEoSWqGzUW8ZRDVIwt0 iHeacE0CxiPMGsgDi+wq+9ZO3pQorAh8U5ApYLK14FMJ8bGHZvPD/caV1ucyoyxi4N dbJNYorzskaNaLy/SqpKcysX3AdUdMVn48JAPdPs= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 630883858D28 for ; Mon, 24 Apr 2023 15:10:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 630883858D28 Received: from localhost.localdomain (unknown [167.248.160.41]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 083211E128; Mon, 24 Apr 2023 11:10:07 -0400 (EDT) To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH] gdb: remove end_stepping_range observable Date: Mon, 24 Apr 2023 11:10:07 -0400 Message-Id: <20230424151007.54516-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-1173.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Simon Marchi via Gdb-patches From: Simon Marchi Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" I noticed that this observable was never notified, which means we can probably safely remove it. Change-Id: If5da5149276c282d2540097c8c4327ce0f70431a --- gdb/cli/cli-interp.c | 17 ----------------- gdb/mi/mi-interp.c | 20 -------------------- gdb/observable.c | 1 - gdb/observable.h | 3 --- 4 files changed, 41 deletions(-) diff --git a/gdb/cli/cli-interp.c b/gdb/cli/cli-interp.c index 99410147a6ce..5a515c603c6e 100644 --- a/gdb/cli/cli-interp.c +++ b/gdb/cli/cli-interp.c @@ -151,21 +151,6 @@ cli_base_on_signal_received (enum gdb_signal siggnal) } } -/* Observer for the end_stepping_range notification. */ - -static void -cli_base_on_end_stepping_range () -{ - SWITCH_THRU_ALL_UIS () - { - cli_interp_base *cli = as_cli_interp_base (top_level_interpreter ()); - if (cli == nullptr) - continue; - - print_end_stepping_range_reason (cli->interp_ui_out ()); - } -} - /* Observer for the signalled notification. */ static void @@ -422,8 +407,6 @@ _initialize_cli_interp () /* Note these all work for both the CLI and TUI interpreters. */ gdb::observers::normal_stop.attach (cli_base_on_normal_stop, "cli-interp-base"); - gdb::observers::end_stepping_range.attach (cli_base_on_end_stepping_range, - "cli-interp-base"); gdb::observers::signal_received.attach (cli_base_on_signal_received, "cli-interp-base"); gdb::observers::signal_exited.attach (cli_base_on_signal_exited, diff --git a/gdb/mi/mi-interp.c b/gdb/mi/mi-interp.c index 4f0bbd40f9d7..ce78b0c2b58a 100644 --- a/gdb/mi/mi-interp.c +++ b/gdb/mi/mi-interp.c @@ -61,7 +61,6 @@ static void mi_insert_notify_hooks (void); static void mi_remove_notify_hooks (void); static void mi_on_signal_received (enum gdb_signal siggnal); -static void mi_on_end_stepping_range (void); static void mi_on_signal_exited (enum gdb_signal siggnal); static void mi_on_exited (int exitstatus); static void mi_on_normal_stop (struct bpstat *bs, int print_frame); @@ -542,23 +541,6 @@ mi_on_signal_received (enum gdb_signal siggnal) } } -/* Observer for the end_stepping_range notification. */ - -static void -mi_on_end_stepping_range (void) -{ - SWITCH_THRU_ALL_UIS () - { - struct mi_interp *mi = find_mi_interp (); - - if (mi == NULL) - continue; - - print_end_stepping_range_reason (mi->mi_uiout); - print_end_stepping_range_reason (mi->cli_uiout); - } -} - /* Observer for the signal_exited notification. */ static void @@ -1317,8 +1299,6 @@ _initialize_mi_interp () interp_factory_register (INTERP_MI, mi_interp_factory); gdb::observers::signal_received.attach (mi_on_signal_received, "mi-interp"); - gdb::observers::end_stepping_range.attach (mi_on_end_stepping_range, - "mi-interp"); gdb::observers::signal_exited.attach (mi_on_signal_exited, "mi-interp"); gdb::observers::exited.attach (mi_on_exited, "mi-interp"); gdb::observers::no_history.attach (mi_on_no_history, "mi-interp"); diff --git a/gdb/observable.c b/gdb/observable.c index 49de89c25e04..82563e3fab47 100644 --- a/gdb/observable.c +++ b/gdb/observable.c @@ -34,7 +34,6 @@ bool observer_debug = false; DEFINE_OBSERVABLE (normal_stop); DEFINE_OBSERVABLE (signal_received); -DEFINE_OBSERVABLE (end_stepping_range); DEFINE_OBSERVABLE (signal_exited); DEFINE_OBSERVABLE (exited); DEFINE_OBSERVABLE (no_history); diff --git a/gdb/observable.h b/gdb/observable.h index 3066cf68f314..e4e6f021f1a9 100644 --- a/gdb/observable.h +++ b/gdb/observable.h @@ -57,9 +57,6 @@ extern observable normal_stop; /* The inferior was stopped by a signal. */ extern observable signal_received; -/* We are done with a step/next/si/ni command. */ -extern observable<> end_stepping_range; - /* The inferior was terminated by a signal. */ extern observable signal_exited;