From patchwork Tue Apr 18 16:40:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 67951 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 331B63858D39 for ; Tue, 18 Apr 2023 16:40:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 331B63858D39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1681836051; bh=wdZ4qbBjmfpFvV08XiB6guwoFwa0uoK/XFDqIF3mkQg=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=SJwIJFJoLcGBXIpDGmQG1kZDvxUhWcelrUtuXfKsfhbhezX6UkkaEW2/h0Hjivo/Z O0zq2StVbHGKEsXCfRTH4aJdvRV9Bc5ngVwkIMk7VOmjVVIDqfsfCnXQXiDXvb5T5Y BkK16Fg6iMMszf4Rm2QMr53FmOo8jNLr+6Ub/mac= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1796D3858D1E for ; Tue, 18 Apr 2023 16:40:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1796D3858D1E Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-558-vM2Ba7aBPvWPSdIzpKiDKw-1; Tue, 18 Apr 2023 12:40:13 -0400 X-MC-Unique: vM2Ba7aBPvWPSdIzpKiDKw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BE5D685A5A3 for ; Tue, 18 Apr 2023 16:40:12 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.194.164]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7CC9B2958; Tue, 18 Apr 2023 16:40:12 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 33IGeAaZ341445 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 18 Apr 2023 18:40:10 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 33IGeAbs341444; Tue, 18 Apr 2023 18:40:10 +0200 To: GCC patches Cc: Andrew MacLeod , Aldy Hernandez Subject: [PATCH] Fix pointer sharing in Value_Range constructor. Date: Tue, 18 Apr 2023 18:40:07 +0200 Message-Id: <20230418164007.341221-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: Aldy Hernandez Reply-To: Aldy Hernandez Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" I will push this when a final round of testing finishes on x86-64 Linux. gcc/ChangeLog: * value-range.h (Value_Range::Value_Range): Avoid pointer sharing. --- gcc/value-range.h | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/gcc/value-range.h b/gcc/value-range.h index 0eeea79b322..f97596cdd14 100644 --- a/gcc/value-range.h +++ b/gcc/value-range.h @@ -583,7 +583,18 @@ Value_Range::Value_Range (tree min, tree max, value_range_kind kind) inline Value_Range::Value_Range (const Value_Range &r) { - m_vrange = r.m_vrange; + if (r.m_vrange == &r.m_irange) + { + m_irange = r.m_irange; + m_vrange = &m_irange; + } + else if (r.m_vrange == &r.m_frange) + { + m_frange = r.m_frange; + m_vrange = &m_frange; + } + else + m_vrange = &m_unsupported; } // Initialize object so it is possible to store temporaries of TYPE