From patchwork Tue Apr 4 13:57:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Simmons-Talbott X-Patchwork-Id: 67266 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 827563850852 for ; Tue, 4 Apr 2023 13:58:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 827563850852 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680616712; bh=JC2dtQ1uGpWXuqCUvMSLgtCIxVtjg6CPuvDHkL0RpnY=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=vongcSeQeJ14NbsSBm4oSEaFT4zKCJVYRQ73kF6twAfOnFUtMAHgYQWtVC+AdslZ0 lpU2QwJg+4C79LkurjEz576etJjP0BOIn+0ET1LiRmDLQiPMQVZ+RIGfQvBDALq+Qt G91gVTKIZCVM22zu0GK35qb5ZBblzMAf6Niq8O3k= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 09FB93858C5E for ; Tue, 4 Apr 2023 13:58:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 09FB93858C5E Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-523-kRlYhV62NeygTlT4TJcbTQ-1; Tue, 04 Apr 2023 09:58:06 -0400 X-MC-Unique: kRlYhV62NeygTlT4TJcbTQ-1 Received: by mail-qv1-f71.google.com with SMTP id pe26-20020a056214495a00b005df3eac4c0bso11540005qvb.1 for ; Tue, 04 Apr 2023 06:58:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680616686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JC2dtQ1uGpWXuqCUvMSLgtCIxVtjg6CPuvDHkL0RpnY=; b=2Y1ng+UWI/4lOJC6+IcFkVP7Kz4E9r37z4lDIO67fCJfJvAmdNuCWfIpQTj4rfEQRE 1/QekxhR/rfzgaB9ZC1fzb3e9qSJIhRTYTubdgEAlDPMUvFwUQiuLX5lOXEwwbAD5vg/ VWuBQVatAN/we6FxsQMre90pLEnpmKLzUzMnx4wIGOvKSkoW35avHLrr+FNCdyCqTmcx On+KGwrJR5LnrYnr7/hyjW/klLJfTII/vJG2Oiolu1R8lEuOsqymrBtHFJA07N+MpC9z WHRg8Q5yJEp3nCiRjtAjLL7BM2b50rbHszIjwpkImeARiQ6XDCQX6AzRm8LmOOKS2eVu KjVw== X-Gm-Message-State: AAQBX9c07A/vZfCDtqTs7x8P+VnKBGOiunjA3ixYChfQTYx0qpefBu61 hC3Yn6fa4IrlXIANYYsni4ekTliRW+EcNyukEn3SHudFqpYFsnAakDoVLhinbeKZvHVjAU/yQ0M PnBwmOFkGfW/V4kCkbs8f X-Received: by 2002:a05:622a:1210:b0:3e6:2e9e:58f1 with SMTP id y16-20020a05622a121000b003e62e9e58f1mr3581526qtx.59.1680616685978; Tue, 04 Apr 2023 06:58:05 -0700 (PDT) X-Google-Smtp-Source: AKy350belg8jUj7/yZswvCTvUr9had9a51oYxQwDadlZXOUh6Mlk6WRfe9/bnx87ehMEoTQKJk6Lww== X-Received: by 2002:a05:622a:1210:b0:3e6:2e9e:58f1 with SMTP id y16-20020a05622a121000b003e62e9e58f1mr3581493qtx.59.1680616685655; Tue, 04 Apr 2023 06:58:05 -0700 (PDT) Received: from oak.redhat.com (c-71-206-142-238.hsd1.va.comcast.net. [71.206.142.238]) by smtp.gmail.com with ESMTPSA id i7-20020a37b807000000b0074a5ffbecd3sm167759qkf.49.2023.04.04.06.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 06:58:05 -0700 (PDT) To: Wilco Dijkstra , libc-alpha@sourceware.org Cc: Joe Simmons-Talbott Subject: [PATCH v2 1/3] stdlib: Add testcases for abs(). (BZ #30263) Date: Tue, 4 Apr 2023 09:57:45 -0400 Message-Id: <20230404135747.3576298-2-josimmon@redhat.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230404135747.3576298-1-josimmon@redhat.com> References: <20230404135747.3576298-1-josimmon@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Joe Simmons-Talbott via Libc-alpha From: Joe Simmons-Talbott Reply-To: Joe Simmons-Talbott Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Test minimum and maximum int values, zero, and part of the range of int values. Use '-fno-builtin' to ensure we are testing the implementation. --- stdlib/Makefile | 3 +++ stdlib/tst-abs.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+) create mode 100644 stdlib/tst-abs.c diff --git a/stdlib/Makefile b/stdlib/Makefile index 5e38f0e6a2..b7e1c028f0 100644 --- a/stdlib/Makefile +++ b/stdlib/Makefile @@ -184,6 +184,7 @@ tests := \ testmb2 \ testrand \ testsort \ + tst-abs \ tst-arc4random-fork \ tst-arc4random-stats \ tst-arc4random-thread \ @@ -287,6 +288,8 @@ LDLIBS-test-dlclose-exit-race = $(shared-thread-library) LDFLAGS-test-dlclose-exit-race = $(LDFLAGS-rdynamic) LDLIBS-test-dlclose-exit-race-helper.so = $(libsupport) $(shared-thread-library) +CFLAGS-tst-abs.c += -fno-builtin + ifeq ($(have-cxx-thread_local),yes) CFLAGS-tst-quick_exit.o = -std=c++11 LDLIBS-tst-quick_exit = -lstdc++ diff --git a/stdlib/tst-abs.c b/stdlib/tst-abs.c new file mode 100644 index 0000000000..2b96aedc3e --- /dev/null +++ b/stdlib/tst-abs.c @@ -0,0 +1,45 @@ +/* Basic tests for abs. + Copyright (C) 2023 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include + +#include + +#define LARGE_PRIME 49999 + +static int do_test (void) +{ + int i; + + TEST_COMPARE(abs(INT_MAX), INT_MAX); + TEST_COMPARE(abs(INT_MIN + 1), INT_MAX); + TEST_COMPARE(abs(-1), 1); + TEST_COMPARE(abs(0), 0); + TEST_COMPARE(abs(1), 1); + + for (i = INT_MIN + 1; i < 0; i += LARGE_PRIME) + TEST_COMPARE(abs(i), -i); + + for (i = 0; i < INT_MAX - LARGE_PRIME; i += LARGE_PRIME) + TEST_COMPARE(abs(i), i); + + return EXIT_SUCCESS; +} + +#include From patchwork Tue Apr 4 13:57:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Simmons-Talbott X-Patchwork-Id: 67267 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D5BDC3850208 for ; Tue, 4 Apr 2023 13:58:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D5BDC3850208 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680616714; bh=9UrtiQE7x4WF/MOkYmrgEKHuL0oFHXljP3yxfV+p9FM=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=JFGwpK0CTbLr3QVD1hTr3JFp2wXi0YmIMz6YbWG3fNoNvHU/1Sahtv0tfqwaVvdrQ Y+WAFT/YUZlpIv1XzGp4EF+xlyHo7baysz8XbWY74x3/rzQgHl4HuenT+a88dss/T+ e+iGIwMao40GlKJttNYHlj9F+lwGUqukhgttZioo= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id F04103858C39 for ; Tue, 4 Apr 2023 13:58:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F04103858C39 Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-139-7OXAhgzuPEu2BtxtWVZLyA-1; Tue, 04 Apr 2023 09:58:09 -0400 X-MC-Unique: 7OXAhgzuPEu2BtxtWVZLyA-1 Received: by mail-qt1-f199.google.com with SMTP id f36-20020a05622a1a2400b003deb2fa544bso22260692qtb.0 for ; Tue, 04 Apr 2023 06:58:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680616689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9UrtiQE7x4WF/MOkYmrgEKHuL0oFHXljP3yxfV+p9FM=; b=hEnRwsQo2lSOQFr55mVqUT0XTRfV7aw7ouwyKmGbLP4mZwmcOK3W5HUcnU1OjXw/Xy RjF0y9N7nuRxeQLGNvAPVhqQfNnOtFaZFXZwEr8eqYeCyaR5Ufa+bBGAJaaNBfK0X1XG +12URPhdZMEPNkjBWqxCbjCK8BcD2jpOWOQfeSTru6iis9KWNAXHbwJV1zWr3XNSSNwT 7hKZ4fbWMaie/malW6DbSxieIzsndIGt5Q7tpVcWjsqUqC6A6E2A9pqfaCVdA0rvNJr0 sCEkF8CG3CgAOhY2fyx2C9yG9ED+ceNrSE6D28sOdZignR/peJVxbsrqBDbP1E6xjv4G y9xg== X-Gm-Message-State: AAQBX9dR4ZtvdCFdwOr4j/N8KJdr5hqudGhoBUPNtj7cMyKX4VJbP1Gn tC35reG5+OpUlQic+68mc5IpxfEVbwOC4TwahD33DJoQjmwh+u0h4MRqEKtA6IKFlvcyPdJNbzY 4/Lm9cEzXrylBE4/ifCajPY7KdyJ5 X-Received: by 2002:a05:622a:547:b0:3b6:2f0d:1925 with SMTP id m7-20020a05622a054700b003b62f0d1925mr2593559qtx.64.1680616688729; Tue, 04 Apr 2023 06:58:08 -0700 (PDT) X-Google-Smtp-Source: AKy350YsUDxNeg2OBNaKguMtz5q4ITYyZFTRcGyKpCyI58ErBFOo6QdD8/a6oR9hLcA6lSQ1CjtPOg== X-Received: by 2002:a05:622a:547:b0:3b6:2f0d:1925 with SMTP id m7-20020a05622a054700b003b62f0d1925mr2593540qtx.64.1680616688456; Tue, 04 Apr 2023 06:58:08 -0700 (PDT) Received: from oak.redhat.com (c-71-206-142-238.hsd1.va.comcast.net. [71.206.142.238]) by smtp.gmail.com with ESMTPSA id i7-20020a37b807000000b0074a5ffbecd3sm167759qkf.49.2023.04.04.06.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 06:58:07 -0700 (PDT) To: Wilco Dijkstra , libc-alpha@sourceware.org Cc: Joe Simmons-Talbott Subject: [PATCH v2 2/3] stdlib: Add testcases for labs(). (BZ #30263) Date: Tue, 4 Apr 2023 09:57:46 -0400 Message-Id: <20230404135747.3576298-3-josimmon@redhat.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230404135747.3576298-1-josimmon@redhat.com> References: <20230404135747.3576298-1-josimmon@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Joe Simmons-Talbott via Libc-alpha From: Joe Simmons-Talbott Reply-To: Joe Simmons-Talbott Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Test minimum and maximum long values, zero, and part of the range of long values. Use '-fno-builtin' to ensure we are testing the implementation. --- stdlib/Makefile | 2 ++ stdlib/tst-labs.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 53 insertions(+) create mode 100644 stdlib/tst-labs.c diff --git a/stdlib/Makefile b/stdlib/Makefile index b7e1c028f0..5899cc1865 100644 --- a/stdlib/Makefile +++ b/stdlib/Makefile @@ -198,6 +198,7 @@ tests := \ tst-cxa_atexit \ tst-environ \ tst-getrandom \ + tst-labs \ tst-limits \ tst-makecontext \ tst-makecontext-align \ @@ -289,6 +290,7 @@ LDFLAGS-test-dlclose-exit-race = $(LDFLAGS-rdynamic) LDLIBS-test-dlclose-exit-race-helper.so = $(libsupport) $(shared-thread-library) CFLAGS-tst-abs.c += -fno-builtin +CFLAGS-tst-labs.c += -fno-builtin ifeq ($(have-cxx-thread_local),yes) CFLAGS-tst-quick_exit.o = -std=c++11 diff --git a/stdlib/tst-labs.c b/stdlib/tst-labs.c new file mode 100644 index 0000000000..92b456745a --- /dev/null +++ b/stdlib/tst-labs.c @@ -0,0 +1,51 @@ +/* Basic tests for labs. + Copyright (C) 2023 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include + +#include + +#define LARGE_PRIME 49999 + +static int do_test (void) +{ + long i; + + TEST_COMPARE(labs(LONG_MAX), LONG_MAX); + TEST_COMPARE(labs(LONG_MIN + 1), LONG_MAX); + TEST_COMPARE(labs(-1), 1); + TEST_COMPARE(labs(0), 0); + TEST_COMPARE(labs(1), 1); + + for (i = LONG_MIN + 1; i < LONG_MIN + INT_MAX; i += LARGE_PRIME) + TEST_COMPARE(labs(i), -i); + + for (i = LONG_MAX - INT_MAX; i < LONG_MAX - LARGE_PRIME; i += LARGE_PRIME) + TEST_COMPARE(labs(i), i); + + for (i = INT_MIN + 1; i < 0; i += LARGE_PRIME) + TEST_COMPARE(labs(i), -i); + + for (i = 0; i < INT_MAX; i += LARGE_PRIME) + TEST_COMPARE(labs(i), i); + + return EXIT_SUCCESS; +} + +#include From patchwork Tue Apr 4 13:57:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Simmons-Talbott X-Patchwork-Id: 67268 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 70B133850221 for ; Tue, 4 Apr 2023 13:58:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 70B133850221 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680616716; bh=TUjb78FMBa71fXgGxCnvpqvoUxKcGo3Op/ox8xRXIB8=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=IkPh6KB593ejr/2UDHGN3GAvZ6dDMMjmKNJmLA8g32hvb3orGHpKrEiaqhjq6YUmk Oa8jdV43RWIkhFFLe+giUKEagSrHUTaE8QJ+IwKuet/YcwjSumyHZsjfkGPVuiJ1lh BDdmRKpVzuwDWA8Dg2uJE6HULQVQC7KHbAirfeAg= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0641F385842B for ; Tue, 4 Apr 2023 13:58:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0641F385842B Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-413-88MG_0Q5POSykDfMo1Jxsg-1; Tue, 04 Apr 2023 09:58:11 -0400 X-MC-Unique: 88MG_0Q5POSykDfMo1Jxsg-1 Received: by mail-qv1-f71.google.com with SMTP id f3-20020a0cc303000000b005c9966620daso14529959qvi.4 for ; Tue, 04 Apr 2023 06:58:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680616691; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TUjb78FMBa71fXgGxCnvpqvoUxKcGo3Op/ox8xRXIB8=; b=qGpeuprPlS9EWNugrDvbEy74JKybGWKF1i5MeQS01Q6RHCApfhEz52YzhHY9E1UyIC diHa3X3OtENFcVLfDEhWgWPeZyvw2sA6sHpE5Cl2oq19rs6c52E/KAqmsScO3QHTKxCn eEV942/jMDTcyH2vjtCvP/rJOrDYsFidbjk03g9MPUPqcZnvBnhm6mkMsSmTjW7UTuit U0i/dq5ImliQei8+ixIf7mWipPjXjDrFgTdYM0Hc+xmYWITrtg5R2an5Yobaq7Alxye7 K8I540r+BV+2TH8E9q5WlKN6UES+aaPgQSa02c17tvcHXYp1LpCJ0cyqZ9OktmAnxsUM 9XJQ== X-Gm-Message-State: AAQBX9eTx5XhZdzJz3n1EM/FMiqWHat5PUqZm5LzHAsCARkZh5wWZNbf 8/ssdsv42P4SE1QThC2vD0XCw3Ghq8gBfpFASSta2V/Zvqevsyh/kolKLDRsSGDp3dfb7IpVm8I 5woEU268Pivs0oS8baYwT X-Received: by 2002:a05:622a:1902:b0:3bf:df2e:a494 with SMTP id w2-20020a05622a190200b003bfdf2ea494mr3702021qtc.6.1680616691219; Tue, 04 Apr 2023 06:58:11 -0700 (PDT) X-Google-Smtp-Source: AKy350axA9GerDAyntb5pYlmg7aAQweip9lYyup9x/b2mdA8zJC7pW7vfAI73Iyf5lW3e4OOFNI0Qw== X-Received: by 2002:a05:622a:1902:b0:3bf:df2e:a494 with SMTP id w2-20020a05622a190200b003bfdf2ea494mr3701986qtc.6.1680616690852; Tue, 04 Apr 2023 06:58:10 -0700 (PDT) Received: from oak.redhat.com (c-71-206-142-238.hsd1.va.comcast.net. [71.206.142.238]) by smtp.gmail.com with ESMTPSA id i7-20020a37b807000000b0074a5ffbecd3sm167759qkf.49.2023.04.04.06.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 06:58:10 -0700 (PDT) To: Wilco Dijkstra , libc-alpha@sourceware.org Cc: Joe Simmons-Talbott Subject: [PATCH v2 3/3] stdlib: Add testcases for llabs(). (BZ #30263) Date: Tue, 4 Apr 2023 09:57:47 -0400 Message-Id: <20230404135747.3576298-4-josimmon@redhat.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230404135747.3576298-1-josimmon@redhat.com> References: <20230404135747.3576298-1-josimmon@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Joe Simmons-Talbott via Libc-alpha From: Joe Simmons-Talbott Reply-To: Joe Simmons-Talbott Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Test minimum and maximum long long values, zero, 32bit crossover points, and part of the range of long long values. Use '-fno-builtin' to ensure we are testing the implementation. --- stdlib/Makefile | 2 ++ stdlib/tst-llabs.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 57 insertions(+) create mode 100644 stdlib/tst-llabs.c diff --git a/stdlib/Makefile b/stdlib/Makefile index 5899cc1865..40886dea11 100644 --- a/stdlib/Makefile +++ b/stdlib/Makefile @@ -200,6 +200,7 @@ tests := \ tst-getrandom \ tst-labs \ tst-limits \ + tst-llabs \ tst-makecontext \ tst-makecontext-align \ tst-makecontext2 \ @@ -291,6 +292,7 @@ LDLIBS-test-dlclose-exit-race-helper.so = $(libsupport) $(shared-thread-library) CFLAGS-tst-abs.c += -fno-builtin CFLAGS-tst-labs.c += -fno-builtin +CFLAGS-tst-llabs.c += -fno-builtin ifeq ($(have-cxx-thread_local),yes) CFLAGS-tst-quick_exit.o = -std=c++11 diff --git a/stdlib/tst-llabs.c b/stdlib/tst-llabs.c new file mode 100644 index 0000000000..be3cd78ceb --- /dev/null +++ b/stdlib/tst-llabs.c @@ -0,0 +1,55 @@ +/* Basic tests for llabs. + Copyright (C) 2023 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include + +#include + +#define LARGE_PRIME 49999 + +static int do_test (void) +{ + long i; + + TEST_COMPARE(llabs(LLONG_MAX), LLONG_MAX); + TEST_COMPARE(llabs(LLONG_MIN + 1), LLONG_MAX); + TEST_COMPARE(llabs(0x00000000ffffffffL), 0x00000000ffffffffL); + TEST_COMPARE(llabs(0x0000000100000000L), 0x0000000100000000L); + TEST_COMPARE(llabs(0x80000000ffffffffL), 0x7fffffff00000001L); + TEST_COMPARE(llabs(0x8000000100000000L), 0x7fffffff00000000L); + TEST_COMPARE(llabs(-1), 1); + TEST_COMPARE(llabs(0), 0); + TEST_COMPARE(llabs(1), 1); + + for (i = LLONG_MIN + 1; i < LLONG_MIN + INT_MAX; i += LARGE_PRIME) + TEST_COMPARE(llabs(i), -i); + + for (i = LLONG_MAX - INT_MAX; i < LLONG_MAX - LARGE_PRIME; i += LARGE_PRIME) + TEST_COMPARE(llabs(i), i); + + for (i = INT_MIN + 1; i < 0; i += LARGE_PRIME) + TEST_COMPARE(llabs(i), -i); + + for (i = 0; i < INT_MAX; i += LARGE_PRIME) + TEST_COMPARE(llabs(i), i); + + return EXIT_SUCCESS; +} + +#include