From patchwork Tue Mar 28 15:22:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cupertino Miranda X-Patchwork-Id: 67020 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7FFE33855580 for ; Tue, 28 Mar 2023 15:23:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7FFE33855580 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680017023; bh=HKM6/O6ReL+eHNXwgJmIt5IEk1q+TVI+pyd94fEwibg=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=xHvpToW1T+CooDmy8IgofwtOGs+QG9jxrpPKLtryW2e4TyzB1CyqxFp6qGJWU2K8V gO/Y92sQamwnxY8hpeY2BIs5wbsEsblNFcjlh5AbciSRIwHK6FybSJLuT2JJep+U5p eMkf4CnblwlUVRFdgls8zJ0aKhEy9CBo0Jz3VlVY= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 06DC43858028 for ; Tue, 28 Mar 2023 15:23:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 06DC43858028 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32SFJUup007872 for ; Tue, 28 Mar 2023 15:23:19 GMT Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3pm2sb00fb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 28 Mar 2023 15:23:18 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 32SEgURY020410 for ; Tue, 28 Mar 2023 15:23:18 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2172.outbound.protection.outlook.com [104.47.56.172]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3phqd6t1vf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 28 Mar 2023 15:23:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f1AB8JJ9Byjeyrek9ZAm/Nr7coMSNNIYlRKWz+eFvqoA9Y3JV7bT41zZGmnGKRddoR75pEseflatg3mwPZUuEBgYVpI1q4jShislGc3r/EXq3hEpiWr16adT1UJ6coqMCYF/nJIxdIizPWkr9FAoN5CIof1ShEJXcxCtKDyZk0h6jFE+buItDpsJQCeWtAevyo8YaRcuA4kaJFSw3aGmuH8aRbWIFaHmMCerYqPyX4vuNBcpihymfH/vNMW0gCJSeTppwZdy/cNSuey376dZCPQRkFCQP9E+cWDehi7qWSZ3cPwdhyftwaVy3L9hQ626ZPCVJLXeqnjLWqP7BmMnwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HKM6/O6ReL+eHNXwgJmIt5IEk1q+TVI+pyd94fEwibg=; b=JIIErdCovjGGbmwyEV5lRJmaypmEPZBQGa31r95hIgl1jpDkj8sKtH8QSixPeYZwfWG8uO69uENBtqpv6REmP9UtFRMaiAmJzt4weOYNdl8SVtcm16Rg/jyHPdszwlz5cAlZ03VF7gQM0ju2oJqJbp4xr6Jg/a9kKM2OopRjoLeg1DBhrHpJ1i7OJLK6FLG7sj7aK8JA2GoEBu9iX2LecMNPuEjZdtWls8TsxQdV10Ud1gOgTMCdt3RFEVpx7XS2q37j9oKWWAyzMDNnTgeszbayyNhCaNTEEtziXhkJZ+GjOhgkZWcgHFZEPw3bTcxYzzpxnyUYkohHL/YVNwmvWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by CH0PR10MB5339.namprd10.prod.outlook.com (2603:10b6:610:ca::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.33; Tue, 28 Mar 2023 15:23:16 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::a502:c948:c3f6:9728]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::a502:c948:c3f6:9728%6]) with mapi id 15.20.6178.038; Tue, 28 Mar 2023 15:23:16 +0000 To: libc-alpha@sourceware.org Cc: jose.marchesi@oracle.com, elena.zannoni@oracle.com, Cupertino Miranda Subject: [PATCH v5 1/1] Created tunable to force small pages on stack allocation. Date: Tue, 28 Mar 2023 16:22:58 +0100 Message-Id: <20230328152258.54844-2-cupertino.miranda@oracle.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230328152258.54844-1-cupertino.miranda@oracle.com> References: <20230328152258.54844-1-cupertino.miranda@oracle.com> X-ClientProxiedBy: LO6P123CA0039.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::19) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|CH0PR10MB5339:EE_ X-MS-Office365-Filtering-Correlation-Id: 203a9c15-926e-4ffc-40d5-08db2fa05a4b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dKCOQ3w630BGNLnel8G+9lTd7cz12xdXfhMyrAeTGHa9sAbIL/LsrDUcHoV+nQsC2bHpFpHEiin9zU2BrpkckkaQQRoovjcLT7OpQ36odoOUNadxCki72xYH7K8g50CBwxlfjH06HpI4RhD2gec0Ei56ExeoAsxttuupTOi0Yu7ZqNhCWKv4YK7BF/ja3UWD1Bo6oPWWaYXO/eDm3kpPimvaEvaqj7S/LTVt8VhY46KJcvcvUTQ4K84RDPtSgk1j0MhFmvXX4U0JmEehaEWb0i89TFV+HeLuehmBAq5Ck7iKpI3NbRqGjInmgF1f5nvuNI8bwROGZm5x0r/gHLq+V0qp0m5MS7qFgu7BUnrX9uYjWn8/D2oOlNk8N75dVsi0HzUoerHtB7NgeKnwqVFu2oKOut0vQ4H5gGDnP/eWBoV8aNWwTGlUu+DN0hrmc5IKNQ9hMAu/ckoIYs3do8du+fvGxSae5GODuoMUcSiwV7P9hVV8h4jIfgjrzBVWokN3kgmnXgewrZmjYdPPHNkYo/BgWBnC12wDV/WGASgKc7twiqCZ6KjVSERxVJ8YMB6T X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR1001MB2340.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(376002)(366004)(136003)(39860400002)(346002)(451199021)(2616005)(316002)(478600001)(1076003)(186003)(107886003)(6506007)(6666004)(2906002)(5660300002)(6486002)(44832011)(8936002)(6512007)(86362001)(36756003)(66556008)(66476007)(38100700002)(66946007)(4326008)(8676002)(41300700001)(6916009); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: dScNePtHMaj3D/W04fEzaKXdjy0SyZdS5cBb8L3O3b2fH67/xINLhMC9ln8Z+h+zX0AZ9wFOMW7eY9cl/FQiZibN6wAORIEV5nao2lP6m0UQyLbTQinUhIVyiiruar6F/hvLWLs4D2aIYmhjf7qCT0NkxoJbD3WI7nDlz0nJEHykZQDwtGZnn60v/hdW4q0a/IE0kOAkugBTYlwnGWcz7uS9Hn0dvJvNIkQS181VweRTSWF0OQKXuAkfMRQ3LjAG1PCintCNVzU0NMTikyGLF8uz8hGV3ch/GGyxOicNdK26YQTkOXpot4k0/bnZ3A6Slm5IiB1skc0lJ4au/K4gSACL3qBvfO0skjdLBKyZkhJFUC/vHyZ03/2D2Q6hQZJQztHvjxynIR1VH+fRupXa9HEVjRah836TU9iJ6BKMPXTz2+mMTRKDjYEIMIq5Ve5eztnxF0gynCh3/N49v2/vLrOovj6AWvPta9dfgzGTElotlmKsvPdpoJZgUdaD3tkVATf9UQR62kYB7K09M10usen/VSk9h8/Atn/x6aO1C43o17ro2ZGh/Hj/jUAbDNhUFprZI9Zz5rJ/zaHZcgByI0SDG3HvCOHFTzbxXw9iYfTk3Sxeblqf+nhXmn7nyLNHB4J0fCQxq8HhWPq7w0B/RntiF3YZzCjtfbHWbaJXzrp06Tl/KIhnbnynXkPUmXKn7FfArjEjCxn1ZDmBRV5cR/HN1uhDgg+lXiAojAIlq9ehg6x4AnC1ASikWWHxLUHR5nWSfi8yP9K9wykaSptTEqQVlOUfqpj3XJ2LN+Hl/OzeYjOP9YxCj6dthcl4aENFOtxzoz3u1+Cfv2UJfq9Uh/LWT2xzgmUcn2otQpk1rs1SorZWrWTmnJcxpA7DMLTffVlRH9Gna4nHQ1bd58oZ1/hP1u9nr+5y68y2WYgyULMpjdeqGcT8Hmzl5+PzPcqPzEt1RgDmUlELsv04h9L+Nv/EVvPABqN6ipz7VsSfbOf+2bHbGIiRKHVvfnGzfKOkNfrJea6mKfIwRLVru6gh616Q49t5aKPojRNot13yJcTpa5gcR7qKQHtsgqhaIMeOqfqdSTrh6eLmdRYPQWYvX6xFmPXgwrL19oNy2MOL9mJmzM0eud6mr9hKVTowPvrwcMhpHoxGinMpPHMPCyAqoSwExaamGGnnG4TsEZci439fWm9iwUdV0FIMQdge6Sh5gNBdJiMOqZNn4nfReXVxQPfwbDISG1BHAXmNQLUFrHl6KUCyWbteKslP7Q2c82yS66DabT1yQvwky48G1P0s+5lSLMz0WPpUAuJq6cAsZcp5ApLQBXXPIIdcPfE1BckpGfcCO/PYI64sAziwH1tsFx/Kqoki1jyTYWuosUieBWc9hqwkOLBr4qeRYXFqbS/nJlnLjshB4nQS0M1BlMEceiKYWXcvKk2qChnJJDhI017F+PMP3T6RGXvrTiES6OzMgcbGxeN0qM5dcV78Z8q+5wVFZQ3zQfi9T0pazU/LbVwSMtFav/ugQj2eXv6mtWrewnF/cbhHp2dSyfHx8oqs5JObxYrxtmQG1V/7WE58WgQo9kYKCbEH/FGCvapJPZ5LVull0d6yl852IDA00e2/n+Yr9QCuNtXmDhuFmV0LypQ+WtL4WKC+3o29gMpMZ4r2 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2PHt+WRVKnsipNvE/UK8Qxe0Y8rXnZQQhZFy3Sq1ox6V5BosCKMH+jRv58hPoZKke11EK9gZoawkph5pwcz/PXQSeqiUP4EZu9GEyaZHQMw/cs6wXvHPh40qsfSSFAx7yg/zpWmS/AJvnE0fHhD8KRLiOVY62yXoLD7LypHO4dr4nJH6Tn7lXn6u2vIMEMfk5XJjNI0g2Wb0/RuVv+8FceecjQuueLAtAL/hkCWeI16ZnjPH7e84qKMssljVwoxfgTjDxRS9rMYMKa6Xd9J77IFV/rfcJ5DrFn4TpVAnJdvPFdqQnUR2dFdbLVQbSiWQQti2gUhCuwHucDnkMDtLfet6oCYpj3X08gqxBOt0ebqpSZEsmDnxMBqtCIbyDgcnVp3d9sTre+/e9XKNWr4EOrUO13kVxrWtOc4ZqSVi0oN9tiqLWGQNy/ksrTI0VvWAuj5hbNhd5VV7UbHeAifznBaatyjKiQSh1JVDN8TLX1hRlWQmHcdHe75dx0wxXt0fpvP3kek7XD2Qq/mrKTqmOhhfyeExRI0OfTUAuunMfop17ddJiB8aWhd5AyCmXPTE5IDV9yLEHK1nfy6WQzRCCEHHcHD5xpvgdP4l9Rq3VIrC2eZ7vlyhrV+RsYjVv0/6p/0acSiIK5dcwe9I5SuZA6v9/g0ZjvjK58ZX657J9t9klZaY1YTeIxmIYs54o+lCxe1W/9TCC5hNTpGfmtE0IEd8j4OOK1LrdPup8blbnOUugiEsch4xZDP03qRcl2FK X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 203a9c15-926e-4ffc-40d5-08db2fa05a4b X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2023 15:23:16.1242 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uHvA8se8S5GUteMwbT863f7ycSWMietR8SVvJa6BvDjsNl6eZJFEyYvPfiin+Ddd+kHLhBn9fDzW4QR4OdspP0TGn6pWVBszV/7LY6tNKX4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5339 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-24_11,2023-03-28_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0 adultscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2303280120 X-Proofpoint-GUID: rD_o8OtjW0V4T7UMYezeIEN5hfo2kWC2 X-Proofpoint-ORIG-GUID: rD_o8OtjW0V4T7UMYezeIEN5hfo2kWC2 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Cupertino Miranda via Libc-alpha From: Cupertino Miranda Reply-To: Cupertino Miranda Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Created tunable glibc.pthread.stack_hugetlb to control when hugepages can be used for stack allocation. In case THP are enabled and glibc.pthread.stack_hugetlb is set to 0, glibc will madvise the kernel not to use allow hugepages for stack allocations. Changed from v1: - removed the __malloc_thp_mode calls to check if hugetlb is enabled. Changed from v2: - Added entry in manual/tunables.texi - Fixed tunable default to description - Code style corrections. Changes from v3: - Improve tunables.texi. Changes from v4: - Improved text in tunables.texi by suggestion of Adhemerval. --- manual/tunables.texi | 15 +++++++++++++++ nptl/allocatestack.c | 6 ++++++ nptl/nptl-stack.c | 1 + nptl/nptl-stack.h | 3 +++ nptl/pthread_mutex_conf.c | 8 ++++++++ sysdeps/nptl/dl-tunables.list | 6 ++++++ 6 files changed, 39 insertions(+) diff --git a/manual/tunables.texi b/manual/tunables.texi index 70dd2264c5..130f94b2bc 100644 --- a/manual/tunables.texi +++ b/manual/tunables.texi @@ -459,6 +459,21 @@ registration on behalf of the application. Restartable sequences are a Linux-specific extension. @end deftp +@deftp Tunable glibc.pthread.stack_hugetlb +This tunable controls whether to use Huge Pages in the stacks created by +@code{pthread_create}. This tunable only affects the stacks created by +@theglibc{}, it has no effect on stack assigned with +@code{pthread_attr_setstack}. + +The default is @samp{1} where the system default value is used. Setting +its value to @code{0} enables the use of @code{madvise} with +@code{MADV_NOHUGEPAGE} after stack creation with @code{mmap}. + +This is a memory utilization optimization, since internal glibc setup of either +the thread descriptor and the guard page might force the kernel to move the +thread stack originally backup by Huge Pages to default pages. +@end deftp + @node Hardware Capability Tunables @section Hardware Capability Tunables @cindex hardware capability tunables diff --git a/nptl/allocatestack.c b/nptl/allocatestack.c index c7adbccd6f..f9d8cdfd08 100644 --- a/nptl/allocatestack.c +++ b/nptl/allocatestack.c @@ -369,6 +369,12 @@ allocate_stack (const struct pthread_attr *attr, struct pthread **pdp, if (__glibc_unlikely (mem == MAP_FAILED)) return errno; + /* Do madvise in case the tunable glibc.pthread.stack_hugetlb is + set to 0, disabling hugetlb. */ + if (__glibc_unlikely (__nptl_stack_hugetlb == 0) + && __madvise (mem, size, MADV_NOHUGEPAGE) != 0) + return errno; + /* SIZE is guaranteed to be greater than zero. So we can never get a null pointer back from mmap. */ assert (mem != NULL); diff --git a/nptl/nptl-stack.c b/nptl/nptl-stack.c index 5eb7773575..e829711cb5 100644 --- a/nptl/nptl-stack.c +++ b/nptl/nptl-stack.c @@ -21,6 +21,7 @@ #include size_t __nptl_stack_cache_maxsize = 40 * 1024 * 1024; +int32_t __nptl_stack_hugetlb = 1; void __nptl_stack_list_del (list_t *elem) diff --git a/nptl/nptl-stack.h b/nptl/nptl-stack.h index 34f8bbb15e..cf90b27c2b 100644 --- a/nptl/nptl-stack.h +++ b/nptl/nptl-stack.h @@ -27,6 +27,9 @@ /* Maximum size of the cache, in bytes. 40 MiB by default. */ extern size_t __nptl_stack_cache_maxsize attribute_hidden; +/* Should allow stacks to use hugetlb. (1) is default. */ +extern int32_t __nptl_stack_hugetlb; + /* Check whether the stack is still used or not. */ static inline bool __nptl_stack_in_use (struct pthread *pd) diff --git a/nptl/pthread_mutex_conf.c b/nptl/pthread_mutex_conf.c index 329c4cbb8f..60ef9095aa 100644 --- a/nptl/pthread_mutex_conf.c +++ b/nptl/pthread_mutex_conf.c @@ -45,6 +45,12 @@ TUNABLE_CALLBACK (set_stack_cache_size) (tunable_val_t *valp) __nptl_stack_cache_maxsize = valp->numval; } +static void +TUNABLE_CALLBACK (set_stack_hugetlb) (tunable_val_t *valp) +{ + __nptl_stack_hugetlb = (int32_t) valp->numval; +} + void __pthread_tunables_init (void) { @@ -52,5 +58,7 @@ __pthread_tunables_init (void) TUNABLE_CALLBACK (set_mutex_spin_count)); TUNABLE_GET (stack_cache_size, size_t, TUNABLE_CALLBACK (set_stack_cache_size)); + TUNABLE_GET (stack_hugetlb, int32_t, + TUNABLE_CALLBACK (set_stack_hugetlb)); } #endif diff --git a/sysdeps/nptl/dl-tunables.list b/sysdeps/nptl/dl-tunables.list index bd1ddb121d..4cde9500b6 100644 --- a/sysdeps/nptl/dl-tunables.list +++ b/sysdeps/nptl/dl-tunables.list @@ -33,5 +33,11 @@ glibc { maxval: 1 default: 1 } + stack_hugetlb { + type: INT_32 + minval: 0 + maxval: 1 + default: 1 + } } }