From patchwork Thu Mar 9 18:08:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harald Anlauf X-Patchwork-Id: 66180 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E8E26385802F for ; Thu, 9 Mar 2023 18:08:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E8E26385802F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1678385319; bh=CkI4hT8is3fDuCfFklT84qRsM38o2H9Nl9K1xL0bac4=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=oxZfdUAVed6VYtUmrAdrubpwAbzQMKAQrfJHHtR5wsgZR98Js28N92lFpVNORElw3 FIpT3n96YrzVmfFtlg3De8daCVZ75QEUlzCZrf6d1NUjqYuhmmkrT04QnV7BNq9A31 XyzOWZsgFMeKbqpn1JFElPdrixejnQzw86jNBF8c= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id 685483858D20; Thu, 9 Mar 2023 18:08:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 685483858D20 X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [93.207.86.196] ([93.207.86.196]) by web-mail.gmx.net (3c-app-gmx-bap32.server.lan [172.19.172.102]) (via HTTP); Thu, 9 Mar 2023 19:08:09 +0100 MIME-Version: 1.0 Message-ID: To: fortran , gcc-patches Subject: [PATCH] Fortran: fix ICE with bind(c) in block data [PR104332] Date: Thu, 9 Mar 2023 19:08:09 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:zje+osVa6zhyuH+JqujqwSqTV6AcKQChtEJh6y0tJqNimVoYD6Gg9q65bKe5Z5fhUZIDO B27ojuS6nIVG4R1sUxfIZp4q8jVZGXDyGXOjW+xZqmCdm10SMv5PPTctezFamTiKugnn/AGywILN fcn4o7D3SeK3L4UMZREzyG9Ryw4b9lM37QVSqidAfV8rqiyujejHjZjaDKa8isGf9UHWxm6AFFAm Vf08XAb1WXDPCcBg/s9NB2RA1ck8zzOY2GFJ9QCiu0N9CpSv1OzIrV+7ifT2CYu6PXe2V5dcHMbr iU= UI-OutboundReport: notjunk:1;M01:P0:iwRJllJTKFk=;VIPFUmZ+z0OqMX5eHkCGlwAN2Nv f86dFBtDT5+Am4ZbuVJiZvQAEPkvrBZn/xJ6HVwTBn6594463jko+4y+lURsMDLSKsa7Yun+F UAOIWRK9ePLE6ae7K8wLzfwoLF9RpEaB56zxyzNbWwWdhuz764VjkEvYW9bdkLq0gtAwikh4a Mj7VAZpxhNT5gVRMUJIUXzMi3U8dcjxxnxhauTmGmg3FNOpeOfgicsezkVScD+kvjUsjUG4gK nhFKtmeu31JxO+9oL++JoiQ+uU6/UFiXPfOOIus30BSwbL+h+yKEFTPqwExlHge+Y7dhfrQFq hl/pL0fjEMras1ql1jJ+4NAMeH9JxAP8Xa1YYR7V+NkwesVpZNKrUj31+mmhA4SR4jiNKZY4f 46/dKO0lTQAO4LadUxTOVKPQhPjv7HlI4qdYKDKVvweJtUZbsQZMccuKCoDL9NVxHceUEtm/W Ejr9v9N/TV54qb+GrgF9r06uzKWOipDrrpHnGpmhx39+A/Peo/IkDU3vwO0Kt0KeoT9DWjphd Nj1smEVwB0vEgcDH4/s+hk1Z2E+HYTUHk5YdQEmTW8l0hdiJqjXFASITShU0ESDMDv3sZ5Db1 hYh8fUPZw3sSQAVFd0gLJXsknz3HbNPWTws4T7mx/0BxtgySO2tW9aYSUn+lq3VHbymUWK+eT 5YBt8a7dQ1vs3JGsKi5uCEG1moYTDLZd3khA0bhvXKimThkfhtCm/UZfFfbA9mNuslgGPAkGR sSsIbS61a3shueeeL9OcnLoFYa/D3k8euBva2ykSZRuumdc69CYkrNC89x8DAM64Yg2vTlXEY GBAixio0SeUsdWnv2Rty+vqg== X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harald Anlauf via Gcc-patches From: Harald Anlauf Reply-To: Harald Anlauf Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Dear all, the attached almost obvious patch fixes a NULL pointer dereference in a check of a symbol with the bind(c) attribute. Regtested on x86_64-pc-linux-gnu. OK for mainline? This PR is marked as 10/11/12/13 regression, thus it should qualify for a backport. It's simple enough anyway. Thanks, Harald From ef96d7d360c088d68e3b405401bdb8b589d562f2 Mon Sep 17 00:00:00 2001 From: Harald Anlauf Date: Thu, 9 Mar 2023 18:59:08 +0100 Subject: [PATCH] Fortran: fix ICE with bind(c) in block data [PR104332] gcc/fortran/ChangeLog: PR fortran/104332 * resolve.cc (resolve_symbol): Avoid NULL pointer dereference while checking a symbol with the BIND(C) attribute. gcc/testsuite/ChangeLog: PR fortran/104332 * gfortran.dg/bind_c_usage_34.f90: New test. --- gcc/fortran/resolve.cc | 4 ++-- gcc/testsuite/gfortran.dg/bind_c_usage_34.f90 | 21 +++++++++++++++++++ 2 files changed, 23 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gfortran.dg/bind_c_usage_34.f90 diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc index 2780c82c798..46585879ddc 100644 --- a/gcc/fortran/resolve.cc +++ b/gcc/fortran/resolve.cc @@ -15933,8 +15933,8 @@ resolve_symbol (gfc_symbol *sym) /* First, make sure the variable is declared at the module-level scope (J3/04-007, Section 15.3). */ - if (sym->ns->proc_name->attr.flavor != FL_MODULE && - sym->attr.in_common == 0) + if (!(sym->ns->proc_name && sym->ns->proc_name->attr.flavor == FL_MODULE) + && !sym->attr.in_common) { gfc_error ("Variable %qs at %L cannot be BIND(C) because it " "is neither a COMMON block nor declared at the " diff --git a/gcc/testsuite/gfortran.dg/bind_c_usage_34.f90 b/gcc/testsuite/gfortran.dg/bind_c_usage_34.f90 new file mode 100644 index 00000000000..40c8e9363cf --- /dev/null +++ b/gcc/testsuite/gfortran.dg/bind_c_usage_34.f90 @@ -0,0 +1,21 @@ +! { dg-do compile } +! PR fortran/104332 - ICE with bind(c) in block data +! Contributed by G. Steinmetz + +block data + bind(c) :: a ! { dg-error "cannot be BIND\\(C\\)" } +end + +block data aa + real, bind(c) :: a ! { dg-error "cannot be BIND\\(C\\)" } +end + +block data bb + real :: a ! { dg-error "cannot be BIND\\(C\\)" } + bind(c) :: a +end + +block data cc + common /a/ x + bind(c) :: /a/ +end -- 2.35.3