From patchwork Wed Mar 8 11:04:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 66125 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D35EB3850215 for ; Wed, 8 Mar 2023 11:04:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D35EB3850215 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678273480; bh=f4pOxucEvsdHDcbKn+++5jMJLK0GCqHU80XSWjDsass=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=iCxlAWV0uLF03RoL7VsP9ECMHEIllQsq6m6WdmC8ezZhAje0KUEfS2IVqWlNi2cH4 G0W5r0jmHd24mW9txUAbCDy/8iGIXf72NyBTxu6NP/QcPy5nbcBExOvehOSMUqwZgN SarxTcmyyzuAxomzkb/hItg9sPrQZJNhOgK+GMy8= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2055.outbound.protection.outlook.com [40.107.13.55]) by sourceware.org (Postfix) with ESMTPS id 3750E3850217 for ; Wed, 8 Mar 2023 11:04:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3750E3850217 Received: from FR3P281CA0124.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::15) by AS8PR08MB8492.eurprd08.prod.outlook.com (2603:10a6:20b:565::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.27; Wed, 8 Mar 2023 11:04:15 +0000 Received: from VI1EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:94:cafe::21) by FR3P281CA0124.outlook.office365.com (2603:10a6:d10:94::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.17 via Frontend Transport; Wed, 8 Mar 2023 11:04:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT022.mail.protection.outlook.com (100.127.144.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.17 via Frontend Transport; Wed, 8 Mar 2023 11:04:13 +0000 Received: ("Tessian outbound 0df938784972:v135"); Wed, 08 Mar 2023 11:04:13 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0add613c9ab2afec X-CR-MTA-TID: 64aa7808 Received: from c924ce22111a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 53286F03-646C-431B-ABB5-9C75D377928E.1; Wed, 08 Mar 2023 11:04:06 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c924ce22111a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Mar 2023 11:04:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XvqWwHvkVHrRvZvE0u4jiEtFLbf42CezybpcxQkhAC0N+DSrdPLTU0F9etUEtycCZKEFvMcJS78qpsY3r9RFFjPgne7ijWrP5DQ8AroduzWbyO+W6KxNCor68rA53wQmeSCdAT60znF/YfG5NzgwVAIXSr5ceF/h/3rwAjzQfPlglMEApv8xDXUnoO/FbSI0plYPTUhmRVjGGJrEzTY0cNnVUODMhG83S98MmYWBCzO6XSxzoXnx5x1yL6spzD/VHQ7fqYhZuDIyLKffaaFiUuzSta3P1k3zyYm/mxLypR1U4QOFbmDXglfOd9vX0HifVCA8YC83+bqrc1H+8AbYZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f4pOxucEvsdHDcbKn+++5jMJLK0GCqHU80XSWjDsass=; b=QDa4ha0+nI0Z7OxeB80Z30Fna+qM818hJfmNaQ0oN9oMmSM5stBQ0Op0KOqHZPzPUTXAKawrOQZ/7Pm3HDUZBD1TyJ1ZHZRlcDcP9IoQPts6na4c8VBdj+eZdAQWh8S8L3LUcehIZnxH0tz95rwt+Uz4SnDEtccFLIiGSzIv1ardNIF3tFHzKFk+vpTuIJJLgk/RGWAuOil+66HulN2dtNbEL0W6iuZKOOBam5zlqF/obuDq33GgCgbvUONnyLspFrv+e101nPQynsnvCzWlaSlEr3cxq1dxXMzqTaMyGuCzXH5q9XLSzjEXAvSeeFaXz8kb6TbNWdWsaf/GHq0RQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by DU0PR08MB9874.eurprd08.prod.outlook.com (2603:10a6:10:422::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.16; Wed, 8 Mar 2023 11:04:03 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573%7]) with mapi id 15.20.6156.025; Wed, 8 Mar 2023 11:04:03 +0000 To: 'GNU C Library' Subject: [PATCH] Benchtests: Remove simple_str(n)casecmp Thread-Topic: [PATCH] Benchtests: Remove simple_str(n)casecmp Thread-Index: AQHZUa2SVAHu0rwv+Ea2kJSv6Zoo8w== Date: Wed, 8 Mar 2023 11:04:03 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|DU0PR08MB9874:EE_|VI1EUR03FT022:EE_|AS8PR08MB8492:EE_ X-MS-Office365-Filtering-Correlation-Id: 20403a08-37f1-453d-385c-08db1fc4da27 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dJv1scjZnEO+YIgYJjSzsxDouJQ6X7gEKYYQYQxIIG6sOpTHY6nIwPiEYAspDQjn9M7c+ukxAgW2BhhUPuLnTu0afzt7tyqaV1fdhd7MGm3fCW9PzDwOsIt+SOjq8PZcGfbR62f+eSLwT0ybPUGaZmwVH3Vaodjn0SeLemVUUpXQrOiFUJczLhkJ0Mss38a3TapvtBoksAJPJnWNOWNdAk+aiPZCP7oT7JjxYMvkfIOQw1UpSDfZIYQgDq+3K9dm7iprU9acVBsFRnPECCP1icgT07mTYdNpAOzbUEHLMHgoO1AQC++qO++hveNidit7Imw7b7WFC8OEUiau53fb54GfgEqnx7jYd1h+IbLI4VNJZxm0YepCqCCWsLaSMzkhsF407PzQ4HLWsOkAfFrXhuc0fKqcVLreGl1DT1SuVuF44bkjOEAz9QSpTnRbPrC/+2qTDzIbUcZgnYJONKccG8WKXGWeeJv1uOYtzc7LkvtI70i+l1I8w56jb7i1/NQal3H7d1/J7rsehYof2/8v/2qbhESzvFsZX977RRw3namUT5KCbpZzqq94W/mTXtEp+iMM1Js0MZSU+fASUyeWtVAafFJ3uCpt0Nt/jS+u1pLHdPmN3ugJI8SyIFBSB4D3K4+jdY/F/oQEAB+w+YyLF75DR+nlnrsmoSjDinOCdthZQj0j3WSFsGfUVaobQcR2R8BJk3CDM3bYQHT17eao9g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAWPR08MB8982.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(451199018)(9686003)(55016003)(38070700005)(41300700001)(186003)(316002)(8676002)(64756008)(66446008)(66556008)(66476007)(66946007)(91956017)(76116006)(6506007)(26005)(38100700002)(122000001)(7696005)(86362001)(71200400001)(33656002)(6916009)(5660300002)(2906002)(8936002)(52536014)(478600001); DIR:OUT; SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9874 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3487d0d3-d60a-4bdb-66a5-08db1fc4d3f9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VkxlY/qADxcLAeqBqY3rLm3FQWrr6X5H/YSRMEr5K5D+WW/kh4GvQmvhDaDCxldpJP6Rh9YPSTzd2PZGrlhs4a3OSmOnE48O6KdGUpNUARzbF+B+pwwdW1ygbupb/5zltfqLVevzwOoeJ2MyaNfc/yQXZZUU/q2uvJlXKAlpa1UrTLXHljZh6RIqnFCgUKkpRXRM95SPO2CvrPdD9NM9JzIgY/XOZxmHq+vdPVhwZ5mpCz3RyptqvOiPrkDaUoiUmatj+/M0omiSOwhhZ/6IFbo5ZoMnEv4V3r8i3xRJWwOWjgEWlGwxAHfmwhj1H2Kul70Qr8xZ/Aj6svSXp3eTaNAx1RbtVAU9OBuy04WTXdmMbHb7KHx2BMJEPWaPCVX6rJBhCYYxaupCuG3EKLmJzp4bOn9xGHgs/zCj7dX88Es9z/VDoJLZ87ZRjlAKfbWCHfzpYlRbUzyIa7E2BaCdBJ36CY0NVYxY+sJlFWVvGYlu9Bpqt61nxoee0a6Kq86WOVU3sXnBXaS0FOHNYKjiHvsX/xQiIpkdKeWKEX1Y8zHepf3kN/Xz3Nc5wpWXuWhV5g6L/p2A4JORH3RMwXxXi8YOMAqRYhSIrYD1CXXNC949fZM7AFBczhYZnRWV8h3nqEXP2ErRIvUBwAUFkKDqB2x6rJ5ag/fUlJuGZHuJftYZua5qB//y4BeiZal5eCxnOjBsWXFNhejY/P4r+iTNJg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230025)(4636009)(136003)(39860400002)(376002)(346002)(396003)(451199018)(40470700004)(46966006)(36840700001)(316002)(36860700001)(478600001)(47076005)(7696005)(33656002)(82310400005)(55016003)(356005)(82740400003)(336012)(86362001)(9686003)(186003)(6506007)(40460700003)(26005)(52536014)(81166007)(6916009)(2906002)(41300700001)(5660300002)(8676002)(70206006)(8936002)(40480700001)(70586007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 11:04:13.6174 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 20403a08-37f1-453d-385c-08db1fc4da27 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8492 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Wilco Dijkstra via Libc-alpha From: Wilco Dijkstra Reply-To: Wilco Dijkstra Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Remove the slow byte oriented loops. Adjust iteration count to reduce benchmark time. Reviewed-by: Adhemerval Zanella diff --git a/benchtests/bench-strcasecmp.c b/benchtests/bench-strcasecmp.c index fcfffdea42d72364d915f65cad98eaf9e11b585e..abc6a216e37b49c352fb84f723f88986c5364fb9 100644 --- a/benchtests/bench-strcasecmp.c +++ b/benchtests/bench-strcasecmp.c @@ -23,28 +23,14 @@ #include "json-lib.h" typedef int (*proto_t) (const char *, const char *); -static int simple_strcasecmp (const char *, const char *); -IMPL (simple_strcasecmp, 0) IMPL (strcasecmp, 1) -static int -simple_strcasecmp (const char *s1, const char *s2) -{ - int ret; - - while ((ret = ((unsigned char) tolower (*s1) - - (unsigned char) tolower (*s2))) == 0 - && *s1++) - ++s2; - return ret; -} - static void do_one_test (json_ctx_t *json_ctx, impl_t *impl, const char *s1, const char *s2, int exp_result) { - size_t i, iters = INNER_LOOP_ITERS; + size_t i, iters = INNER_LOOP_ITERS8; timing_t start, stop, cur; int result = CALL (impl, s1, s2); if ((exp_result == 0 && result != 0) diff --git a/benchtests/bench-strncasecmp.c b/benchtests/bench-strncasecmp.c index 5689a22901b918cf20bc58dc5175f552604bb878..051c17d9f78b62d22b4258e7ea04cc15759e2060 100644 --- a/benchtests/bench-strncasecmp.c +++ b/benchtests/bench-strncasecmp.c @@ -23,35 +23,14 @@ #include "json-lib.h" typedef int (*proto_t) (const char *, const char *, size_t); -static int simple_strncasecmp (const char *, const char *, size_t); -IMPL (simple_strncasecmp, 0) IMPL (strncasecmp, 1) -static int -simple_strncasecmp (const char *s1, const char *s2, size_t n) -{ - int ret; - - if (n == 0) - return 0; - - while ((ret = ((unsigned char) tolower (*s1) - - (unsigned char) tolower (*s2))) == 0 - && *s1++) - { - if (--n == 0) - return 0; - ++s2; - } - return ret; -} - static void do_one_test (json_ctx_t *json_ctx, impl_t *impl, const char *s1, const char *s2, size_t n, int exp_result) { - size_t i, iters = INNER_LOOP_ITERS; + size_t i, iters = INNER_LOOP_ITERS8; timing_t start, stop, cur; TIMING_NOW (start);