From patchwork Wed Mar 1 21:27:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 65870 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 47BA8384F024 for ; Wed, 1 Mar 2023 21:27:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 47BA8384F024 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677706063; bh=+yL+tZr3H8YwkZ65DGmGFLTDeli/X7lRfuhiwzz8Gsw=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=VzDglH/82EQkiDTYcyxueI7SumLXSoRATWzZujbYjVbgLz6YGhkKZ5XLAyZrg6jgU lX1v1VWjg4O1PB466JtMu4ERS8T6FAaY+rZPCcCgtDzzHmZjV2i1P2Q/EZWgHCsYJI lWwS/aBwwK2terrqTr0T+tnLG3rvk7nCd0vIRCGs= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id A2D21385084F for ; Wed, 1 Mar 2023 21:27:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2D21385084F Received: by mail-il1-x131.google.com with SMTP id i12so9211730ila.5 for ; Wed, 01 Mar 2023 13:27:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677706039; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+yL+tZr3H8YwkZ65DGmGFLTDeli/X7lRfuhiwzz8Gsw=; b=Eb4/cqFM0uwNUA0YX6nOFiC3bBU1B44Nzg5/Nh8Km29Nz2bkYu2cqvtJjtktt+RhUq peIa1JpIYA0VwwD+rBUd3UPj0c3XRS6z3fORX2Pel1eA4XpLBqz6ucJITA8h+5tA90CE 2zPnuVqN87BctzqVe7FQQ37gfP6ODe59XelbqhA5UfEDFacClkFUETdytLQSgDVDt2nS mcMf+yN0ZgYzTJY0q1+2MHhAeiZ4tTfxkIxHSRGKgGqo595EuFW856l+uE5bt6zFcS47 /Wk88NOsGt3X/JZOO1EEknlEnna/YzlegNryy7HZdhSsYxVmKx1c9PNCibbUYsjAfUAa xVjA== X-Gm-Message-State: AO0yUKX+1HpzeTKHPXVziij+TIrDP8aOURcS5oCuIiRR/hYNyM5kdT5a k1RNGnKneBmsQAMNOas7RQ8bblkimcDUOW5S X-Google-Smtp-Source: AK7set8VUWHpJR1/Iy4T24epPqq2znYbhds8BPfMAoCRfU3MtgSSLcX9jkhyDZ7ZBjROkZtRdB4bqQ== X-Received: by 2002:a05:6e02:1b0d:b0:315:4f67:7055 with SMTP id i13-20020a056e021b0d00b003154f677055mr7539975ilv.1.1677706038857; Wed, 01 Mar 2023 13:27:18 -0800 (PST) Received: from localhost.localdomain (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id k9-20020a02ccc9000000b003c4f3850000sm4243798jaq.49.2023.03.01.13.27.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 13:27:17 -0800 (PST) To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Remove dead code from scalar_binop Date: Wed, 1 Mar 2023 14:27:08 -0700 Message-Id: <20230301212708.4030388-1-tromey@adacore.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" scalar_binop has code for "&&" and "||", but I think this code can't currently be run -- and, furthermore, it doesn't make sense to have this code here, as the point of these operators is to short-circuit evaluation. This patch removes the dead code. Regression tested on x86-64 Fedora 36. --- gdb/valarith.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/gdb/valarith.c b/gdb/valarith.c index 6ea0cd9e8d1..ad53febcedc 100644 --- a/gdb/valarith.c +++ b/gdb/valarith.c @@ -1331,14 +1331,6 @@ scalar_binop (struct value *arg1, struct value *arg2, enum exp_opcode op) v = v1 ^ v2; break; - case BINOP_LOGICAL_AND: - v = v1 && v2; - break; - - case BINOP_LOGICAL_OR: - v = v1 || v2; - break; - case BINOP_MIN: v = v1 < v2 ? v1 : v2; break; @@ -1492,14 +1484,6 @@ scalar_binop (struct value *arg1, struct value *arg2, enum exp_opcode op) v = v1 ^ v2; break; - case BINOP_LOGICAL_AND: - v = v1 && v2; - break; - - case BINOP_LOGICAL_OR: - v = v1 || v2; - break; - case BINOP_MIN: v = v1 < v2 ? v1 : v2; break;