From patchwork Sat Feb 25 18:17:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harald Anlauf X-Patchwork-Id: 65649 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 20E22385482C for ; Sat, 25 Feb 2023 18:18:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20E22385482C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1677349091; bh=m9Egrz7IT3YVLsEg6OMHOtk2ZIXNkM2DbEh0QqwK/+c=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=FR5Q20tdNBiYvVaG84gjGawfqrfc+EOhYv1yMzh8M4Wr9FNB1T3VXx6aknUuyNO1+ yF0+4JRg7w3R99jiGdNxlwI9xO5l2HcuI7S8PVD5FsTWZ0Kge6SKl5cPguVanQpwTP LD6uUd+IPnFWOvxne0soS6EjglHLvwflEnpLQp24= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by sourceware.org (Postfix) with ESMTPS id 392E5385841A; Sat, 25 Feb 2023 18:17:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 392E5385841A X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [79.232.147.80] ([79.232.147.80]) by web-mail.gmx.net (3c-app-gmx-bap72.server.lan [172.19.172.172]) (via HTTP); Sat, 25 Feb 2023 19:17:23 +0100 MIME-Version: 1.0 Message-ID: To: fortran , gcc-patches Subject: [PATCH, committed] Fortran: fix memory leak with real to integer conversion warning Date: Sat, 25 Feb 2023 19:17:23 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:ywyhvl1F+sYq9hr+nt1usAw8q7SrtHNc0WuWqo7BFGwyx3/n2epG6YNEkKhiKjQZN0N5u Q2qzUmelYEWE2uMGV+TyeYTjyYMEa+v5mufFjcEMUrKsyvYoSjKDdOK/dsSQgBa3qu6c6kFcAj+c WSs/yZJh1ObvJu32fQPPBErLAKE5BBFGThQQa6fWquTktbozae/GmbILSsQbAKmtoE9da3d/UlcH iA7pCnC2Lc/DVl6Cy67xS2c0F4FcymzkLaQWmAkdMXnA60VOL3rg24f/CYEdlpIkMv9/OF1XyxJP HU= UI-OutboundReport: notjunk:1;M01:P0:PFSWobtZ0io=;NuiTnsHC4ofMysv/Dlv+bbS4aZR 0ihG4Tsd6yDMfaMMpo8Cm2FR7O6k/nUGhTdI9gWg7g2Zk/7OO4xTd+fjusnJMHvd5qBUBrPCE 4MTss/x+O6s9Gy2Letgs+SYv4YwFUcjrLt9n++D2X5QX4t4ruL6p5iZznlmEapiYHyPeP3GRp 8W0OaEBYFXsGLNNEZyudNJ6eKUZU0YNJDONn2QaGgDCSTF7U54JOsiloBD5aMwcstdE2RyTjE 0s6x6TATI2RRqUiBWtWI850H6XRzjT+ehV/XPpMzRLBp/j1zbENGbHezy6hSepSC9T34X/dD6 ihknH+nPwP7lbrxSmds70lYLONuJrDRMun0gopi7fKlrwoEbGlqGe8wxWYy8KK3X66UETNwKy DyX86iXaaksxOkTap0Gr2IWbyojHUVKxsjxh/P9OqGOVNHVUBhChZhrkXqXRrelgxfSqXnqQK fcB4gEKDct+9tN+85EuKmjeajZ5QRrsJZUfr+dyn9bXqFrBeTzNvQ9z1Eb4GoZbQbfb/FEY72 +J9trdPA0gsOhyxWbADkkp07rIcySG8s4jONFqEPUAm6ewrGGOUJ6O/nTyj2LV7HOg4hbDGUs 3cQOkcINIZ5n9nWOvuUW9o4YbjBfLBXH6IGt95pN8u/99/9k4f98YvwpsSvLys5Ibk1zSY4b+ A+3KAKlyu13C90n+BKQ+JWJGKTeG9y3OeQC8sx4k/prmUKCG0O6Fr3bn9sVOEROBWBqte75Vk 4x6fUFmXXcbxm5PdAVQJvwB0jGMTNGVIG3FBG4YSP9HV3ogWO3S3/hwxSN2JqdHAU5jeMjREM tGCKWh4yC3WWt0/KuK0+xEig== X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harald Anlauf via Gcc-patches From: Harald Anlauf Reply-To: Harald Anlauf Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Dear all, while checking f951 for memory leaks on testcases that appeared relevant during work on pr108924, I found that the conversion warning triggered by do_subscript_6.f90 uses a code path that forgot to mpfr_clear a used variable. The attached obvious patch fixes this - verified by valgrind. Pushed to mainline as r13-6344-g03c60e525bea13 . Thanks, Harald From 03c60e525bea13c15edd2f64cd582f168fe80bfb Mon Sep 17 00:00:00 2001 From: Harald Anlauf Date: Sat, 25 Feb 2023 19:05:38 +0100 Subject: [PATCH] Fortran: fix memory leak with real to integer conversion warning gcc/fortran/ChangeLog: * arith.cc (gfc_real2int): Clear mpfr variable after use. --- gcc/fortran/arith.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/fortran/arith.cc b/gcc/fortran/arith.cc index d0d1c0b03d2..37aeaf1b186 100644 --- a/gcc/fortran/arith.cc +++ b/gcc/fortran/arith.cc @@ -2257,6 +2257,7 @@ gfc_real2int (gfc_expr *src, int kind) gfc_typename (&result->ts), &src->where); did_warn = true; } + mpfr_clear (f); } if (!did_warn && warn_conversion_extra) { -- 2.35.3