From patchwork Tue Feb 21 13:10:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 65408 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D779386DFB8 for ; Tue, 21 Feb 2023 13:10:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D779386DFB8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676985057; bh=1Cy4AIt42hiSKhGdfu3FmvT9vvNZDb/qM4xLCZ8tHnY=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Pm/NSCIeQlvoy62PpJ85d7WpGk0Ms7YZNuln8Z/ElDTgH1F32KHzK8UYAZDEyyDY/ 1d6l7PTN1Va0RrkTcQhyYyXs4e+uYaSJtVcQamXbgqUtjX1O41qFPLIAdlKjiU/Dte mWN8xJ4kXu5a7lMswKm98XENnaK0F6E9EZSwD6aA= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 8B5CB386C7CF for ; Tue, 21 Feb 2023 13:10:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B5CB386C7CF Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 90DA95C61E for ; Tue, 21 Feb 2023 13:10:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7B86713481 for ; Tue, 21 Feb 2023 13:10:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Pf3+HLfC9GMrJwAAMHmgww (envelope-from ) for ; Tue, 21 Feb 2023 13:10:15 +0000 To: gdb-patches@sourceware.org Subject: [pushed] [gdb/testsuite] Require syscall time in gdb.reverse/time-reverse.exp Date: Tue, 21 Feb 2023 14:10:27 +0100 Message-Id: <20230221131027.29637-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom de Vries via Gdb-patches From: Tom de Vries Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" On aarch64-linux, I run into: ... Running gdb.reverse/time-reverse.exp ... gdb compile failed, gdb.reverse/time-reverse.c: In function 'main': gdb.reverse/time-reverse.c:39:12: error: 'SYS_time' undeclared \ (first use in this function); did you mean 'SYS_times'? syscall (SYS_time, &time_global); ^~~~~~~~ SYS_times gdb.reverse/time-reverse.c:39:12: note: each undeclared identifier is \ reported only once for each function it appears in UNTESTED: gdb.reverse/time-reverse.exp: failed to prepare ... Fix this by adding a new proc have_syscall, and requiring syscall time, such that we have instead: ... UNSUPPORTED: gdb.reverse/time-reverse.exp: require failed: \ expr [have_syscall time] ... Tested on x86_64-linux and aarch64-linux. --- gdb/testsuite/gdb.reverse/time-reverse.exp | 2 ++ gdb/testsuite/lib/gdb.exp | 11 +++++++++++ 2 files changed, 13 insertions(+) base-commit: d720176596dd6495c258fa73c4029f009616ebd2 diff --git a/gdb/testsuite/gdb.reverse/time-reverse.exp b/gdb/testsuite/gdb.reverse/time-reverse.exp index 07d55b348e8..befda65d836 100644 --- a/gdb/testsuite/gdb.reverse/time-reverse.exp +++ b/gdb/testsuite/gdb.reverse/time-reverse.exp @@ -23,6 +23,8 @@ require supports_reverse standard_testfile +require {expr [have_syscall time]} + if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { return -1 } diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index e48228ed4f6..12839a54710 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -9397,5 +9397,16 @@ gdb_caching_proc linux_kernel_version { return [list $v1 $v2 $v3] } +# Return 1 if syscall NAME is supported. + +proc have_syscall { name } { + set src \ + [list \ + "#include " \ + "int var = SYS_$name;"] + set src [join $src "\n"] + return [gdb_can_simple_compile have_syscall_$name $src object] +} + # Always load compatibility stuff. load_lib future.exp