From patchwork Mon Feb 20 13:33:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 65260 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6C000383FE16 for ; Mon, 20 Feb 2023 13:33:28 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 68EFC38493E6; Mon, 20 Feb 2023 13:33:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 68EFC38493E6 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.97,312,1669104000"; d="scan'208,223";a="98853464" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 20 Feb 2023 05:33:10 -0800 IronPort-SDR: wHND15LSjdEHcp8GnaMoBu5kOxyApMSMZCYIXKKiM1iNY59108AlGkYLr8Yy7mgaEvidS2zDFz NngGPsVFgOiC7OROK9d4o2+YUiwgzaPBmekjplsx5yLYJfsAKEGJNGwylOqOW0d/BT0S+5GWas pno6bS0+GJVXY60DuaTIwGsRxPioT/fHJ4Rv4x/U/WaMtgOdm1qpGtvzhm8ilCEpDzl3onNs5G 3OZGTdjaRk1sck7opQ6Teffqke5/WaiH0j/DXhVa5bLAmRL690SqH+L3erZ3Uoq/425oR94Afj 9N0= From: Thomas Schwinge To: CC: , Philip Herron , Philip Herron Subject: Rust: Don't depend on unused 'target-libffi', 'target-libbacktrace' (was: [PATCH Rust front-end v2 32/37] gccrs: Add config-lang.in) In-Reply-To: <20220824115956.737931-33-philip.herron@embecosm.com> References: <20220824115956.737931-1-philip.herron@embecosm.com> <20220824115956.737931-33-philip.herron@embecosm.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Mon, 20 Feb 2023 14:33:04 +0100 Message-ID: <87o7po797z.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-13.mgc.mentorg.com (139.181.222.13) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi! On 2022-08-24T12:59:51+0100, herron.philip@googlemail.com wrote: > From: Philip Herron > > This was a copy paste from gccgo front-end, we do not use any of the > target_libs yet but we will need these when we support the libpanic crate. > --- /dev/null > +++ b/gcc/rust/config-lang.in > +target_libs="target-libffi target-libbacktrace" (By the way, this setting of 'target_libs' was not present in the v1 "[PATCH Rust front-end v1 1/4] Add skeleton Rust front-end folder".) So there's the issue that not all GCC target configurations support building those libraries. Given that they're indeed unused, is it be OK to push the attached "Rust: Don't depend on unused 'target-libffi', 'target-libbacktrace'"? (..., and once we get to the point where we'd like to use libffi and/or libbacktrace, then think about how to handle those GCC target configurations.) Grüße Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 From 5d85939a3e3ebcfcf3f2ac9d3f2e01cbb1736578 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Mon, 20 Feb 2023 13:01:50 +0100 Subject: [PATCH] Rust: Don't depend on unused 'target-libffi', 'target-libbacktrace' For example: configure: error: "libffi has not been ported to nvptx-unknown-none." Follow-up to commit a75f038c069cc3a23b214854bedf04321fe88bc5 "gccrs: Add config-lang.in", which said: > This was a copy/paste from gccgo front-end. We do not use any of the > target_libs yet, [...] gcc/rust/ * config-lang.in (target_libs): Remove. --- gcc/rust/config-lang.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/gcc/rust/config-lang.in b/gcc/rust/config-lang.in index 89055be5cd4..aac66c9b962 100644 --- a/gcc/rust/config-lang.in +++ b/gcc/rust/config-lang.in @@ -29,6 +29,4 @@ compilers="rust1\$(exeext)" build_by_default="no" -target_libs="target-libffi target-libbacktrace" - gtfiles="\$(srcdir)/rust/rust-lang.cc" -- 2.25.1