From patchwork Fri Feb 17 20:02:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Baldwin X-Patchwork-Id: 65193 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A777C3881D05 for ; Fri, 17 Feb 2023 20:02:58 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2607:f138:0:13::2]) by sourceware.org (Postfix) with ESMTPS id 1579A385828E for ; Fri, 17 Feb 2023 20:02:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1579A385828E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=FreeBSD.org Received: from gimli.baldwin.net (c-98-35-126-114.hsd1.ca.comcast.net [98.35.126.114]) by mail.baldwin.cx (Postfix) with ESMTPSA id DFF3A1A84C54 for ; Fri, 17 Feb 2023 15:02:31 -0500 (EST) From: John Baldwin To: gdb-patches@sourceware.org Subject: [PATCH 1/2] gdb.arch/amd64-gs_base.exp: Support non-Linux. Date: Fri, 17 Feb 2023 12:02:18 -0800 Message-Id: <20230217200219.87439-2-jhb@FreeBSD.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230217200219.87439-1-jhb@FreeBSD.org> References: <20230217200219.87439-1-jhb@FreeBSD.org> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (mail.baldwin.cx [0.0.0.0]); Fri, 17 Feb 2023 15:02:32 -0500 (EST) X-Virus-Scanned: clamav-milter 0.103.1 at mail.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_STATUS, KHOP_HELO_FCRDNS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The orig_rax pseudo-register is Linux-specific and isn't relevant to this test. The fs_base and gs_base registers are also not treated as system registers in other OS ABIs. This allows the test to pass on FreeBSD. --- gdb/testsuite/gdb.arch/amd64-gs_base.exp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.arch/amd64-gs_base.exp b/gdb/testsuite/gdb.arch/amd64-gs_base.exp index a60e1dbe7f4..083c7c9fe1f 100644 --- a/gdb/testsuite/gdb.arch/amd64-gs_base.exp +++ b/gdb/testsuite/gdb.arch/amd64-gs_base.exp @@ -32,14 +32,12 @@ gdb_test "print /x \$gs_base" "= $hex" "print gs_base" gdb_test "print \$fs_base = 2" "= 2" "set fs_base" gdb_test "print \$gs_base = 3" "= 3" "set gs_base" -# Test the presence of fs_base and gs_base on the system -# register group and values. +# Test the fs_base and gs_base values. # set ws "\[\t \]+" -set info_reg_out [multi_line "info register sys" \ +set info_reg_out [multi_line "info register fs_base gs_base" \ "fs_base${ws}0x2${ws}2"\ - "gs_base${ws}0x3${ws}3"\ - "orig_rax${ws}$hex${ws}\[-\]$decimal" ] + "gs_base${ws}0x3${ws}3" ] -gdb_test "info register sys" $info_reg_out\ +gdb_test "info register fs_base gs_base" $info_reg_out\ "info registers fs_base and gs_base with value" From patchwork Fri Feb 17 20:02:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Baldwin X-Patchwork-Id: 65194 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C1B12382E6B2 for ; Fri, 17 Feb 2023 20:03:00 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail.baldwin.cx (bigwig.baldwin.cx [66.216.25.90]) by sourceware.org (Postfix) with ESMTPS id 9FF003857BB2 for ; Fri, 17 Feb 2023 20:02:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FF003857BB2 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=FreeBSD.org Received: from gimli.baldwin.net (c-98-35-126-114.hsd1.ca.comcast.net [98.35.126.114]) by mail.baldwin.cx (Postfix) with ESMTPSA id 6E2991A84C5E for ; Fri, 17 Feb 2023 15:02:32 -0500 (EST) From: John Baldwin To: gdb-patches@sourceware.org Subject: [PATCH 2/2] amd64-linux-tdep: Don't treat fs_base and gs_base as system registers. Date: Fri, 17 Feb 2023 12:02:19 -0800 Message-Id: <20230217200219.87439-3-jhb@FreeBSD.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230217200219.87439-1-jhb@FreeBSD.org> References: <20230217200219.87439-1-jhb@FreeBSD.org> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (mail.baldwin.cx [0.0.0.0]); Fri, 17 Feb 2023 15:02:32 -0500 (EST) X-Virus-Scanned: clamav-milter 0.103.1 at mail.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_STATUS, KHOP_HELO_FCRDNS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" These registers can be changed directly in userspace, and similar registers to support TLS on other architectures (tpidr* on ARM and AArch64, tp on RISC-V) are treated as general purpose registers. --- gdb/amd64-linux-tdep.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c index e9181649ec8..cbbac1a0c64 100644 --- a/gdb/amd64-linux-tdep.c +++ b/gdb/amd64-linux-tdep.c @@ -281,9 +281,7 @@ static int amd64_linux_register_reggroup_p (struct gdbarch *gdbarch, int regnum, const struct reggroup *group) { - if (regnum == AMD64_LINUX_ORIG_RAX_REGNUM - || regnum == AMD64_FSBASE_REGNUM - || regnum == AMD64_GSBASE_REGNUM) + if (regnum == AMD64_LINUX_ORIG_RAX_REGNUM) return (group == system_reggroup || group == save_reggroup || group == restore_reggroup);