From patchwork Thu Feb 16 17:26:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 65126 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DEDCC3858281 for ; Thu, 16 Feb 2023 17:27:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DEDCC3858281 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676568433; bh=hlFF2RsUKaXnDGkSna9z2PKiIQ1kM4jPYX1UEtyY1Rk=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=jbWM8Vr8r9QKzApOtK7rMrRnDXpLQrvJ+6FFsxqPz4Uu9h5qOEcPZSM2Zg4cM6Hol Qp/RbTfIptr9WxNKDxHRNIKzQQGZS26n7Z0EE6k4pxH/4pGyEcwBEdl58fVxf4C5Cj 1xg5VM0V+Qi5TSJ++rvMK0+78eYG/oXAEAvlqX4g= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by sourceware.org (Postfix) with ESMTPS id C426C3857B93 for ; Thu, 16 Feb 2023 17:26:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C426C3857B93 Received: by mail-io1-xd36.google.com with SMTP id j17so911885ioa.9 for ; Thu, 16 Feb 2023 09:26:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hlFF2RsUKaXnDGkSna9z2PKiIQ1kM4jPYX1UEtyY1Rk=; b=2/qBcKTmEArgPAF4UGm2DRpvJ/yF/MfYZrDoykBMbsyhCkDWhzbdzZtjUxwVQKN42i HmsXCB6JXg9xyMiCrZb29+eldEpdUteygb2pJV8F5hF3QNf99BwjaCgVsCDYWww+9jpY 7XEV4KISYESndVP3is5srjCiMRZcq4CwOtBuUQQ3uw8LMhexfbQ5h908aMjCZMb9Pdz9 2tyJF7HwZzJjuF3PFVeRqmms177Qi/z0FbDt6ffKvvkAmfBlvoaFDtUGbmc9OAl7WAfq iGzxiCAaHdpDxr/sJVGmiWDUepVvskZROYdVtxUS4cbzy5Wi/5daKbsln6y5N/2cX2zL YcVg== X-Gm-Message-State: AO0yUKVyh4BJbcZOUINVPIiRxhKZgkFQie/Hhco3Xhkd+KJqMnK6sK1i v61MtV7T6ZV37Tv5HUnAmscqfvdYXHeGhOML X-Google-Smtp-Source: AK7set8+Xh9w+TjwRft4Fa5F+iKiwkCumkuApsLRRIRBObw5j9E4FQALrcR6qjFhR+1JvpiuJ3lKfQ== X-Received: by 2002:a6b:d90e:0:b0:719:e423:4329 with SMTP id r14-20020a6bd90e000000b00719e4234329mr5562702ioc.7.1676568394990; Thu, 16 Feb 2023 09:26:34 -0800 (PST) Received: from localhost.localdomain (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id s22-20020a02cc96000000b003a58ae912aasm717507jap.28.2023.02.16.09.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 09:26:34 -0800 (PST) To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Remove exception_catchpoint::resources_needed Date: Thu, 16 Feb 2023 10:26:24 -0700 Message-Id: <20230216172624.2238588-1-tromey@adacore.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" exception_catchpoint::resources_needed has a FIXME comment that I think makes this method obsolete. Also, I note that similar catchpoints, for example Ada catchpoints, don't have this method. This patch removes the method. Regression tested on x86-64 Fedora 36. --- gdb/break-catch-throw.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/gdb/break-catch-throw.c b/gdb/break-catch-throw.c index ab7899e2b9c..457446efbc6 100644 --- a/gdb/break-catch-throw.c +++ b/gdb/break-catch-throw.c @@ -94,13 +94,6 @@ struct exception_catchpoint : public code_breakpoint void check_status (struct bpstat *bs) override; struct bp_location *allocate_location () override; - /* FIXME this is temporary - until ordinary breakpoints have been - converted. */ - int resources_needed (const struct bp_location *) override - { - return 1; - } - /* The kind of exception catchpoint. */ enum exception_event_kind kind;