From patchwork Tue Feb 7 12:14:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Schimpe, Christina" X-Patchwork-Id: 64440 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C0B93858C30 for ; Tue, 7 Feb 2023 12:18:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C0B93858C30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675772294; bh=UtkmTFxQc8XZelGSAKjiwEJ2dqwgHG1aY1590hXKULY=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=Mf0ym3qhrB/6yhojLIe1cZIs3KahuUyL4H/gMiPB0wd7IvoHfgGLBEZHrPYjAGVlH YQd2YPI0yAp8lJ9W/7lDJ+dADSK8qftrY6DkYsh4HYzCuhBvuadw7y4FjJ05/l+G8j lWDe7WN0b0teYpl5kqGsEXWMq2owvCEgofPzpYNE= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id BA8FB3858D33 for ; Tue, 7 Feb 2023 12:17:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA8FB3858D33 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="415709525" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="415709525" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 04:17:47 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="912309179" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="912309179" Received: from labpc2315.iul.intel.com (HELO localhost) ([172.28.50.57]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 04:17:46 -0800 To: gdb-patches@sourceware.org Cc: Christina Schimpe Subject: [PATCH 1/1] gdb, testsuite: Remove unnecessary call of "set print pretty on" Date: Tue, 7 Feb 2023 13:14:25 +0100 Message-Id: <20230207121425.3779898-1-christina.schimpe@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christina Schimpe via Gdb-patches From: "Schimpe, Christina" Reply-To: Christina Schimpe Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The command has no effect for the loading of GDB pretty printers and is removed by this patch to avoid confusion. Documentation for "set print pretty" "Cause GDB to print structures in an indented format with one member per line" --- gdb/testsuite/gdb.python/pretty-print-call-by-hand.exp | 4 ---- .../py-autoloaded-pretty-printers-in-newobjfile-event.exp | 2 -- 2 files changed, 6 deletions(-) diff --git a/gdb/testsuite/gdb.python/pretty-print-call-by-hand.exp b/gdb/testsuite/gdb.python/pretty-print-call-by-hand.exp index 7ab2b1facf7..01ee7b9d3d2 100644 --- a/gdb/testsuite/gdb.python/pretty-print-call-by-hand.exp +++ b/gdb/testsuite/gdb.python/pretty-print-call-by-hand.exp @@ -50,8 +50,6 @@ proc start_test { breakpoint_comment } { gdb_breakpoint [gdb_get_line_number ${breakpoint_comment} ${testfile}.c ] gdb_continue_to_breakpoint ${breakpoint_comment} ".*" - gdb_test_no_output "set print pretty on" "starting to pretty print" - set remote_python_file [gdb_remote_download host ${srcdir}/${subdir}/${testfile}.py] gdb_test_no_output "source ${remote_python_file}" "load python file" @@ -64,8 +62,6 @@ with_test_prefix "run to frame" { untested "couldn't run to main" } - gdb_test_no_output "set print pretty on" "starting to pretty print" - set remote_python_file [gdb_remote_download host ${srcdir}/${subdir}/${testfile}.py] gdb_test_no_output "source ${remote_python_file}" "load python file" diff --git a/gdb/testsuite/gdb.python/py-autoloaded-pretty-printers-in-newobjfile-event.exp b/gdb/testsuite/gdb.python/py-autoloaded-pretty-printers-in-newobjfile-event.exp index 2217e2e6527..eefa99c8fa1 100644 --- a/gdb/testsuite/gdb.python/py-autoloaded-pretty-printers-in-newobjfile-event.exp +++ b/gdb/testsuite/gdb.python/py-autoloaded-pretty-printers-in-newobjfile-event.exp @@ -61,8 +61,6 @@ gdb_test_no_output "source ${remote_python_event_handler_file}" "load python fil gdb_load ${binfile} -gdb_test_no_output "set print pretty on" - if { ![runto_main] } { return }