From patchwork Sat Feb 4 16:50:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ed Catmur X-Patchwork-Id: 64298 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DDBB4385B50D for ; Sat, 4 Feb 2023 16:50:56 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by sourceware.org (Postfix) with ESMTPS id 461673858C52 for ; Sat, 4 Feb 2023 16:50:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 461673858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=catmur.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=catmur.uk Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 2077A5C00F4; Sat, 4 Feb 2023 11:50:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 04 Feb 2023 11:50:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catmur.uk; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=1675529440; x=1675615840; bh=+KIz6YqgJwX2I9NvDQ2rrMATA inwDp9p9dy15Y0bzuM=; b=w1GckR7vS2p99euncucsd8bxVUXbN4OstdJl8uGCK 70j5jR60FHTyrYZ9KwzDW0n/JPN3FI+l50XFrK4sIITXg22Hgs3JsXb9YWR1YOhh X46aUijatBJ3WLk2T4vuTiZgGAiL7+24rqowENV+S7TUuzRoziZ0Hd6yFE0GMSC2 KKuo4PP0B0DFeFo+ShwOB7Y0+FUeQgmoX18eiHm/vvgaVJqWrAfzdKue7ylxPeE5 QQFRcGQMlKa4dWwqxV1Da5rrM8TGjrWGsjJx6vvsQSZT0F5/ZNQxJ/Qm6DIrpVC+ ToOMjV0UXx0dEel/KX86M38BbcZ2p7pCJ87R0YZ4G2LEA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1675529440; x=1675615840; bh=+KIz6YqgJwX2I9NvDQ2rrMATAinwDp9p9dy 15Y0bzuM=; b=Yg+z0IWDjWrBEiMixOZ60E1QRfHx9vWffeJLInkO5ooWfZD6v/2 6AFN92hsNnIf/q+6efODM3i6aO+va+62/JWt+SNWR1eltriDMtV0EUgaQJGflVN4 qRLlC7kaR6vFaDCAAekzp51nduUwdopiK5XlQy6g6wTyjM1j/i4dvKJx2N75XxGT 5WPC2CIbDR/HyLF0CHitAo9kQz/JMgVVkQr5FgQD5WTAmsRsMN6PUFDshVzMI6bX 13g92eJ/lamTG4Quxq/pWRSv8ArAbvBOVsv94P72SdBgS2OIFaOYaARX8u/x/UKf QvmfK7+Y2QraxbuhaVcW/8VIzOM5CgQ1Q7Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegvddgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpefgugcuvegrthhmuhhruceovggusegtrghtmhhurhdruhhkqeen ucggtffrrghtthgvrhhnpeeuvddtkedugeekkeegkefhjeejjeeltdekgeeitddtleffje eggefgjeejfeduueenucffohhmrghinhepugifrghrfhhsthgurdhorhhgpdhgnhhurdho rhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepvg gusegtrghtmhhurhdruhhk X-ME-Proxy: Feedback-ID: i5729427b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 4 Feb 2023 11:50:38 -0500 (EST) From: Ed Catmur To: gcc-patches@gcc.gnu.org Cc: Ed Catmur Subject: [PATCH v3] emit DW_AT_name for DW_TAG_GNU_formal_parameter_pack [PR70536] Date: Sat, 4 Feb 2023 17:50:33 +0100 Message-Id: <20230204165033.4026-1-ed@catmur.uk> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Per http://wiki.dwarfstd.org/index.php?title=C%2B%2B0x:_Variadic_templates DW_TAG_GNU_formal_parameter_pack should have a DW_AT_name: 17$: DW_TAG_formal_parameter_pack DW_AT_name("args") 18$: DW_TAG_formal_parameter ! no DW_AT_name attribute DW_AT_type(reference to 13$) (...) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70536 --- gcc/dwarf2out.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/dwarf2out.cc b/gcc/dwarf2out.cc index 1f39df3b1e2..462328acd9f 100644 --- a/gcc/dwarf2out.cc +++ b/gcc/dwarf2out.cc @@ -23041,7 +23041,7 @@ gen_formal_parameter_pack_die (tree parm_pack, && subr_die); parm_pack_die = new_die (DW_TAG_GNU_formal_parameter_pack, subr_die, parm_pack); - add_src_coords_attributes (parm_pack_die, parm_pack); + add_name_and_src_coords_attributes (parm_pack_die, parm_pack); for (arg = pack_arg; arg; arg = DECL_CHAIN (arg)) {