From patchwork Fri Feb 5 11:46:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Majewski X-Patchwork-Id: 41948 X-Patchwork-Delegate: azanella@linux.vnet.ibm.com Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB9B13850405; Fri, 5 Feb 2021 11:47:13 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id 14C533857C7E for ; Fri, 5 Feb 2021 11:47:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 14C533857C7E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DXDDF6NJTz1s2JF; Fri, 5 Feb 2021 12:47:09 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DXDDF53fFz1tYTq; Fri, 5 Feb 2021 12:47:09 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id NzOxuGWdB81H; Fri, 5 Feb 2021 12:47:07 +0100 (CET) X-Auth-Info: t8cVKUx3RFpsJjCCLpHEqYvESuTEa4jnRqe5fg3vzig= Received: from localhost.localdomain (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 5 Feb 2021 12:47:07 +0100 (CET) From: Lukasz Majewski To: Joseph Myers , Adhemerval Zanella , Florian Weimer Subject: [PATCH v4] tst: Provide test for ctime Date: Fri, 5 Feb 2021 12:46:51 +0100 Message-Id: <20210205114651.18228-1-lukma@denx.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Spam-Status: No, score=-15.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: GNU C Library , Florian Weimer , Alistair Francis Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" This change adds new test to assess ctime's functionality. To be more specific - following use cases are checked: - Pass time_t value as 0 to check if epoch time is converted - Pass time_t as max value for 32 bit systems - Pass time_t as the first value after Y2038 threshold Reviewed-by: Adhemerval Zanella --- Changes for v2: - Add setting of TZ env variable Changes for v3: - Remove FAIL_UNSUPPORTED() when sizeof (time_t) <= 4 - Use "TZ=:" glibc extension to guarantee UTC time zone Changes for v4: - Use __builtin_add_overflow instead of sizeof (time_t) > 4 to check if time_t has overflowed. --- time/Makefile | 2 +- time/tst-ctime.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 57 insertions(+), 1 deletion(-) create mode 100644 time/tst-ctime.c diff --git a/time/Makefile b/time/Makefile index 43e5821adc..486fb02ecb 100644 --- a/time/Makefile +++ b/time/Makefile @@ -51,7 +51,7 @@ tests := test_time clocktest tst-posixtz tst-strptime tst_wcsftime \ tst-clock tst-clock2 tst-clock_nanosleep tst-cpuclock1 \ tst-adjtime tst-clock-y2038 tst-clock2-y2038 \ tst-cpuclock1-y2038 tst-clock_nanosleep-y2038 tst-clock_settime \ - tst-clock_adjtime + tst-clock_adjtime tst-ctime include ../Rules diff --git a/time/tst-ctime.c b/time/tst-ctime.c new file mode 100644 index 0000000000..e89a906bf8 --- /dev/null +++ b/time/tst-ctime.c @@ -0,0 +1,56 @@ +/* Test for ctime + Copyright (C) 2021 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include + +static int +do_test (void) +{ + char *str; + time_t t; + + /* Use glibc time zone extension "TZ=:" to to guarantee that UTC + without leap seconds is used for the test. */ + TEST_VERIFY_EXIT (setenv ("TZ", ":", 1) == 0); + tzset (); + + /* Check if the epoch time can be converted. */ + t = 0; + str = ctime (&t); + TEST_COMPARE_STRING (str, "Thu Jan 1 00:00:00 1970\n"); + + /* Check if the max time value for 32 bit time_t can be converted. */ + t = 0x7fffffff; + str = ctime (&t); + TEST_COMPARE_STRING (str, "Tue Jan 19 03:14:07 2038\n"); + + /* Check if we run on port with 32 bit time_t size */ + time_t tov; + if (__builtin_add_overflow (t, 1, &tov)) + return 0; + + /* Check if the time is converted after 32 bit time_t overflow. */ + str = ctime (&tov); + TEST_COMPARE_STRING (str, "Tue Jan 19 03:14:08 2038\n"); + + return 0; +} + +#include