From patchwork Tue Jan 10 15:10:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ed Catmur X-Patchwork-Id: 62895 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6971C383234A for ; Tue, 10 Jan 2023 15:11:47 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by sourceware.org (Postfix) with ESMTPS id 1F849385B514 for ; Tue, 10 Jan 2023 15:11:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F849385B514 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=catmur.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=catmur.uk Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 22953320095D for ; Tue, 10 Jan 2023 10:11:27 -0500 (EST) Received: from imap48 ([10.202.2.98]) by compute5.internal (MEProxy); Tue, 10 Jan 2023 10:11:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catmur.uk; h=cc :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t= 1673363486; x=1673449886; bh=MZtaGZZ6TYeI9+9E2rhwSPiJElminhCHxkA mSaUMBG8=; b=KFTToHLdMUp64DFsAV08jTqSdvUoM9wrmqAQH/JvoTliwjqLicT l84c5rDIc19fw99zCG4ANUpIifL1QpEWtXZl2aekkgXxPHNv4MeFg4SN9gtwmFes ZgUHrOyFqtGt0Iq/TFjkWJbQaztv0rrOuuvWsOhKPf0aMYgVasPub7vL1lgyzJBQ SQyfbADUnmr9PQ41FAu2kW4AVPg5TObc9LpGzFa7PmRuzDeg6Qf0mWoquqLJToWH ZY/wD4Zh74Vu4RyXg7e3iMgWIK9Lf4vvyN66SNGFGoWFwZihgZT15pz+BRr7pFHH oJYAkWn7/gaA3oQjBPeOLACTnEe+9dRsc9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673363486; x= 1673449886; bh=MZtaGZZ6TYeI9+9E2rhwSPiJElminhCHxkAmSaUMBG8=; b=Y pXB8CRQ6KOI432ijNtd3o2MnS8/xg5urIibwsfVO7Bd6zzPKeQGP2b9KhnC4e7U1 lYUQffzMLFU6y+31Rr7ufts5D1AIX8WebHkRVXRV14LSfwjJeLGHGsUT5t1wZOFw EanwJeiSomkG15oLjG8olnRFSp9m5FDaBzWRAQQx+IiSzm7dJA8LWEjK/AnTjKvQ a+0IVVnLVbXRkYpG6HvorjUtc4lmyZCiGcCX0PkEgv9s2viaw2uJhdsqo3BkeRqO WNBeRLVZgY0R6sDzanJoaX3dpnTctS3lV+S7ZI0xh9c9ozWA7NbSvMchTBOxtNpJ 7gpwKAoyoT5DyASqXeipg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrledvgddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkfffhvffutgesmhdtreerre ertdenucfhrhhomhepfdfgugcuvegrthhmuhhrfdcuoegvugestggrthhmuhhrrdhukheq necuggftrfgrthhtvghrnhepueekffegjefhkeeiuedtleefgfelvdelledtgefgvdetje ekkeegffdvgfeutdehnecuffhomhgrihhnpegufigrrhhfshhtugdrohhrghdpghhnuhdr ohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gvugestggrthhmuhhrrdhukh X-ME-Proxy: Feedback-ID: i5729427b:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5474631A0063; Tue, 10 Jan 2023 10:11:26 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1185-g841157300a-fm-20221208.002-g84115730 Mime-Version: 1.0 Message-Id: <9823f46c-0378-44be-8300-8e6752938525@app.fastmail.com> Date: Tue, 10 Jan 2023 15:10:42 +0000 From: "Ed Catmur" To: gcc-patches@gcc.gnu.org Subject: [PATCH] gcc: emit DW_AT_name for DW_TAG_GNU_formal_parameter_pack [PR70536] X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Per http://wiki.dwarfstd.org/index.php?title=C%2B%2B0x:_Variadic_templates DW_TAG_GNU_formal_parameter_pack should have a DW_AT_name: 17$: DW_TAG_formal_parameter_pack DW_AT_name("args") 18$: DW_TAG_formal_parameter ! no DW_AT_name attribute DW_AT_type(reference to 13$) (...) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70536 From 2c50fbbfdd42c9ecb6d6b8e4c53bb3029ef1ee25 Mon Sep 17 00:00:00 2001 From: Ed Catmur Date: Sat, 12 Mar 2022 17:38:33 +0000 Subject: [PATCH] emit DW_AT_name for DW_TAG_GNU_formal_parameter_pack Per http://wiki.dwarfstd.org/index.php?title=C%2B%2B0x:_Variadic_templates DW_TAG_GNU_formal_parameter_pack should have a DW_AT_name: 17$: DW_TAG_formal_parameter_pack DW_AT_name("args") 18$: DW_TAG_formal_parameter ! no DW_AT_name attribute DW_AT_type(reference to 13$) (...) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70536 --- gcc/dwarf2out.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/dwarf2out.cc b/gcc/dwarf2out.cc index 5681b01749ad..ef3bc6f88e07 100644 --- a/gcc/dwarf2out.cc +++ b/gcc/dwarf2out.cc @@ -23006,7 +23006,7 @@ gen_formal_parameter_pack_die (tree parm_pack, && subr_die); parm_pack_die = new_die (DW_TAG_GNU_formal_parameter_pack, subr_die, parm_pack); - add_src_coords_attributes (parm_pack_die, parm_pack); + add_name_and_src_coords_attributes (parm_pack_die, parm_pack); for (arg = pack_arg; arg; arg = DECL_CHAIN (arg)) {