From patchwork Fri Jan 22 22:43:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stafford Horne X-Patchwork-Id: 41798 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 60729389851E; Fri, 22 Jan 2021 22:43:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 60729389851E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611355391; bh=8YMe7Up8Hu/pRtwzrkyF5KEzJcoJ40/o6HnP+N5EV1I=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=h4Cifh0AWyeTRtOXd9EZ31JInB6b0R+TuOgmsEskJ0lWPrM2+LmSwsqAQVsEhOt6v FgNNk0y3CIDSZ5jzNe6uqjxAECOGJ/QC2YakYcYqeHdMPJ6GMSgi4bjMT5+g/ui6Kc dZmOzXmDuG9k0hX5WR4YiPBNyxtpj+xD/n7AeOSE= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 5ED85386F41D for ; Fri, 22 Jan 2021 22:43:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5ED85386F41D Received: by mail-pl1-x62b.google.com with SMTP id r4so4094094pls.11 for ; Fri, 22 Jan 2021 14:43:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8YMe7Up8Hu/pRtwzrkyF5KEzJcoJ40/o6HnP+N5EV1I=; b=JYS5H6X3lwo71usZr9105E1bH7ezkEXvRkvxGiV7q5i317vQvvf02KTu0llaKt7Cl7 PjVy7UNGzX1YvMRUvKTnqEi5lu2qTPoPRHWcXOZ6HaxWsk8U4v1/LJjI7YJbmbgjSOZW WXPZp26OznXGocoH3eJhLcAkMjiwAyW/RK90hx1NHEdbmiTYuqteQv+90qRz4n6qp/7x Om8ZPzvjrV3hoCYo+38SXEbCWZEOHoxz0YiPQtRaoCIAFQTgr3l5hGMSyt/12f0w/QX9 5ImUjSEH4qnlKrcDgc3Yxp06LBJ60DfyCrqQ49iznxdp/rGkHdjRDsaj65aTvIHe7Nwn h7JQ== X-Gm-Message-State: AOAM533FC5fJ4g0WZiHRWpCqcmz08MsZlYDHTWtmBu1n9k8ekpDGLfWw Wk6KozVa3Ok+DTXxBM5gy9fV1oLaXSU= X-Google-Smtp-Source: ABdhPJwJDI7BVPOSUCW08ZBQQRNGILBFHuw1EIyzIcT7oxQW53QkPRrPWtRzph8xjS1f35GtkNyK9Q== X-Received: by 2002:a17:902:8203:b029:dc:3371:6b04 with SMTP id x3-20020a1709028203b02900dc33716b04mr6768310pln.81.1611355387060; Fri, 22 Jan 2021 14:43:07 -0800 (PST) Received: from localhost (g238.115-65-210.ppp.wakwak.ne.jp. [115.65.210.238]) by smtp.gmail.com with ESMTPSA id v9sm6800323pfm.80.2021.01.22.14.43.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 14:43:06 -0800 (PST) To: GLIBC patches Subject: [PATCH] posix/tst-rfc3484: Fix compile failure linking to local __stat64 Date: Sat, 23 Jan 2021 07:43:02 +0900 Message-Id: <20210122224302.3166767-1-shorne@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Stafford Horne via Libc-alpha From: Stafford Horne Reply-To: Stafford Horne Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" After 04986243d1 ("Remove internal usage of extensible stat functions") linking the __stat64 symbol in getaddrinfo for this test fails with the below error: /home/shorne/work/gnu-toolchain/local/lib/gcc/or1k-smh-linux-gnu/11.0.0/../../../../or1k-smh-linux-gnu/bin/ld: /home/shorne/work/gnu-toolchain/build-glibc/posix/tst-rfc3484.o: in function `gaiconf_reload': /home/shorne/work/gnu-toolchain/glibc/posix/../sysdeps/posix/getaddrinfo.c:2136: undefined reference to `__stat64' collect2: error: ld returned 1 exit status This is because __stat64 is a local symbol, the test includes the getaddrinfo directly and fails to link against the local symbol. Fix this by setting up an alias to the global stat64 symbol name list is done for other local symbol usage. --- posix/tst-rfc3484.c | 1 + 1 file changed, 1 insertion(+) diff --git a/posix/tst-rfc3484.c b/posix/tst-rfc3484.c index 97d065b6bf..3b2052eb54 100644 --- a/posix/tst-rfc3484.c +++ b/posix/tst-rfc3484.c @@ -11,6 +11,7 @@ #define __gethostbyaddr_r gethostbyaddr_r #define __gethostbyname2_r gethostbyname2_r #define __qsort_r qsort_r +#define __stat64 stat64 void attribute_hidden