From patchwork Thu Dec 8 11:52:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Vrany X-Patchwork-Id: 61695 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 468883832E57 for ; Thu, 8 Dec 2022 11:53:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 468883832E57 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670500398; bh=gzqpgq1LHLcZzPE/JxmurjVjBpvwfCMHhfXiSa4qbWo=; h=To:CC:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=vrQTTTNXW/+DHLAwopfE8dzWBf4oWnRN4VTZ5i2e0ZVn6/al+6QlZJjjH77k9GPpM RqRJ4k2FEtxGDom/NYQUJt424+zA0Ls5kv8Bzr1xq5kIYZxuwXOB3DH0Lkd8xTzMIQ L2qDoPn/kw2sx4G1aGk0/ibQoOtwWaNUfyAsJOXk= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-114.mimecast.com (us-smtp-delivery-114.mimecast.com [170.10.129.114]) by sourceware.org (Postfix) with ESMTPS id 5476B38446A7 for ; Thu, 8 Dec 2022 11:52:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5476B38446A7 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2105.outbound.protection.outlook.com [104.47.55.105]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-17-Ddu9ylv-OPqOXqrbafhWEg-1; Thu, 08 Dec 2022 06:52:49 -0500 X-MC-Unique: Ddu9ylv-OPqOXqrbafhWEg-1 Received: from DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) by BY3PR17MB5218.namprd17.prod.outlook.com (2603:10b6:a03:3b7::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.11; Thu, 8 Dec 2022 11:52:45 +0000 Received: from DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::9df4:7ed9:aca6:322e]) by DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::9df4:7ed9:aca6:322e%4]) with mapi id 15.20.5880.016; Thu, 8 Dec 2022 11:52:45 +0000 To: gdb-patches@sourceware.org CC: Jan Vrany , Simon Marchi Subject: [pushed] gdb: skip objfiles with no BFD in DWARF unwinder Date: Thu, 8 Dec 2022 11:52:08 +0000 Message-ID: <20221208115208.636457-1-jan.vrany@labware.com> X-Mailer: git-send-email 2.35.1 X-ClientProxiedBy: LO4P123CA0500.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::19) To DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR17MB3113:EE_|BY3PR17MB5218:EE_ X-MS-Office365-Filtering-Correlation-Id: b6b48da3-ba1c-44a4-5b75-08dad912b845 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: ltbcWO+srcH+EA+cn3TaLa4kmPZraTCo2uiOyqsngSapbqjzpEGnr5ttRKpwgKtfW4kgFHtgLMwYBobeGGimoaJz07STMr7rifnuQZT0mBnjGNhoW5ReiYj+EdW7IgHsuKwRADFrPfj6QokkRLuHwMwCvlC1qIgfn2ZjseQ+D91Q3RxMcMBnXzLy9aC6Vfaoo0fJ7zLdDJzgnhBdXi7RLHeQPbqJ9JCEn7L/I4RVw7sm9s0dbLL3RUTPIbzepr8eRsaxRHQTp896RJsT5UCGP+FSg7GxY4CWuVrMqd5RUw/IKB2odkOBv4pGFRkD+Qa9uWHLS7rSL1pNmcH7w7tNCpbNAhh0az4pF4qPyeMVNxsIy6gOksUpU7A7VWGChggELX8wPYRLNbVKCiEmQxxrnPqZCaj5+EDb4yXgjvkESDOBfmYN5xi46kY750MOI+9mpMFyHhESekao/kg3tqppUhMZAKiEbgwrTQtwimLJVpq+dbbB7Mn9iXsNMrqmNdFU0tixyWL0162G/93r173oFzlDqdLIeDml/rSo44t2FA8Q+xEAr9gpfMCsUL5Shea4IGgwQxWKJF+FHfXwgy9+0WShcbOYzmKUBI6rRlnLNoIFN4rze8Rr0mXurAR/OMiWxL61cc17qATcPEdsKEG/gmFXkwXMlo7Ri8BGOmItKt+NcNKJodIuSltgBrguWSjRhqeiAc4rB0vYvoxOuaFYMg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR17MB3113.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(376002)(39850400004)(396003)(346002)(366004)(451199015)(36756003)(86362001)(6506007)(478600001)(6486002)(52116002)(8676002)(26005)(8936002)(44832011)(41300700001)(6666004)(54906003)(316002)(6916009)(2906002)(4326008)(5660300002)(66476007)(66946007)(66556008)(6512007)(186003)(38100700002)(2616005)(1076003)(38350700002)(83380400001); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: lUN56hCLX46kYCMGaoakCfscaM4IIZbYY02rCgvlNaA+P2Jh7J62ugDABXliCmvd8rQKsaMYjQZA9p/iAcTYR7mXI7xF3gahmlT4xd6vvbCveMbpvta7bHxuWDP3L2t+hhrNjS1jD38kPx5NEF1fB8AuBh4G298I4FjHe7a6Qa1PzUCyYGmoXb3hWFuutalAmj5XLxMepjvV9z8xGs+V5+jBhFR8+waXJbI0bHTbJnUKE8oio2JgmND4fEb4r+aLjvbkihrEht/zQEiVi5lMID+NBjhotDR1RZ/m8RCkz1wmAiMMCCQWmJ95eJQDLNUIjX0FTXmyoeJZph8QHz59lkCJzV1xKomuWah4qvgAOyuLmcEbK8c8TBcEhhmOG/o46rjN/iHLmmJgWfJtKvZPl6VZZ/1UlYAyPamV6h76QUpxCRhF/gOvJ1WqqXeyf0fQhVPMfFIaMTTq4X4nTyWK8ztlmUTYQd0XYV56NpnbcPTYohPkrGfvLgoOH1+cryxST1tCCjytZHurAo8ZzL/FMyKI44801CtXQT9JIaovJljlwzIZ9vKLQHZWTJeWDiEEofIvHUk9KABftQus9m4NiC+sG4RzPhtRvQH3R32qldDi7UNyx/uChnPpJxw7dhQyWrLiL9Iz9vPnzXYGsjkcn+0eGtA4E4JEfMKYRqzJFuekhP2ePr9OuUIjtooysYCqUN0UvSVtz6fseTzbVXsOYfGYWo6qScaf90df+E0YnAX9SYlR9K5kCxw7HH0DQ1eELirfP/t1UxmK82JFn7rM5LQPgoa3ttfEJA1g63OcA7v6HZiXiZ4NdUOkt+jv7eGyy2WyOt54fmWwl3yS6MRn3P8bXbGO5b4wKg9SkJyyscAh0yo3jjYzFg1Y2YLsynGOWIT3K1pEucixml/Cc2NDDwx5kSwPwuGELjm4xhCVdai0gFlGaHzWQkWU8ie08Y7qmYgagtZ5ND1PmImSY/wfTDrEx2achJUgBrjNvZtB+mfXjSADg17r+dcsU/3AQaWL7Tq3etNSb4h7zVACyGFEFMjn/cdqWj6E72ZeXuNosED7eNM3M/rA2bDVAdaPoOj0lPch+Tkd1U6/HwWH2uaT/jNiKYQOSd4tDJRuQY44osLmStNKgpxaUStftqgsygRgIhynpsUwl888K4mJO1/ChmFfSXZCYz0pCU/BBVotFkNYXQUyb6G0y3GuhH2zhRaRzyW3HJ6r8D+mpYWdJfQVjLoGKV9sznCoABbbBScGvm1KNOZfEhrUFK3PGfHctRqRSM2poPhy47wavQArLA4T86XXU+VJdlH10xJtHBsfIzjffmVx+9mZOdbMXaNd7otdbsypiX/7Z6M5+3YhFQgZGb5xLXb+qq4N+Xd9EAtDG9fXGIGoPCLsg/4pvsc8r6JzR3nOx0SQU1NVsEX0Zus4iXQtBU9iec8LURJMYVLgsfqU/dooSNPm9A5VBG/ynTEPdUz6svg3AMEwLGtbqrDbQWbeJ/lYtVWNJletVZ6cR7L+dPaL7L6z0cTUlVsKNoPN/4ggYHlPkHrDak4itjzu95iCdn0H8MreAS+0ngBa7Cmemcq9upaXtP1BAbuaKVlK X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6b48da3-ba1c-44a4-5b75-08dad912b845 X-MS-Exchange-CrossTenant-AuthSource: DM6PR17MB3113.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 11:52:45.1944 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wJD9jTrH9MDuhjNhBZgs57rWFHoZKgEBXy4/KtqtxpnPKUZyAXo/YCimvqzqpBWxUJDdVJsUgDzM1zUAPjiEXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR17MB5218 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: labware.com X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Vrany via Gdb-patches From: Jan Vrany Reply-To: Jan Vrany Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" While playing with JIT reader I experienced GDB to crash on null-pointer dereference when stepping through non-jitted code. The problem was that dwarf2_frame_find_fde () assumed that all objfiles have BFD but that's not always true. To address this problem, this commit skips such objfiles. To test the fix we put breakpoint in jit_function_add (). The JIT reader does not know how unwind this function so unwinding eventually falls back to DWARF unwinder which in turn iterates over objfiles. Since the the code is jitted, it is guaranteed it would eventually process JIT objfile. Approved-By: Simon Marchi --- gdb/dwarf2/frame.c | 3 +++ gdb/objfiles.h | 4 +++- gdb/testsuite/gdb.base/jit-reader.exp | 13 +++++++++++++ 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/gdb/dwarf2/frame.c b/gdb/dwarf2/frame.c index 3f884abe1d5..54a0912ebc6 100644 --- a/gdb/dwarf2/frame.c +++ b/gdb/dwarf2/frame.c @@ -1560,6 +1560,9 @@ dwarf2_frame_find_fde (CORE_ADDR *pc, dwarf2_per_objfile **out_per_objfile) CORE_ADDR offset; CORE_ADDR seek_pc; + if (objfile->obfd == nullptr) + continue; + comp_unit *unit = find_comp_unit (objfile); if (unit == NULL) { diff --git a/gdb/objfiles.h b/gdb/objfiles.h index 9a152cbc387..0d887ce112f 100644 --- a/gdb/objfiles.h +++ b/gdb/objfiles.h @@ -646,7 +646,9 @@ struct objfile struct compunit_symtab *compunit_symtabs = nullptr; /* The object file's BFD. Can be null if the objfile contains only - minimal symbols, e.g. the run time common symbols for SunOS4. */ + minimal symbols (e.g. the run time common symbols for SunOS4) or + if the objfile is a dynamic objfile (e.g. created by JIT reader + API). */ gdb_bfd_ref_ptr obfd; diff --git a/gdb/testsuite/gdb.base/jit-reader.exp b/gdb/testsuite/gdb.base/jit-reader.exp index 69bf721d90a..a66896dda67 100644 --- a/gdb/testsuite/gdb.base/jit-reader.exp +++ b/gdb/testsuite/gdb.base/jit-reader.exp @@ -277,6 +277,19 @@ proc jit_reader_test {} { "True" \ "at least one file-based objfile" } + + with_test_prefix "test dwarf unwinder" { + # Check that the DWARF unwinder does not crash in presence of + # JIT objfiles. + gdb_test "up" + gdb_breakpoint "*function_add" temporary + gdb_test "cont" ".*Temporary breakpoint ${any} in jit_function_add .*" + gdb_test "bt" \ + [multi_line \ + "#0 ${any} in jit_function_add ${any}" \ + "#1 ${any} in main ${any}" \ + ] + } } jit_reader_test