From patchwork Wed Dec 7 13:06:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enze Li X-Patchwork-Id: 61659 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CF440383557D for ; Wed, 7 Dec 2022 13:07:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CF440383557D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670418474; bh=4yPU0RaZoLd1hJT3ARwUbBpOZDoVc7buuH4oUcH8unk=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=qyOuuJXROjnBUBsfxmJNrVcpZg3CYKjBCWfR1sO6myhyKsPxsLet8S+yEYH0yKw1e BcUxBeJaKxLM3I4s/Yt7+DqYo9FNYnxg50xWiT6n5d2sx2k0sB+ZerX6O1dylMUD/W ZOwJALqn43OtjPQcD5E6JXTsoabf4PuKYby5t/bc= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2070.outbound.protection.outlook.com [40.92.98.70]) by sourceware.org (Postfix) with ESMTPS id D4406383A0EB for ; Wed, 7 Dec 2022 13:07:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D4406383A0EB ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E2HHF71nhoPP1fshL3JDJ7/Se8MnjG7wR1mAcLHbCWHw5MAKQT+MUTcBIzBSCPAhkGCm2zwRnYhbtrYFIzA8FcanE3p6/oeYaOQZcG9Tloww/0pWkOdc1icH1IedDw6d8BgnyNp9zr3yXJWpyVdDJDV4TGK2t2rwe3QPwXIOwVWcpRJFzz2aDk0sJIWrr+1VlVFlo9e6PyoOzctZ34I2W9fMzhzUXwPRX9cu8o7Zb3qofZ2IfbrUC2Fkl0fkUyAcU1kuc536Hi5fwlFF2l1hNapaPW59uyu8ECUggXAjxTVIF0O+wweFMJNekWcD9ixaNqqc0pR3qNHZP8yxBePqoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4yPU0RaZoLd1hJT3ARwUbBpOZDoVc7buuH4oUcH8unk=; b=auePgbpDjppJLVuMUT5WDo/nHBPO8GmzTRsPQHKn4Z5Tlag8P2iKzYywMZ1dmuSE62OjE2YL5OiQkgw4iDbe+c1HAztOZGlbEDTerMdHikgGD51bQ/6T6y4VBWkaRbkNHNhT4Jj7jkAsWHzTt6TUs4gfOx1iNzvSB8B4OV+WgdL6Z9faUx6/M8X11TPBEVrxYqRyTiFaRQPx6mNHq81Ra7uCnn4X96IZVNMmUB/aDg3LjlQ3xztINGhGJH5xasz4SeAbAz1HNdyem5vvZj8Kz6YL1ZGjViC0dsXfAQgE3LKzOK2IhCHzjdaG5A6TgD4xdoftuhvPKprUbVAoZJftXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYCP286MB2290.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:151::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 13:07:26 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::c90:199b:e178:3fa4]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::c90:199b:e178:3fa4%6]) with mapi id 15.20.5880.014; Wed, 7 Dec 2022 13:07:25 +0000 To: gdb-patches@sourceware.org Cc: enze.li@gmx.com Subject: [PATCH] gdb/testsuite: update a pattern in gdb_file_cmd Date: Wed, 7 Dec 2022 21:06:09 +0800 Message-ID: X-Mailer: git-send-email 2.30.2 X-TMN: [phgF4tVk38x+D5Xw7iyrBm09jH0YEldE] X-ClientProxiedBy: SGAP274CA0009.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::21) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <20221207130609.89225-1-enze.li@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3P286MB2152:EE_|TYCP286MB2290:EE_ X-MS-Office365-Filtering-Correlation-Id: b7c7074c-6157-4647-10bc-08dad853fc70 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lVhGULnCjdoDXC6UyULXF4WOlz/KDw/eZWZkC1T0wLWDy/sQUj/4/UGGSlVaJ3WaSg4biN4QzFKyTcCyGzVctwoKaQm8Fp025OLrfbGGvs8t2ND4hBcoaqGKL8jf+Sa8h8iCzGJ2p+flCoNPM5/x0zG2/wz0xC5NBVMLW8WNNU0c1rgzOqr335x3O2JYYpmzKbWzEdpltaKE4RKbnPMaiZr8MD1eU3p5smKCYaYQaokO/LFN7958+oMdlCbUK+mTl3ugttlsyO+7eeSQqhRRIftQi5JRm/o3MKwJlnR34rFqCCVC4MYHVnheKNxLY3lJX762av2Qqaad7hv0GTZ88C/XkThnrrPGS8QYA9QdNJ72YmroJemnb6uvYuMCc+jOCY+3R0mnEpPzEg2W9H17TKWY1okTvjmXDC15ifpUci+tUlwwy/ocQddMoGn91jjTInDNQMeD1EXue77cvHpAylR5dvwex+GthUeJuU9Jtw1/CiMfoHJQRaVbMqiW/nkPS9MC9ndiuOVE75Tv4Y91nT7hfmX6AF3Sh2UaOJmNp4epOiUVtC+Z+kYqEZsfkom8f5ttYLv27shZEuTHsf8bRQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TCUWb/07YzFXqd/7rEh3DJuRLGbHcX1zglzOkmdAWbHnep4/j4kUKLqRSBa0zge14PTqy9K76cXwTN9eYUnwoXXnejCBOMLUuBt3+9TtfdlkGKLzqHWAXMlG6KlR5qd5rchSwQY4be3GoVEjT8SLJhefeKds0tRCVzBNSwZkjletQ83Lo5qy8qJDCqN9mwQ3Js/dBy/XNv/mSr2xP4je4ueC6de5DWtEdxR1tGrypsnJvBPn6JahlGulBeXGdQ/z1jVKd1ATE7iY+wrminA58L3xL0XuhCpK9T/BpEs9uhp8T+hrbQdGfrUFjVXUIG9ZFc2WiXSeiZ26pYrZramx3t97XoZiQyAT709w9COTj9iE578E2gpkpejqg2PuIZt6mmyc4nTrfzNu15bC5XU0HBubqya9QTE8Dlg71TP6dfiDuvsqsoPZsfgLbJhpW+mUumyy0zJVDVoXguUWmFiw0Ew5/lKxLsOybfkD22M4nHvb9txmYWbrhzFMt2NXXhk/rPRVf6A2VtdFUXy9E7fmPBByfaF9nYEuE33xSu7BFdUFzlWC/gYGtaE221n5+QaWZnVOyxnQDmIMEe4bYby6eyVs90FN2xGkvgUQ0mPdx9RTPP3qmhy3SXE+xui5ldvzkopZX5GkyuDMhLA0vscFFzzmFfPxy/JsG4NDg6P8snAInRyv8yb4xS9vKP3d3P0N824kEQniQI0/LLHlmWUxTdHIWTu9a678U5nxN4zCRB7s6Bcz3kaX2Y3bTC0IH6IBqLGZQ9PKoVjJf710h193SUI13g7jU3qIl/SQrGRayWK3fJAXd0fOLJ+LZvQVQhcqNDodGkzVvsoreYy/sB99QMlT2AHfBdeFyEx+S5MsOGgW/gY1DHEXWq7owVuQ7XJL08xylD0yOyBiA1zXr/TY2HsvUHba3D8I7vmU87AITMW8ZCtUfoP1pFLXdMJrT6Sf4v8GwJiK3Oa9hiyJjD1VuXeffxs/wOSSK6C4fwwztlmf3W7Hr6VpL5yRPwyrQe3fca6FbKwN7yV/Gzrr7T36bn05QiSAJW3wF6kF1uLsSwnXqWMGpeT146DOpi4urt5ugDEJuqhpyZAZuTeN9PFi6/XRLp1cDnTA4E2xZBGy/0UeKQaAfsW74LWASI2Fe6Lky+CWnCVJBMBaNc5tV8ZvhhKX7rncXhmXl6NrUIamPDelkkJpXYhmaIMXL3Rn3p4uis73NUc+3BAoXhv7k3lt2CcS+nGhGD/BsrTV0R8d/3QnzkUq3Ht5a3hJzhGQxP5mMBcc3DOKWP3skhZ+q8emDg== X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: b7c7074c-6157-4647-10bc-08dad853fc70 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 13:07:25.9496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB2290 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Enze Li via Gdb-patches From: Enze Li Reply-To: Enze Li Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" When building GDB with the following CFLAGS and CXXFLAGS as part of configure line: CFLAGS=-std=gnu11 CXXFLAGS=-std=gnu++11 Then run the selftest.exp, I see: ====== Running /home/lee/dev/binutils-gdb/gdb/testsuite/gdb.gdb/selftest.exp ... FAIL: gdb.gdb/selftest.exp: run until breakpoint at captured_main WARNING: Couldn't test self === gdb Summary === # of unexpected failures 1 /home/lee/dev/binutils-gdb/gdb/gdb version 13.0.50.20221206-git -nw -nx -iex "set height 0" -iex "set width 0" -data-directory /home/lee/dev/binutils-gdb/gdb/testsuite/../data-directory ====== It is the fact that when I use the previously mentioned CFLAGS and CXXFLAGS as part of the configuration line, the default value (-O2 -g) is overridden, then GDB has no debug information. When there's no debug information, GDB should not run the testcase in selftest.exp. The root cause of this FAIL is that the $gdb_file_cmd_debug_info didn't get the right value ("nodebug") during the gdb_file_cmd procedure. That's because in this commit, commit 3453e7e409f44a79ac6695589836edb8a49bfb08 Date: Sat May 19 11:25:20 2018 -0600 Clean up "Reading symbols" output It changed "no debugging..." to "No debugging..." which causes the above problem. This patch only updates the corresponding pattern to fix this issue. With this patch applied, I see: ====== Running /home/lee/dev/binutils-gdb/gdb/testsuite/gdb.gdb/selftest.exp ... === gdb Summary === # of untested testcases 1 /home/lee/dev/binutils-gdb/gdb/gdb version 13.0.50.20221206-git -nw -nx -iex "set height 0" -iex "set width 0" -data-directory /home/lee/dev/binutils-gdb/gdb/testsuite/../data-directory ====== Tested on x86_64-linux. --- gdb/testsuite/lib/gdb.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 83f18e5ebe627163f744215d3760a8eaacee6ec1 diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index e4ce3c30c2ff..008f59b9f30b 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2139,7 +2139,7 @@ proc gdb_file_cmd { arg } { set gdb_file_cmd_debug_info "lzma" return 0 } - -re "(Reading symbols from.*no debugging symbols found.*$gdb_prompt $)" { + -re "(Reading symbols from.*No debugging symbols found.*$gdb_prompt $)" { verbose "\t\tLoaded $arg into $GDB with no debugging symbols" set gdb_file_cmd_msg $expect_out(1,string) set gdb_file_cmd_debug_info "nodebug"