From patchwork Thu Dec 1 18:28:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 61328 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8BA5A3858C3A for ; Thu, 1 Dec 2022 18:29:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8BA5A3858C3A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669919371; bh=+gawPm2oc1uC6tu6ZdMHfOLRHzuWtgyAvORdN/Tfh7g=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=efVF7JbHeXUHEmSasYV5MAwq+9Y6ko40CZpvyqJVI/nrT8WNbWMW84/M2ajMHKWOE RvEwxNjWLRoFQUX6x9pV/wCCr6W6qGEHa6vdws/1KGeaWhOIuO3TpNGEA91eJ+cztR ahWd4aKFBTKwyofDkxlp0aRJf1i7bHYlCuvjdFHA= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id 011363858D35 for ; Thu, 1 Dec 2022 18:29:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 011363858D35 Received: by mail-il1-x133.google.com with SMTP id x12so1118773ilg.1 for ; Thu, 01 Dec 2022 10:29:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+gawPm2oc1uC6tu6ZdMHfOLRHzuWtgyAvORdN/Tfh7g=; b=rqHPxhvoLdky73JsT//S9XIq35zvSPmnMD2Pd+5fddK268cIYb1XZOCIH9HpJZe6+/ 3WQvkPP+hWPo38/4RgstaM7m4WsJQZLhjskepx98kLq4zWef6QAH0H/IaYXVlrwLBf3h rveDs8Jkw5DPm3rGs/1zmyapxJdDM0gApnb20z2WI0di2+UoDHvDwzwUDu411YcQppUt pVCfxuFwXuBIbNX8LF/L0/kjjCx03SQwweXU0V77D7BzEWn7bPxcuXU0FXhwalITft7e m9Fh5rcrfMbDgqnzSDWRCpgRLv0FuNNxRVzRkDF6AYT0KEeLIiz0mjKq5Gw/5DEtZCaV Gz5Q== X-Gm-Message-State: ANoB5pnAc1S2DCqqNEbEVn4KpPTTX+XF1dTychakPkb+7XzU1Bfh1lzW TSrMXFDng4V7dZfk7TEjALPB4NPy0B0xqA== X-Google-Smtp-Source: AA0mqf6YpjBysiAc/E1CJ1hjb6OlapHdserhSS1Wc32u/AHEuzzbgGD1zTFUhLgcxfuMEo2l+MVhcg== X-Received: by 2002:a92:d9d2:0:b0:302:d8e4:2319 with SMTP id n18-20020a92d9d2000000b00302d8e42319mr20300216ilq.225.1669919347265; Thu, 01 Dec 2022 10:29:07 -0800 (PST) Received: from localhost.localdomain (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id i15-20020a056e021d0f00b00302b7bec907sm1731577ila.41.2022.12.01.10.29.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 10:29:06 -0800 (PST) To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Remove call to registers_changed from windows-nat.c Date: Thu, 1 Dec 2022 11:28:57 -0700 Message-Id: <20221201182857.2591740-1-tromey@adacore.com> X-Mailer: git-send-email 2.34.3 MIME-Version: 1.0 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" I noticed that windows_nat_target::interrupt calls registers_changed. However, I don't think there's any reason to do this, because this will happen automatically when the inferior stop is processed. --- gdb/windows-nat.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index 17422e15f80..4b0760c5804 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -2881,7 +2881,6 @@ windows_nat_target::interrupt () DEBUG_EVENTS ("GenerateConsoleCtrlEvent (CTRLC_EVENT, 0)"); CHECK (GenerateConsoleCtrlEvent (CTRL_C_EVENT, windows_process.current_event.dwProcessId)); - registers_changed (); /* refresh register state */ } /* Helper for windows_xfer_partial that handles memory transfers.