From patchwork Mon Nov 28 19:12:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Domani X-Patchwork-Id: 61189 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 276D03852C44 for ; Mon, 28 Nov 2022 19:11:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 276D03852C44 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669662670; bh=hhkkadsUeOadPm2Ftc9bApkCFZUNDoREJ9zqNrrXu+M=; h=To:Subject:Date:References:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=nHRc2kV80Fs/Omvh93Ar5+MOi2VCtN0JhHV7lqPJ8ki7jlFUbNkrWDYwwIcmvKXnF mIBT/9VC1k4imKaDFDWCEAF9ZIJfnfIJRW6WowF8Ay37wf2jzftaZrieWSPE7KfuOE uVOyq3lPYIjCgrawjkSiI8ZK2BX7bXh7iHwexp1g= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from sonic302-21.consmr.mail.ir2.yahoo.com (sonic302-21.consmr.mail.ir2.yahoo.com [87.248.110.84]) by sourceware.org (Postfix) with ESMTPS id 938573858C62 for ; Mon, 28 Nov 2022 19:10:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 938573858C62 X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1669662645; bh=XA8LTLny7E8IefZUA3eI9qaiF3YihTypTB1qJzLXDiH=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=dBwmpuMCRalPMnQS9twi+50IByLZzxjKiOZm5b/+RPVWllCHKoQb9GZCBUvDijmnAy2UKvPCdHq9IQwF0GV1XnbRKsMQhj54i8Vl/GhRCafgvnTraWDTya7PHySGWPUgkNuICes7Od9/GrOZej4/mnUccOjS9WBasgDCHtzPohJrAljhpNbjX9A+6DsyyxHfxKWbXyt4JWJYKyR9FMbTjwW6FdNju7UxhzW/DXV/z9KvHN15bsbREdtbME7hdYYnIpdl3Z4FFFQhP8Lh7UzWYBgbIyHMgp96wIKxPRwsdrudL8pnffTbF31FspsfrO0UJMwlSpUDEpPAGC37eHdhnw== X-YMail-OSG: 4cz2L_kVM1miFJqRShn42KuJ1NZ1Ret6N4dEskI4QfyX7tMpXbzElMQrPdthgsj OTBwmWfN8hmwGDpilNwJzAQXJu86h.SAr9ZXxeLN0IkzOm2GpqdqWUKC3jhyXkZH8lOplOc3uJVt mTxMBItvjVyAdmAtSMH96Aj.iMbyC4jP5hLyzNU8bHWtbBHQ7MUaf8WeJqqTaILIGZiC6auRZWdv m7DKfQqde2qAVXiixtkaXopFOhvZHiffz.EiT5DRxs_zktOT3SqKjt8wj7jvOudC_3h67R7bnLzB 7UQ68T6Le3cx8ICKp9ctXGc4cstTcGNGpx4Om2BdNStRYVP5SUOnWfPimSVClMWCUvy_pnClOOvZ u2x23p.q.pZRB8znUffw5GmTBMt5LLMFsP_5wGN_gSG97MOTBFpG2ROF9KU..pbuW0VGwdKzxESF lHdayFfvkqJ5TuclDOiwfRUHHEsgxlfVlIeG2XDk_ScJ5Iv5O25bc9X.caGxnf0zefvC9lY2fQAl oxLGaDI2FfSvZ.ouyQdM9WO_4SmodERHYgU0Ehqn0pI7EYUgwj65AkYjh0BxIv5u_tINmoIfwS6f 9aOKlA8qmHR_MnCCdkN_ZCL23u_UyOaorUOAAmv2z1wO3ZhPCx61hbXYzUI2ieRnDT2PSiCIrUEB wErAzopln_DT3UThWypAntnscHmEThaw2AW..IeQZueSyRdCzmQMVYR.8bjZB6vRtIBJIxc6onEg RGgYCTxRPKg2005mAMDABQGCcbb63KPK8TTX5WCxACQuH9dKV4.gvNQjrkhPAleq6BFXyWdLYXv1 3ABzsYj.BcTOkUV2Lad0cvCSUOpL67o98_U2AtHB7EMB6Fv4LRAfI2yH2JHF43ezEHxxRJDF8UHl aSmpjIDj4e2nVExpyFXI_paWVbcFPMhRkcCjvdTDlplAQd664OY557aBviv1GdHhpOHubKjdyQ6B ifpRtweQLe_SVkFMKe7_doAQufvkoeA4HZVCZyp0.5uonP3Cpd_1vOToQQDqYyl9jj39KBbnMqYe MmSj4HZxOY3Fc74o69yBhL4rHAKTPxmPMsnZRt8cLB1D53sRQI.kLFjcTsbhtx.LGRFO77nzjLg2 N9_fjc_U8CCUnJRo2S4XFd2vciHF8HJcmuKBFfUgMNgEX2uv87mkP4oj5B.pcTsDmkPI4ckhmLru 1.NhIjPWfINbqgzl.p3mXeP9jXAox6yb1VtEZObwNOVrqUCvd.Uu4_60rt5rBKFyUeR6L1sc2_hh c_Dqr6v333ragqyKcL3OMb1_1yX18LSEKlxMxOA4MXDek7rbxH_46pjiz7BXdVpt3MEmMlWzy3_M oxVlT87SBoYUqacXGXzDp72Jw3GKPsncKos5fgABMIy94pMisYUiD3mKvAfUlsW0KctuxIlNwlWJ aHELwZ35EHdodT.O67.aTTXgiZwbAqikUZ3VXl8oAwgG9vpNc_RqpZhzIaBhkOug5Dq9PWzlOHgb xDYBn7cbgEiZ7_Z2tSUKMEb7g3YjU4agsx1ThLl5s7THFM5bP__t7cY2lf5AM3xMZ13JHGbYYpmL CakPOfdqSmRi70lM8bdhrAtfIRAn9Obxb02AJlFc2IYtXoR5UjLsHlgPOR7L1lV0E5HXNPJ8d27V Goyrw_KhPCak7vVR8qN6oIn8MgLNwUZTzYcfKzlFcT8NVD67PB9ftEaZq7gFuCqfa6ozClI1AxDH jd9VKmq2aoSHklNG35mJaTu8dngFiYgRV6H47Mlyh2ny3JqxEw2m2kIc9k90SW1y8IMAeLnzITKn vzYW4wpiOYsTBBgmdwOerXpE_XIo.s2IB2AgJyiAVZwqDLdYPiY5tH7VldjNipQHc6uHTZUUHaDx WUDlcyuen2CTkaVafmBpK.BqT7y8aPIyrUxuTl_Wu8BuN96Rf6IfQVfa68sQOn9sN5XijsoPaGUA UJ872mP16ImTE2cd1qsSG4KlwxpDK3ASseES1rvzLvF5GnzO9k0HhQhN80_u0Ry_k_ARI.hVeJt9 1xJr_nwahuWzhPqt36RRfDGz66dV4xfsYcnVCFl_A5mdJ6S7knzImEH2wsM9Eegg6HroKaIZ02FD hEAx9xD0gSrGmHHEnQ9vG0Y4TyryhECe85yXWc8CB5zTDz.qjNSdjVX7dO30FNrXJ1AtLOL_FADg 0q9Lnx6lnWjD_U2JJtqgSnv.7dpEWL5xe9KMVx1j59EjLvq3f0.K6t5Sn60WVGOfHJ6CT0xLHKuF wNRcEzj.h2w9WA06fbT5qhnRs6Q-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Mon, 28 Nov 2022 19:10:45 +0000 Received: by hermes--production-ir2-74cf6dc4df-hf6d4 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f7d2419a0d94437a4a81115c994e5e89; Mon, 28 Nov 2022 19:10:42 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH 1/4] Fix calling convention of thread entry point Date: Mon, 28 Nov 2022 20:12:21 +0100 Message-Id: <20221128191224.1411-1-ssbssa@yahoo.de> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Antivirus: Avast (VPS 221128-0, 11/28/2022), Outbound message X-Antivirus-Status: Clean References: <20221128191224.1411-1-ssbssa.ref@yahoo.de> X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Hannes Domani via Gdb-patches From: Hannes Domani Reply-To: Hannes Domani Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" For i686 the CreateThread entry point function needs the WINAPI (stdcall) calling convention: ../../gdb/windows-nat.c: In constructor 'windows_nat_target::windows_nat_target()': ../../gdb/windows-nat.c:450:56: error: invalid user-defined conversion from 'windows_nat_target::windows_nat_target()::' to 'LPTHREAD_START_ROUTINE' {aka 'long unsigned int (__attribute__((stdcall)) *)(void*)'} [-fpermissive] 450 | HANDLE bg_thread = CreateThread (nullptr, 64 * 1024, fn, this, 0, nullptr); | ^~ ../../gdb/windows-nat.c:444:13: note: candidate is: 'constexpr windows_nat_target::windows_nat_target()::::operator DWORD (*)(LPVOID)() const' (near match) 444 | auto fn = [] (LPVOID self) -> DWORD | ^ ../../gdb/windows-nat.c:444:13: note: no known conversion from 'DWORD (*)(LPVOID)' {aka 'long unsigned int (*)(void*)'} to 'LPTHREAD_START_ROUTINE' {aka 'long unsigned int (__attribute__((stdcall)) *)(void*)'} Since it's not possible to change the calling convention of a lambda, I've moved it to a separate function. --- gdb/windows-nat.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index 5d506507b6d..f61f6c1cb35 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -344,6 +344,9 @@ struct windows_nat_target final : public x86_nat_target BOOL windows_continue (DWORD continue_status, int id, int killed, bool last_call = false); + /* Helper function to start process_thread. */ + static DWORD WINAPI process_thread_starter (LPVOID self); + /* This function implements the background thread that starts inferiors and waits for events. */ void process_thread (); @@ -404,13 +407,8 @@ windows_nat_target::windows_nat_target () m_response_event (CreateEvent (nullptr, false, false, nullptr)), m_wait_event (make_serial_event ()) { - auto fn = [] (LPVOID self) -> DWORD - { - ((windows_nat_target *) self)->process_thread (); - return 0; - }; - - HANDLE bg_thread = CreateThread (nullptr, 64 * 1024, fn, this, 0, nullptr); + HANDLE bg_thread = CreateThread (nullptr, 64 * 1024, + process_thread_starter, this, 0, nullptr); CloseHandle (bg_thread); } @@ -453,6 +451,13 @@ wait_for_single (HANDLE handle, DWORD howlong) } } +DWORD WINAPI +windows_nat_target::process_thread_starter (LPVOID self) +{ + ((windows_nat_target *) self)->process_thread (); + return 0; +} + void windows_nat_target::process_thread () { From patchwork Mon Nov 28 19:12:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Domani X-Patchwork-Id: 61188 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AAF4338532EE for ; Mon, 28 Nov 2022 19:11:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AAF4338532EE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669662669; bh=jyqCOdvUcDgXu6DT8IKcEggxY5qZbMJ1n1VGTtDC5G8=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=PFsrpubNGQ4o15N7dHuiHCvauCBwev3dG10yaKlDY0Paylgz9JLGuUkP8OuYspQPd 7OXV10wqNrc7B5MLGT+h24tqYx0VPwIYv+QnR2ku+s9TdxWjDO+3e1LxIFbLczWps7 0iBBGXfzlZH0D6cRH38cCOkyHQPMMASCdnODGF2w= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from sonic301-22.consmr.mail.ir2.yahoo.com (sonic301-22.consmr.mail.ir2.yahoo.com [77.238.176.99]) by sourceware.org (Postfix) with ESMTPS id 93FA53857B9B for ; Mon, 28 Nov 2022 19:10:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 93FA53857B9B X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1669662645; bh=CZ4AljOVrm0fdJC1VbJTs4G8hxRIXohbTW4/IEuZm8q=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=a9bwmBvdSzot19CcnvR9P+ekM1+JQLsYA6pSZE34LPpZdq7q1XP+4QDnGJ8FfsYZ/3LftxVrD4z36WVpf+e7D99z/I5xQf0akbsYf+1VqBFvN53BfbSkBYpybIjr+lPabb+Ft6ZwACePc9PWEXP4Bl07Hdf56fdvmZ7xAukT6VbzjjU56KsLvAlZCypZwJembhd5cvzaRjwg2RWIoSmndNO6eWUfGqESAVZoQcboZ8L96GbXtZOQ5UvxAE6HjyqBYiwGOz+NBIXN68P4OPjSv9Am96USWxd3in1H2qh0UkQxvOAXnr4JivkQkYnp/2qqvm2Shpb66fWwrpSs+mQynA== X-YMail-OSG: KHCat8gVM1lTnd9enJWx1Zm1eKhQZpwO9XlFEUdID1qoxXFk5k.28s74Sd5XZvX p9AsZRPINxHBtLR1HifLZA76BJTkO3NDYk5h8aWIYHnzmCX0OPUT9f.PrqFlBzOn_QuUXvXZKuhx YHb5OxgWnFGAQ8Qq9H6mOi4n_LkMqcpFF9.m_E2DLaNrLpw_wmj_ZKk58JeLOQIhqpwNUSDzRCTI KtNaNvTutCvHf4qE9RXOX1ChpR.VGod6rQGuu0tpOcLO9mqiM_GzePY8LVi5Dcjo.Cw.9sv2.9hQ CXLHA3ZoAakKbsPfryJfxLlrabr5kMc6HeM8etnK.ghLUTn1K_oBElDlJLSqnN6AZY5oXgrrvzNA QGxYwOSLq9.fZeYl79vILiqaU79KNd8uguRnkRcWqn9sPBoXa880Y24qPktXRAfpGZ8ptj2Epjr1 w3IIF3Z2IOas0ej9JqcF61jtrd1Cbg3BaQZQrV0ZYxW08i7aMmSFh1PnMkWTVaOM7lIN9CIiiaqF EW2E7NJZVNqCqWj6zpvY.X92ZRaR4rtx3DNLAaYfqFpxG6rwqCCXQGucUxuYzVYKDSDRk9hBkV02 i4p05x2tooJEPKSf_iHclpJ5zrWaTYI86MatKy5f9uAc4NXYdief2hHQCjWVTJqOOhqBiNtaqbwb JKF39k1ZdTYsbtMuJkFeWOmMPaZ99WJ6kHqxxmY9TdOlOArHugLBaIsauz41dcRBc4.Ml9kIsWa_ py3Pqx7lLswGABDy736VW.URtJusSNLMLo7hU33wd.nwi29cVHohXPue5r8mQHjE87cnfsjdUQZb 9iqp8O9xacrX9GE4lgwgFbvwzKEruj18l01vvwFw7ZZeywKcNUwH_tWqHff7aPxUbQsBSNipel.c _b4HeNoQCohMMe1Uf4IKhbkBVIjl7kN0jv1bZgTw8Pdjxu63GMCQ5qN_Au2swP_IcMaN17SnLqbK M8WSF8ew.Md7bR63hN38yv_vUUjUM1OU3Ec2Al2yfhrJKsLGPqVYxL4bQ2Fe6_4ZUTPuPtAZH.5N W5M7ChC8ZHCE1OdvuKuhRWzUPF4d1ozJc7D4bx50aKAxoemV9gwTM1GBrslltwzMpUhJNHkoUrl_ 3LjlSKBneUQ.O6rgzKmluo3Q4dNrUcDdw7BC1Xa2T4jBUVjUxMHZYx3kjItFff6rdICgLsk2IYjF 1okZcQVmi1WfF6p2_v.3f0v4_XTJH8nS34L3xLQ9GCzyLnJpLGRjlPZeuphp3I_.X60NgqYbUXFA JSISmEMMemwUZjffLMY7QPOj2F46vR8C5ilR5sZYm96MtvUTVzbiG1NJ0GDI4e81d17FGnArzpzK A_ryXriVEabIID2touurCkfBZeiAlI5oMY.m3nKsw1mD0j17n3z7A4U4IFfjq_FiOBLgPirUa3gt CXAJbZKGOc5x7Lwho7kMdErx6SctzwZDT7jWQ64o4Q79o.qX5MraUDWF4uTnipKNoqmHHkEikeXU ZZMb2ChoJ_A_r6GBhYjhrW7Y_Tooa4N208EPZtXiM7pXO0Dp_KD3hZSZczvdal2ddNg3T2ddDbEe 5iWnB5ijYU28QOTU8LHR1DMX57I_WzlAJ3.FcGXUSxUaoeEYyh.1XDYoL121vf37hTtpN0MSukwC EmiRRCbd5WM3metYlnO7OfpytR.pVC76E5vjKpYX9O4ivlVWU3vT_C4zpvWAV5QVHk7wsCeBAoCy ZtTluxajcdTI.DWxtFZUVyQXcdaDEfFbubN2TLjbniEvopZ8gjqhpglAKo2Zkm6C0GWXDf5vszNC 8e7zTqH.rWx2q1YsWZvnjfYF1m.gTUHiqDuCWUGZXM.D_PN9ajYkoAoBEPRx98km3AKzkeTPiBMu u8DjDTjr7W0Oq9WeYDq9KdL52i1q3fLp9z2xNZBZrs4RUEKf_EIiFr2IWIPEB6mAL7PASmflvVWI h7dKyHDWMYwIKAsXJfpVhAqF32p3dmdraa_YXp4.f50sLlbsTd9NY.5eNA5g00AiCO34pKiVpIn6 RtbHFUHCzp61Pd2WV1ui6WNNIP2YmcfZHCo8TN19VioOS2rSBZ_LbujlTmbenyxZnBppLJaLy9w4 VBsehzODGFyAdHi2OTOmtWyT8XF3dVd0jLNNtEbtlH956mNcnvaYG5OcNiTGk3P0vOWKzy5SI4bW B_No1dWNWBCaJowMXFV68fbVnmCLjBJaNCTqF4_UQ1f1OqTUlc983OLVb07AvrYvPvdbM6hPzSWQ JN9pXYBm6L9sbh0_aiH64htHs9ihy11izmQ-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Mon, 28 Nov 2022 19:10:45 +0000 Received: by hermes--production-ir2-74cf6dc4df-hf6d4 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f7d2419a0d94437a4a81115c994e5e89; Mon, 28 Nov 2022 19:10:42 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH 2/4] Don't use auto for lambda parameter Date: Mon, 28 Nov 2022 20:12:22 +0100 Message-Id: <20221128191224.1411-2-ssbssa@yahoo.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221128191224.1411-1-ssbssa@yahoo.de> References: <20221128191224.1411-1-ssbssa@yahoo.de> MIME-Version: 1.0 X-Antivirus: Avast (VPS 221128-0, 11/28/2022), Outbound message X-Antivirus-Status: Clean X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Hannes Domani via Gdb-patches From: Hannes Domani Reply-To: Hannes Domani Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Older gcc versions (here 4.9.2) can't handle auto for a lambda parameter: ../../gdb/windows-nat.c: In member function 'void windows_nat_target::delete_thread(ptid_t, DWORD, bool)': ../../gdb/windows-nat.c:629:12: error: use of 'auto' in lambda parameter declaration only available with -std=c++1y or -std=gnu++1y [-Werror] [=] (auto &th) ^ --- gdb/windows-nat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index f61f6c1cb35..6da6757acaf 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -631,7 +631,7 @@ windows_nat_target::delete_thread (ptid_t ptid, DWORD exit_code, auto iter = std::find_if (windows_process.thread_list.begin (), windows_process.thread_list.end (), - [=] (auto &th) + [=] (std::unique_ptr &th) { return th->tid == id; }); From patchwork Mon Nov 28 19:12:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Domani X-Patchwork-Id: 61191 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 12A623855163 for ; Mon, 28 Nov 2022 19:11:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 12A623855163 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669662699; bh=DVJVnspg2RCwPvDxrf1L7JdHDkSFWrzl+stQQ8TlwAc=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=knCLHMkhfW3PoTMeYDI3HCpZEzOqliGODzGAw3ib1qsgU1FG7ME0GGeDJdtEMtLd7 LwCqe1XPvmX+9Ri7V2VmWgzfsBmz/EcHfY8gbRfN0fgSm5jUriB2gQkJ/ezKPftGS/ ex4UV6saLEDgx22JSo8r8pfcslYyOr2YI5bnX8Vk= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from sonic308-18.consmr.mail.ir2.yahoo.com (sonic308-18.consmr.mail.ir2.yahoo.com [77.238.178.146]) by sourceware.org (Postfix) with ESMTPS id BAD80385B199 for ; Mon, 28 Nov 2022 19:10:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BAD80385B199 X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1669662646; bh=rIypTClT9UrNxoPAf1t387s/85HwxtACUjrEqzBAn8b=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=eNWjU2yUGX4+Y/M/3O9tNJbNXr94dbLkAfVCOaa6PPqztEEkaWjkN2E/EOrPma1+YeVcGA/JepAXzisW+sy18b4EIMSFxiTblP3oshJ2ebgKQUAS9Pz7wCOa54hc4p5yPLXRa1nXjeijfsfBGZV0gRHl9+mPU3rmde7Pg4Wh2PqtE+qQvV3Er9HjWolpYi7s8V5Ot447dxx5bmDIBKbXx9Ay0LGyDh5QzAHAEHPsOOEM6KJkalCCTD2zfONNnz0xZeonz3X4HaUg8G2m3aZ2WNh6B/b6vO0Wr+vXTz7QaI0dh7ZGnKwqiStKpU+h7TzZ/PS1BuyQJXwEqJNdKWqeAw== X-YMail-OSG: pJfSzjIVM1kHM0xz7MPMvqyMSwg6gXuReIx400fsFgRGaVDYSdbi6hGRq3Kyt2m I3XHcVV1YJ5oTWr4yE3VuKpiS.sPMpoYLEGOfPmlaufaWxfkBJSUKtpDOo6rJ2yQ6J50gUK8gJaG gUvfUCjp.Zm9CvnFK4bClu2OWIhra0dj3gmDuOYS8rMsyR.ybvUFnA.ZtT5V3XU4PEd_I3Etbk9r NXrBrPjcrg7.dVDL7xwAVLrSnE0QAqRpglGmxOB0OuQ4zWDg1jxSRkmXqCcU25JItwnQEqgle1o5 ywhPH18G8MDeUnSXl7Z6Fne554SqpdKi88p6eZ62rxK7P80RP7db2g11MhS1PfGDdKhMKkikQlXr eP0WsUbl3V5.cxQSBRKpDGgIUY1d2zjgjIPJEgLzZtOD4MrrdRTPvpyfNbV5eTREeotoImlNVBXe Ar2zv7eukjJCJ75_QS4BGCwl2prxAg.fqSXFuUMamVjxUU8_ZJ.5AZCo4XZP62d7EFzfETqvhqBn ATOYY0.xYyvYDYAoUQjrGamBj8c5Yeh7dtuhQxXQ_2u.6xZfdY8MA.lPcAwDCHe.H.07pol6uuEV MIXLhja3NWvNrPhXLCm2WxQD_SjsMottlmR_pOrBpIGTFOP0kGHC313_bam7nIEtuXIsNApwAU6g KuQQJZTFkOXzGWLQjtNcUjQQFLxmbiDlajF6uKQ7Ho99d99Fqd.vTCoXQAOBRUcKhMcdsTZiBH3x AbBmlUo8YALVvgBxAcEkO_G3v5z.BavaevDVxVleIfbQPWO4swqQT78Dn_f44vYR.hZRIv8nFkmu YXB_QkoGXVK5Bef5kznJ732ItJsK.mtHDpUPKv_LkQ_NArKgpthkmzp9wWp.lVJeDXSEXqFDTlcP 6yGhKT3ordPyxbz2zl1Uzwz6_kFZx0fnodBvklvXKhWy_G9C7LyyEVWjvBNC0B1DaDbxU99AbYY1 Ae14.dmCvUnhQmzxR.4W7j1_4wsOk0wEIy9d5W8Bz0MJB6CasjJCrnGUgALayqVa2pnsOxMZYw_M A74zS2hlWQ4OsmNrqQfwm7eu90fGXUSWpj25HH6dCsjeit3cjFSPzXu3N5U0bgO8VNCw5OeojFoG lgHWAjK6qvkMdJ5dyTaA485.MipQcMxY504DdhJAP.EeSHMMJgkiprYGm55Ywt8y5Z_HpUf6cRvb USWjngBjYp1MH5UkxauSmbctXEN67kMdoBvQzPzPLw7wOZJ2AxZ.1BmwAfrB7PSSFFtA1tHhHX.3 FkwG9UGyov4S0dW0FQjiI0QNYk9VdymbtI0e44ykllPey__ZBP2Jj31RsVukB4NU_3mPAAXg39sy kylzkX0dq7iQRs7HqiAi3ne_SK6XMpmGgf3rY4hFHuEm1rjIToDEqYJKew2g_XeF2WPC.4aFLKm3 PXD13oZMDIRU2CTWhtBSWWtCIZUToW4SW0T96kXFlnu1MXEeF4JLfDMlU14REBU16XqSHjlc2l81 WNi8Nf5jpIx0rOs9tWFJ.mdo9WsG.a15JgFOWKvvNHmZ9HyOl59yQH4l2DVKiIrRavFVMudD0Rpu xHPNRu2s3ooHXbhJPXcID_fAawir06sAxdQ7ALu7GKvIsELQA_t9Lq8A9EMYsI5AyQsXbVhFux41 la_QhlsB9mGfnOGlIRpcFjxOzAAZhQYh4_mkhj88alWpOcVqmTc94dEX0pC2i9d9_cogGr9xvfEw YqEUtROQB4BE6m5I3oMiS0kgdG5hru1U4XxxisdA44pePwiQAJAzBvLUO_0PJT180GL9k.oJmtEZ lPO70kL3vP_QXKBZtLed7PtHxPq_6_WGgZlHjgXS2PuCELyIpejUqbJHFk42UmIlLdTVYCI4bOEQ 0cMP8wE84Wt907GBuKQzi3_0ylvYJVfF8GaooGjUECr2tZMldN7fnrLvFtrveXFw3p7_qeuVm5hV WV_Eh.q9bzOsNMJYN1EfrA.hgVpQJ1OE95oSj7y.ew_KBn4Ij26yd5wg.fKKJXErfdd4d5BMRSpK ZIk85rg9Bvnx6goG9ajJADdbKNMI38.ncgLkfwsNq6Hrz73U7M.pzdlFJxAAUM1VeAXo14UwTxfm MEN8kptLcvCRrOwyY9MX1fAnTjW7NrWXsP4bvmmxsc0D7XtVFTr6SaL9I8pO6Dq7Rgl7WVadSMvH 5pR4hbY5rdGnuQoSCnAG6VFlmt6YlMzVL6fC7nBZkLxLTNIgM.Cgmr77gOfo8ga69.ZFd.pwtvgv aBJJ_XV9hBrZgkGyWGTljdCRvMFyKIvKVXA-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ir2.yahoo.com with HTTP; Mon, 28 Nov 2022 19:10:46 +0000 Received: by hermes--production-ir2-74cf6dc4df-hf6d4 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f7d2419a0d94437a4a81115c994e5e89; Mon, 28 Nov 2022 19:10:43 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH 3/4] Actually set m_is_async to current async mode Date: Mon, 28 Nov 2022 20:12:23 +0100 Message-Id: <20221128191224.1411-3-ssbssa@yahoo.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221128191224.1411-1-ssbssa@yahoo.de> References: <20221128191224.1411-1-ssbssa@yahoo.de> MIME-Version: 1.0 X-Antivirus: Avast (VPS 221128-0, 11/28/2022), Outbound message X-Antivirus-Status: Clean X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Hannes Domani via Gdb-patches From: Hannes Domani Reply-To: Hannes Domani Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Looks like this was missed in the async mode implementation. --- gdb/windows-nat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index 6da6757acaf..e2d2176f138 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -427,6 +427,8 @@ windows_nat_target::async (bool enable) nullptr, "windows_nat_target"); else delete_file_handler (async_wait_fd ()); + + m_is_async = enable; } /* A wrapper for WaitForSingleObject that issues a warning if From patchwork Mon Nov 28 19:12:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Domani X-Patchwork-Id: 61190 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EFAB13853D50 for ; Mon, 28 Nov 2022 19:11:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EFAB13853D50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669662677; bh=rSCLgh0J4EdCFVkQXs73E+1Pt/E5+X4m3dP5PGcwRVI=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ynMrNPnopw+rFhV9h1Ra+7pR4BvZHSzA5EayByAsv3E9FCMh+C+6NgqIhD11vwQEG qKd1N0bnno0KMV+1W3W0k0I/FjohOmtiNju5g8uT5wrHPuWkXd6UoLRzYmgbMTtLxj 8H41f4sF0P7zbGMW2bvi1SfGwTPusTU34Ys3XVHc= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from sonic301-22.consmr.mail.ir2.yahoo.com (sonic301-22.consmr.mail.ir2.yahoo.com [77.238.176.99]) by sourceware.org (Postfix) with ESMTPS id 25C01385B1B6 for ; Mon, 28 Nov 2022 19:10:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 25C01385B1B6 X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1669662650; bh=hTXXDIrJ6y9bbVGy7XL5PamZZd30eypViuxjPjEExYy=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Vii2XQ0hg0gfWaoVH+PuMT0MKJ1QyHBq7DXFfBLBekjmduP7q7579TFGYQtSzkmXM4Zj0hgGRGpH3YtRHGJ1vEuywTgqJeBFdVAx83AJmjmnCuSbmhEFJQUnIUnUk9BEesnLYOUsppiwX8wc7NG5HdR0ls8gmswdsSK0ts6y6I1uGtXQ3+dn6g+IFBIzkanVU7RwETe1zbFKePlHgsVU0TUtBvIrq63rcB8uV6RjCMnRBPO7ElM6JSr4bl8gOowhsdAp5lfPVTH/QS7RbKszok24eIxU98VJksYoORb9dp8WT7vfCHz079s03AMFn2gO6L9d+CiMVl5PfjM+j87rPQ== X-YMail-OSG: SpBKy0QVM1nGTHCKeZQbFsYKGpea4zf13Ju.3okCEpvTrbIzNK3F4hp._Ywz.pB 0AO1INemRsIgzZ.cxQ6JENFGpBbleN3rFT4VyuOzUjrt9oNWUI.slQWiebwiYAVrjg4vOZXbwMNi VvWlH_hQs8X7GeboTyITnZxHh_uk0cnvAiU3nB3voPweAipYRT9m5.EyOLynRGsVmqDlLrbFCzoO izuwvI7gl5lMQlMgekRMZdwpUQnzZEWxPkYS2EKuzYK72tAW9SbvNCJmYXaF7g55vVFV7ZAf5Xkd xaWec30MZaUKQhupWNzgHA.9C0CB8rp3LQ1eBW43IC1cyP5GbXqpZdlZPksykvOsTK01z8uripEd cYnUCRX0gt.yu7KZLmvw1sMjcSuqa.SEnoiFa.5otvSam004zw5.Iq7M6uw_AxttCZnueNMMvejy d03QDfrjLCl57c6KysDGEZn1CRN5_tjUswyBjTeOlZl60svResc91oSA_TgNnfzg657hPjkxIjmu SJYWSm6erTjKlElrHUybvuvYsYM9asYBOFID2NOGh7sSp.BMBMkAlDQFl0Ktnw5ZL3vWmcgheyur jTFi0m5bVrJt6cT1POCwkTh2GFJXKOJgoBsqtOShV3FFkuyEY85HYK4aQFYc6z9b1BTCk.TeS4eV AQg_EDTFtHerpa0zdNAVDNJWCGxbjOhmqQk.hCZl_EdsyLHX3AE3hfIkQwxGlJYMnh9IrWYF_hSB tbCGBh7lyYTpDxbQaqMGID57ODEKYtT2oh9WDhsSuGQ7P95ePS9eqsgKE1DpYuqh4EvclWeKYZbN zZf3vJeORjs6MvWcP2hvN85_uFRkU0qBOKckltNEamUtG6WlxZAISOIiT9.6kHuehxIfhQ0Teqwy fZjjnhLa0yIyWKbXs_bkRUTZqZHY4IPAOH2r4B9ho2lMO1OvBddiA6uHeBs4gDU6HF6dxEHvKOKN wEyR3y4xloakjcgjdG5JG1hUvLL6lOd9c9BKAxMItgrBMa8CwJ98mq6Y_BYnxi4hPDBoZUv7ciRU 8UdHhCsOxJ.ILA.hHHj9rQE1O7_AUjUyc0EGPlTZTeCoR6X4BapM9WDjhMr9iL9DRwftMOHM7SzC N99WkaTvkHt8UfcBmBa9XWknx0oIkeMHkDJnZyaYwhirDB_M3MvIVqartAfWx8qa.lRiGztTkhrq 0i8jdd1AQNVbbSALPIeICwmJCMkE3F2cbqAydQIRgzflGZMDI3VH7VY8qt3ujHwuHtYnMejydGwH thBh1qgr._HUsE5ashN8mQ2.ntG0lIbOL0uPA_m1LJOZjTq7s.MVpTeSNhAB7Nm_8qgDXknSADw3 gxbkC6Yr.UATfJzmvile.BBXm3Kx6pllgRxC5BWMlHg9252tEW031fd_f.LuWcoQDlYWSZVh0C6L njyRnkFNdK4c5spM4bvRLS6MApgX6.Oa0agGbiuAKR5XVKMCXSOEVzsSrV.vjL0aVC.IEeGNSAvM 71SrPfdi9kYru4ar_4Pqs4YDLdn6ByBY9byCafAlS8kT3qpjJC4ajXJYzbDpoBNp_dW1foxS_FT_ e6Fj3VBltzThjtatCVdVExG4T_aaVX8um8i3s1ukrn71nCoFrmGQcm_64S2uNQROs5FhRWks0tE4 AeumJd70IEZkvvUCzsPld_sjgoq56AFyJKp18neHah_keMrFq_bFKUOpJbJu4fSM6rZAlzRAebv5 369K5FOGBTYNNYwPeythpCD26DVhA6OWnv_tmf3R6688TFFyFXhsCNzX3X3_vRZ9hUCWlpzXaG.Q OonnA1RV9RJ_nf.zlwUyNNj5T1R2j972DXIM7KbloO_q7ERdTRZhyoDkfdwuLJh4vIZXhxz5v3ZX geQwEuV694yODNOBI0GN_F4FLORwaq5pGkdrKGmeTk2532kYT89YfxHquJjR6wWeO9S2ZYVQc1NT CIM7n8oXhBVpe7tD8LFlHYqJKLdiuqkRSOzEmhqbXQzEN734htSOrh7wdFmrUfCLTT0Ick1ae7J9 xVeQK8zxXkAzgD1ZAQ5gS.QMlEBUows0aqQb2SCbbU.3uKGEn2KhA3A8ED6yPe.blS7YZuhwKB0W aMlM6th8uwaP7GO_FzpUOqPvCoXH59TKkDaceS8NsVISmFl8ubQMja1YIndJfCJdTH9wGwbTG492 Nry6zXDYbYpPP7kHDe2AUMMInXy4DIVaZiByawzWXww0SzhqwONGjke_XpqHfpcS4vBWnVelzMQA J.YWAk06De2MaLOkRJneSTEuQdcqhHoNttdo- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Mon, 28 Nov 2022 19:10:50 +0000 Received: by hermes--production-ir2-74cf6dc4df-hf6d4 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f7d2419a0d94437a4a81115c994e5e89; Mon, 28 Nov 2022 19:10:44 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH 4/4] Remove no longer used jump label Date: Mon, 28 Nov 2022 20:12:24 +0100 Message-Id: <20221128191224.1411-4-ssbssa@yahoo.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221128191224.1411-1-ssbssa@yahoo.de> References: <20221128191224.1411-1-ssbssa@yahoo.de> MIME-Version: 1.0 X-Antivirus: Avast (VPS 221128-0, 11/28/2022), Outbound message X-Antivirus-Status: Clean X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Hannes Domani via Gdb-patches From: Hannes Domani Reply-To: Hannes Domani Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" --- gdb/windows-nat.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index e2d2176f138..17422e15f80 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -1824,7 +1824,6 @@ windows_nat_target::get_windows_debug_event windows_process.desired_stop_thread_id, 0)); } -out: if (thread_id == 0) return null_ptid; return ptid_t (windows_process.current_event.dwProcessId, thread_id, 0);