From patchwork Wed Nov 23 13:27:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 61028 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 90C7D3852C6B for ; Wed, 23 Nov 2022 13:27:26 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 7E82A3854569 for ; Wed, 23 Nov 2022 13:27:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E82A3854569 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 4CBC961661; Wed, 23 Nov 2022 14:27:08 +0100 (CET) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nudEbcumayvR; Wed, 23 Nov 2022 14:27:07 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p50854a7a.dip0.t-ipconnect.de [80.133.74.122]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 8E3BC61660; Wed, 23 Nov 2022 14:27:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1669210027; bh=MweE8Qn3Tdtx5zKsiXj7z07v2Ax62Sw3BOD4QlYMW90=; h=From:To:Cc:Subject:Date:From; b=FxgW9oeBiMBeP1ltqWTgA5ocSMUSCr9ogJWTIo+OHHX8d/+sY/07ys4RqMPOfh3j7 5j2F9xO8pBxfMT6qFuE6QKZn8F8Ps+d3V7zxRF89hJtSKfIcWBfNRvGNWQ16aA6B+P ssisQ3sb/QpsXaO7sDs9tqHMMS6l4ODONtil26kxUTg+2kWJJ1dZBxgOOhJeFYnOsk cS7tFYG1XQrLYeHI5tksYHsaB615EcX84YMd0VYDNfPpbzNiSpDKK27L50ZeblFUfF 8vnqOym93OUwdHtRwA7MbnYlOq0N+B95rlj+qpPKiLvgyuaGsUwZl05qvZJXt76Im/ KBQeEG2PFpnnw== From: Rainer Orth To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [PATCH] analyzer: Use __builtin_alloca in gcc.dg/analyzer/call-summaries-2.c Date: Wed, 23 Nov 2022 14:27:07 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 X-Spam-Status: No, score=-3794.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" gcc.dg/analyzer/call-summaries-2.c currently FAILs on Solaris: FAIL: gcc.dg/analyzer/call-summaries-2.c (test for excess errors) Excess errors: /vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/call-summaries-2.c:468:12: warning: implicit declaration of function 'alloca' [-Wimplicit-function-declaration] /vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/call-summaries-2.c:468:12: warning: incompatible implicit decl alloca is only declared in , which isn't included indirectly anywhere. To avoid this, I switched the test to use __builtin_alloca instead, following the vast majority of analyzer tests that use alloca. Tested no i386-pc-solaris2.11, sparc-sun-solaris2.11, and x86_64-pc-linux-gnu. Ok for trunk? There are a handful of tests that explicitly include instead, which is of course an alternative if preferred. Rainer diff --git a/gcc/testsuite/gcc.dg/analyzer/call-summaries-2.c b/gcc/testsuite/gcc.dg/analyzer/call-summaries-2.c --- a/gcc/testsuite/gcc.dg/analyzer/call-summaries-2.c +++ b/gcc/testsuite/gcc.dg/analyzer/call-summaries-2.c @@ -465,7 +465,7 @@ int test_returns_external_result (void) int uses_alloca (int i) { - int *p = alloca (sizeof (int)); + int *p = __builtin_alloca (sizeof (int)); *p = i; return *p; }