From patchwork Sun Nov 20 22:50:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramana Radhakrishnan X-Patchwork-Id: 60896 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6436A3858CDB for ; Sun, 20 Nov 2022 22:51:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6436A3858CDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668984674; bh=V8e/8Ji2CZQ/O1GeCpbhd70v2qholGSQtlpbO4w991I=; h=Date:Subject:To:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=PcOuG3R+d4ZkS+8Q+dKY2qc4r17Hgskl1Y1UKxR36UFNX+PX7I880K/PfteQfyDpT tMd7/led0onLtg/CPUTPELHGHab/ZKmCZqhywGnl9oMZGJiXbD+JmvbretGp4jHOex 77crv4O8Ly/hE8ro8h+aCjuaOrSo4jRWAKYk++GA= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 1F5EC3858C2F for ; Sun, 20 Nov 2022 22:50:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1F5EC3858C2F Received: by mail-wr1-x429.google.com with SMTP id d1so5297760wrs.12 for ; Sun, 20 Nov 2022 14:50:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=V8e/8Ji2CZQ/O1GeCpbhd70v2qholGSQtlpbO4w991I=; b=YXoAjBBALZzdQwarvSU3Qulsi56fASlH96Eaq6aJOd9TsROM90noYEV1MwQUxIDneG Kcg/yB/G2b/GBfX18QI9D6j9teqGleL+LdM2zSX9poCEDA86Pp4EP4KSG+kQvlMid8m+ yaN9H9SvKz3GSZ4nO2E9i7rcXCHeTirTp0fnAbchKvQH1TEaz+gwitSvyrFVcflu0zwS CHgN7vw/BeQN4vgJqia+emF2jQOmTdvI75UOSCylIIAa0FylwHZaTlYlc2zdCwaS7Y/8 q7+GVJUscynigsU3yFjOTBiMiaZpPM6U2PtK2lCC65CWckdsXCL4ealpy99QNx8HwoVJ vUXA== X-Gm-Message-State: ANoB5pmuaI0VvrISVJLPwKSj2nv6GcUgva/IV+bO0cNrRp4kjBY0CM2e F3i0Vz/Sfj0gkXXrp6Ir5KCIBn8WncXJCKr1LZNmMWidw9M= X-Google-Smtp-Source: AA0mqf6uWIvFyBr9IXZT0iYWnycig54JolhQhnoQe/ncFJljm90AQlCjU7uvPDZxVx6AXQlm/w37i6kGKKtdpRd4wCg= X-Received: by 2002:adf:dc01:0:b0:241:b6d0:97e with SMTP id t1-20020adfdc01000000b00241b6d0097emr3473147wri.100.1668984617728; Sun, 20 Nov 2022 14:50:17 -0800 (PST) MIME-Version: 1.0 Date: Sun, 20 Nov 2022 22:50:06 +0000 Message-ID: Subject: [Patch Arm] Add neon_fcmla and neon_fcadd as neon_type instructions. To: gcc-patches Cc: Kyrylo Tkachov , Richard Earnshaw , Richard Sandiford X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Ramana Radhakrishnan via Gcc-patches From: Ramana Radhakrishnan Reply-To: Ramana Radhakrishnan Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" [AArch64 folks CC'd fyi as this is common between both backends.] Hi, The design in the backend used to be that advanced simd types are generally added to is_neon_type in the backend. It appears that neon_fcmla and neon_fcadd aren't added in as neon_type instructions. Applying this to the tree later this week after having built armhf and a bootstrap and test run on aarch64-linux-gnu. Thanks, Ramana commit 7dd15fae0ac1455f5818a1fc0078e35d85e1e250 Author: Ramana Radhakrishnan Date: Wed Nov 16 10:32:04 2022 +0000 [Patch Arm] Add neon_fcadd and neon_fcmla to is_neon_type. Appears to have been an oversight. gcc/ * config/arm/types.md: Update comment. (is_neon_type): Add neon_fcmla, neon_fcadd. Signed-off-by: Ramana Radhakrishnan diff --git a/gcc/config/arm/types.md b/gcc/config/arm/types.md index 7d0504bdd94..d0d9997efd2 100644 --- a/gcc/config/arm/types.md +++ b/gcc/config/arm/types.md @@ -248,7 +248,8 @@ (define_attr "autodetect_type" ; wmmx_wunpckil ; wmmx_wxor ; -; The classification below is for NEON instructions. +; The classification below is for NEON instructions. If a new neon type is +; added, please ensure this is added to the is_neon_type attribute below too. ; ; neon_add ; neon_add_q @@ -1281,6 +1282,7 @@ (define_attr "is_neon_type" "yes,no" neon_fp_mla_d_q, neon_fp_mla_d_scalar_q, neon_fp_sqrt_s,\ neon_fp_sqrt_s_q, neon_fp_sqrt_d, neon_fp_sqrt_d_q,\ neon_fp_div_s, neon_fp_div_s_q, neon_fp_div_d, neon_fp_div_d_q, crypto_aese,\ + neon_fcadd, neon_fcmla, \ crypto_aesmc, crypto_sha1_xor, crypto_sha1_fast, crypto_sha1_slow,\ crypto_sha256_fast, crypto_sha256_slow") (const_string "yes")