From patchwork Thu Nov 10 17:09:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guinevere Larsen X-Patchwork-Id: 60360 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F22773858D3C for ; Thu, 10 Nov 2022 17:10:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F22773858D3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668100209; bh=Kc6BMDqAzv+/0C+NMclGFfjp8Su9RC8rYal/mIDAvWw=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=co+1oETlBdW1Rt+0Gs2WVUkxIi21JYdEaN12CasVNhq3Jz9A+nKOY/zXCBsIvg6FX CJCr0mFJnJBrTcztVGKFepnn0KZMFitjwNWzyTBo4PKPVqFHj/5sh/2OO2v6PgqF3z aMCrf8tB9eiQx5lbQzyZN9tDdnRzzSX9zm4arcDc= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 17D443858D1E for ; Thu, 10 Nov 2022 17:09:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 17D443858D1E Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-403-x8D0P9qoM2qkTI3uUf8_2w-1; Thu, 10 Nov 2022 12:09:36 -0500 X-MC-Unique: x8D0P9qoM2qkTI3uUf8_2w-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6E061185A7A3 for ; Thu, 10 Nov 2022 17:09:36 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.32.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 02549483EFB; Thu, 10 Nov 2022 17:09:35 +0000 (UTC) To: gdb-patches@sourceware.org Cc: Bruno Larsen Subject: [OBV PATCH] gdb: Fix regressions caused by 041de3d73aa121f2ff0c077213598963bfb34b79 Date: Thu, 10 Nov 2022 18:09:24 +0100 Message-Id: <20221110170923.111483-1-blarsen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Bruno Larsen via Gdb-patches From: Guinevere Larsen Reply-To: Bruno Larsen Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Commit 041de3d73aa changed the output format of all error messages when GDB couldn't determine a compatible overload for a given function, but it was only supposed to change if the failure happened due to incomplete types. This commit removes the stray . that was added --- gdb/valops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/valops.c b/gdb/valops.c index 2b789cd76f4..e90c3947b8d 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -2979,12 +2979,12 @@ find_overload_match (gdb::array_view args, { std::string hint = incomplete_type_hint (args); if (method == METHOD) - error (_("Cannot resolve method %s%s%s to any overloaded instance.%s"), + error (_("Cannot resolve method %s%s%s to any overloaded instance%s"), obj_type_name, (obj_type_name && *obj_type_name) ? "::" : "", name, hint.c_str ()); else - error (_("Cannot resolve function %s to any overloaded instance.%s"), + error (_("Cannot resolve function %s to any overloaded instance%s"), func_name, hint.c_str ()); } else if (match_quality == NON_STANDARD)