From patchwork Sun Nov 6 18:17:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fangrui Song X-Patchwork-Id: 60039 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5F7153858D1E for ; Sun, 6 Nov 2022 18:19:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5F7153858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1667758780; bh=5IaE7/srE6ScyteE2LDKxDf/0ePpA7xTFs5SGDVKxIk=; h=Date:Subject:To:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=oYXee+L3Bh32yxb288N1N7/fq1Bk+tlwrA2AnAV2KEOPLP5jOK5yUMpJiZUVOq8cA qJjT+ywym2EvuNli/6WogrAQ10cFo7W6Z1f97NsiSD9f4P01onifBYogpXC1TJuIHt 29UF/2ybxIBjG6L63QToK899Dha/6xPAVnRqPg0I= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pl1-x64a.google.com (mail-pl1-x64a.google.com [IPv6:2607:f8b0:4864:20::64a]) by sourceware.org (Postfix) with ESMTPS id 0EA713858C66 for ; Sun, 6 Nov 2022 18:17:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0EA713858C66 Received: by mail-pl1-x64a.google.com with SMTP id s15-20020a170902ea0f00b00187050232fcso7527678plg.3 for ; Sun, 06 Nov 2022 10:17:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5IaE7/srE6ScyteE2LDKxDf/0ePpA7xTFs5SGDVKxIk=; b=ICLm3LKgSD9C+XC3ZEHU0VvmIzWUIEpRI+EzkAnrfqfkmk2XtmtrvxliniF9G+zVm6 YboNPjci/Si0CMjqkFHv+wI8nMMRz/ZABSBIwpC3nkSGbfpRX7/+zAeSAvkL9cmJ8Zla Qrapbprz41yGbJ0kegsh+G+R785cgrDdi80dmAoOm3TPuG7W8O0XibNOwgrMzKcSPWye 0v+8RbMcI1F0On2GRzC/6q9vK8RQ4snVqvkGKs9xUK8DZjQUP7xk3LydzaCOOwHRc368 4MNSZZn45ExbKG6WnSmC6Oia5qRiGJftphRbHgebjpQGXFdQpdUi18Lg7U59GigDCHXQ jMNA== X-Gm-Message-State: ACrzQf1VLUNWz6MEDOnQ38peUAxT10xlKsaKSf1jF0OXdRoUGWMwtPkO GljhWH7hfk1eHi6URkpi136h2x3y1/uequfvjuerI6LRPJCgu/4+d35VVtx8v3mZtojogQwjvUO BvLTqWlcPeZpQWuhuLV7ca2u+hNpv9u8mIJb/qmUP2kUG1zpDLE9RjFXJ9lSZVcIUnFnW X-Google-Smtp-Source: AMsMyM6fBdOip3jwuU31vzdVGPSaTi9mRsI5RDrQX6YBlaWfjOOftBmUtWzqm26ZKwfC06Wc4DViciHikI6j X-Received: from meowing-l.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:3eba]) (user=maskray job=sendgmr) by 2002:a17:90b:3c4b:b0:206:238e:1379 with SMTP id pm11-20020a17090b3c4b00b00206238e1379mr649294pjb.180.1667758675710; Sun, 06 Nov 2022 10:17:55 -0800 (PST) Date: Sun, 6 Nov 2022 18:17:50 +0000 Mime-Version: 1.0 Message-ID: <20221106181750.2859300-1-maskray@google.com> Subject: [PATCH] Makerules: Generate shlib.lds with -fuse-ld=bfd To: libc-alpha@sourceware.org, Florian Weimer Cc: Fangrui Song X-Spam-Status: No, score=-19.3 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Fangrui Song via Libc-alpha From: Fangrui Song Reply-To: Fangrui Song Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" lld does not dump a linker script with --verbose (it does not use a linker script driven design and lots of linker processing is not serializable as a linker script anyway). With the default --with-default-link=no build, $@T is empty and makes `test -s $@T` fail. Just dump the linker script with -fuse-ld=bfd. lld since 15 (https://reviews.llvm.org/D124656) supports custom RELRO sections in the GNU ld dumped linker script. Reviewed-by: Sam James > --- Makerules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makerules b/Makerules index 09c0cf8357..2edc6ee4e1 100644 --- a/Makerules +++ b/Makerules @@ -553,7 +553,7 @@ else # not for shared objects $(common-objpfx)shlib.lds: $(common-objpfx)config.make $(..)Makerules $(LINK.o) -shared -Wl,-O1 \ - -nostdlib -nostartfiles \ + -nostdlib -nostartfiles -fuse-ld=bfd \ $(sysdep-LDFLAGS) $(rtld-LDFLAGS) $(LDFLAGS.so) \ -Wl,--verbose 2>/dev/null | \ sed > $@T \