From patchwork Fri Nov 4 00:41:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 59872 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ECE563858425 for ; Fri, 4 Nov 2022 00:42:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ECE563858425 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1667522549; bh=nsHvHhI2p7w7RuXY11MNw/Yn7v1X551+nXbARDAlGv4=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=e3AFzQEX1czKvlD3rhyQfnRSj9EKfA6oJLkLAa7IQGXj/jJke7I4Rfa3aez2hAhdX mbFcVZJ2hO5KqK02PEKO+pwOyKaUrRjeGsqNUzBBy0E1P9G2ZfDXstkgqEKhrvUXp0 c6i6fuqshVjZOD1QRuX9O4xE/bikoYBTebV02MNI= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 865A93858C62 for ; Fri, 4 Nov 2022 00:42:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 865A93858C62 Received: by smtp.gentoo.org (Postfix, from userid 559) id CC35B3407AF; Fri, 4 Nov 2022 00:41:07 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH] sim: mips: call Unpredictable instead of setting bogus values [PR sim/29276] Date: Fri, 4 Nov 2022 07:41:04 +0700 Message-Id: <20221104004104.20150-1-vapier@gentoo.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mike Frysinger via Gdb-patches From: Mike Frysinger Reply-To: Mike Frysinger Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The intention of this code seems to be to indicate that this insn should not be used and produces undefined behavior, so instead of setting registers to bogus values, call Unpredictable. This fixes build warnings due to 32-bit/64-bit type conversions, and outputs a log message for users at runtime instead of silent corruption. Bug: https://sourceware.org/PR29276 --- sim/mips/mips.igen | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/mips/mips.igen b/sim/mips/mips.igen index dfad42276155..0746a52d5ab1 100644 --- a/sim/mips/mips.igen +++ b/sim/mips/mips.igen @@ -1450,7 +1450,7 @@ else if ((fs & 0x1) == 0) GPR[rt] = SET64HI (FGR[fs+1]) | FGR[fs]; else - GPR[rt] = SET64HI (0xDEADC0DE) | 0xBAD0BAD0; + Unpredictable (); TRACE_ALU_RESULT (GPR[rt]); } @@ -5782,7 +5782,7 @@ else if ((FS & 0x1) == 0) v = SET64HI (FGR[FS+1]) | FGR[FS]; else - v = SET64HI (0xDEADC0DE) | 0xBAD0BAD0; + Unpredictable (); PENDING_FILL (RT, v); TRACE_ALU_RESULT (v); }