From patchwork Wed Oct 19 03:39:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rustam Kovhaev X-Patchwork-Id: 59039 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 887003858C2F for ; Wed, 19 Oct 2022 03:49:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 887003858C2F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666151353; bh=9hCt5hlqJVDwm31zsEBMgrJPJglJCJVqNSEbhoI7g80=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=MMD44+UxU5qXNRm7GOaCQG9ZXxDUKAUrA5PcBnlUAKZe8nFcQHZr3SwjoGCHIVnTp wkaXPEYBDbKrnpSTvgfHuTOJ20nQ9nE+4dhZSMv7EfCHNgL66glvtFANx9RQ1EdzKk sM6vbRvOBvgf/h75z4VRKo53/LjxiRMo55+PZjDs= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id 9C2EC3858D32 for ; Wed, 19 Oct 2022 03:48:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9C2EC3858D32 Received: by mail-pg1-x535.google.com with SMTP id l6so15108241pgu.7 for ; Tue, 18 Oct 2022 20:48:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9hCt5hlqJVDwm31zsEBMgrJPJglJCJVqNSEbhoI7g80=; b=ztwkyTQnOADUTV9T5FBzFFRh7LNmGx/63dm0SAxwGyKQ4uvj/I5oNHpbEispyouNii dt/1P/khidK23p9eAltgV0pGLiRFn2hjHYGaKJo51dPPdQeQ2lhHkGWf36DQcj0zO/ff 1sNj5r4Pg5AjpR3CX1vkSfZf1OUTGHT/9W9L9EJVMf7uSxu95VolPQbraBHh4cZMTZCW ggIpnFDn+xiEaDATxyLKFMVYPAp2cZVXjilsQlagoceXaP2ioRK5RobOSSsGK600lq+E fXCcAYWXsodcFIhZgO96zelhvNqkRYeItyIGxGpNSntLQt8KNH2yHri4ees3QMy4jyy+ EHOA== X-Gm-Message-State: ACrzQf2q4/tLDrOJB3RQ0tfGXKoaf/UBWX74n3JFX7IK/8yE4TvqIDwa JHij2H/rqQCIFpV5xUcB/xMRhobdKB4= X-Google-Smtp-Source: AMsMyM5IFdm+8d87pQICe2X1vWB+vhe714v2l3qupUgCIfQk/lmy52ZFaE4y60TJcmwgMnfRijhjMQ== X-Received: by 2002:a62:31c7:0:b0:561:86fb:27e9 with SMTP id x190-20020a6231c7000000b0056186fb27e9mr6398731pfx.63.1666151327648; Tue, 18 Oct 2022 20:48:47 -0700 (PDT) Received: from nuc10.. ([104.36.148.254]) by smtp.gmail.com with ESMTPSA id a10-20020aa78e8a000000b0056316f0b7f8sm10103909pfr.33.2022.10.18.20.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Oct 2022 20:48:47 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [RFC PATCH] gdb: add command to clear value history Date: Tue, 18 Oct 2022 20:39:28 -0700 Message-Id: <20221019033925.86910-1-rkovhaev@gmail.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Rustam Kovhaev via Gdb-patches From: Rustam Kovhaev Reply-To: Rustam Kovhaev Cc: rkovhaev@gmail.com Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Hello, While debugging an application I wanted to clear the value history and I could not find an option to do it. I might be the only one who gets lost in the value history and I am not sure if anyone else needs it, but I thought it would be nice to have it. And I hope this does not break anything. Please let me know what you think. Thanks! Let's have the functionality to clear the value history. Introduce 'set values clear' command to clear the value history. Signed-off-by: Rustam Kovhaev --- gdb/value.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/gdb/value.c b/gdb/value.c index 605e52dee82..726b5ef9084 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -1971,6 +1971,15 @@ show_values (const char *num_exp, int from_tty) if (from_tty && num_exp) set_repeat_arguments ("+"); } + +static struct cmd_list_element *setvallist; + +static void +clear_values (const char *ignore, int from_tty) +{ + value_history.clear (); +} + enum internalvar_kind { @@ -4343,6 +4352,13 @@ Convenience functions are defined via the Python API." Elements of value history around item number IDX (or last ten)."), &showlist); + add_cmd("clear", no_class, clear_values, _("\ +Clear value history."), &setvallist); + + add_basic_prefix_cmd ("values", class_support, _("\ +Generic command for setting value history parameters"), + &setvallist, 0, &setlist); + add_com ("init-if-undefined", class_vars, init_if_undefined_command, _("\ Initialize a convenience variable if necessary.\n\ init-if-undefined VARIABLE = EXPRESSION\n\