From patchwork Mon Oct 10 11:58:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 58584 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 529443857C6F for ; Mon, 10 Oct 2022 11:58:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 529443857C6F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665403124; bh=SKWVqkZWZId6GMikJ6IZFwsM99YFYYaBlWniOgqsXDk=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=mCdLX9mkwf8+/XgPWk1hMeo51Zw7SR9ux0hTqKMsSE/E6ba+0Oc6ifsQaCy+uJ/K2 dyTw2hqq1Ms701SMSI959GAufAFYabZRyLLFgXb5EWm7M3IPgugxMJuvoO1KZOFZFD sgCSbXdNilzfTCrITPvRwlRmtdhMi4L/oQlKqiGA= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3082B3858D37 for ; Mon, 10 Oct 2022 11:58:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3082B3858D37 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-272-L1VtC9lNNLupP6rR6EGyUg-1; Mon, 10 Oct 2022 07:58:27 -0400 X-MC-Unique: L1VtC9lNNLupP6rR6EGyUg-1 Received: by mail-wr1-f70.google.com with SMTP id u20-20020adfc654000000b0022cc05e9119so2642994wrg.16 for ; Mon, 10 Oct 2022 04:58:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:organization:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SKWVqkZWZId6GMikJ6IZFwsM99YFYYaBlWniOgqsXDk=; b=JhwceouDcMXFaI16vWCIk6OSvjMc0xix8y4rQPqzX/M10fhSUYvNRvVw0XFPcOlBWg IFJpIfxWUdwJl77GcZbxi/3LaVrZbV012mYNoUEqoBWvyiUJvhFic1tN47toEt5nyUOL 82PmuK1p6pNqQ9H8UlULNYGgxNX7pWR/td6vzF4RmftZpqnqVa0qoYSXexkNwhpJwzja ZqK9Mewlx2rMLEilKIgihk+e4k+FEbvzcijM5eunx+WrXMNNtWuELkmm9ierrIf5ddpa qhXjS3Kb4sUlBHFK55Ny/PwziwquO35JtIOijlf39tFjsIqH8NuCZdLsQhatuefVBNSy 6sxA== X-Gm-Message-State: ACrzQf38NblNvqzdIKr3F7NPNK06VQfSkvNHvXaWzRZcbTriQT9nGPsL IthvLTi4Xb+smZngytwPJ343fdXF6Q+zIDrCShundWjtVaUtE7FoAf6TIq30lowAhB19zcRFvCS F5piBmQE4bsqCjeR/dc413T8/wJtCMZTTCW06UwhDF+KtQOcdvj4VCBlOKHV41eJ6tMe6 X-Received: by 2002:a05:600c:1989:b0:3b4:b6b6:737 with SMTP id t9-20020a05600c198900b003b4b6b60737mr12499199wmq.79.1665403106305; Mon, 10 Oct 2022 04:58:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4L/UOev9Dy3y1rr7wgIAJWI62+4MGG5vf5ucoG9a8R4rIu3C0l2U78miG3N7bqso+PFYYuig== X-Received: by 2002:a05:600c:1989:b0:3b4:b6b6:737 with SMTP id t9-20020a05600c198900b003b4b6b60737mr12499186wmq.79.1665403106075; Mon, 10 Oct 2022 04:58:26 -0700 (PDT) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id m38-20020a05600c3b2600b003b4ff30e566sm36186484wms.3.2022.10.10.04.58.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 04:58:25 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 48767581C53; Mon, 10 Oct 2022 13:58:25 +0200 (CEST) To: libabigail@sourceware.org Subject: [PATCH, applied] ir: Fix a wrong comment in canonicalize() Organization: Red Hat / France X-Operating-System: Fedora 38 X-URL: http://www.redhat.com Date: Mon, 10 Oct 2022 13:58:25 +0200 Message-ID: <87pmez28m6.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, While looking at something else, I noticed a comment that doesn't make sense in the canonicalize() Fixed thus. * src/abg-ir.cc (canonicalize): Fix a comment. Signed-off-by: Dodji Seketeli --- src/abg-ir.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/abg-ir.cc b/src/abg-ir.cc index e6b8409a..2fc7e747 100644 --- a/src/abg-ir.cc +++ b/src/abg-ir.cc @@ -14673,8 +14673,10 @@ canonicalize(type_base_sptr t) // comparison of another type that was being canonicalized // // 2/ Or the canonical type has been propagated during the - // comparison of another type was being canonicalized and that - // propagated canonical type has been confirmed. + // comparison of another type that was being canonicalized and + // that propagated canonical type has been confirmed, because + // it was depending on a recursive type which comparison + // succeeded. ABG_ASSERT(!t->priv_->canonical_type_propagated() || t->priv_->propagated_canonical_type_confirmed());