From patchwork Mon Sep 12 09:04:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 57570 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3003338515CA for ; Mon, 12 Sep 2022 09:04:34 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 00B843857017 for ; Mon, 12 Sep 2022 09:04:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 00B843857017 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,308,1654588800"; d="diff'?scan'208";a="82700271" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 12 Sep 2022 01:04:16 -0800 IronPort-SDR: YyjWeC0oXyGae7xVvkyaUlrxyzAHD5/CSr1ssnpZM9xki8W67Y5eAcHDb2/JouHq8twrwE42BM RYFQcLDKx7RO8mW9CgznuFjJAvRgyvKXdGPuTJSByiyLv+Sc4QtZCXqwQnBl1aR8/RkobsEzi0 RAnS0h4U3lOzNSaDmU9Sx6VWj97Vc818wCy6NntjnxAQ9BHF0NuTpKigmPUNA/NbhEVlvofwYV XUtdxvah/i1Hzqz/oft3v/dPU+04dQktYq+nF8W9Yy+abDb6Ihsf1HJv2k8zoMOMv1MFPyyVEB MiQ= Message-ID: <7833e1c2-c66c-8a6e-8aed-becfe7899eeb@codesourcery.com> Date: Mon, 12 Sep 2022 11:04:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Content-Language: en-US To: gcc-patches , Jakub Jelinek From: Tobias Burnus Subject: [patch] libgomp.texi: Impl. status fix/addition X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" This patch is about the OpenMP 5.{1,2} implementation status. For omp/ompx/omx, I think it was a bit misleading. omp/ompx (and omx) are reserved namespaces; for 'omp' nothing needs to be done (either already implemented or not), while for 'ompx'/'omx' (vendor extension), the note + footnote tries to describe what happens. – I hope the revised wording is clearer. The other change is about two OpenMP 5.1 items; the first one seems to get used in some code – 'begin declare target' is essentially the same as 'declare target' ... 'end declare target' but additionally permits clauses. And the second new item: I think it was regarded as bug fix, but I personally read it rather as change. The question is as what to read it and how to handle it? Initially I wrote and thought of it as deprecation of the previous syntax, i.e. warning but only once the OpenMP version has been bumped to 5.2's. I now think we could diagnose it earlier – IMO a warning would be sufficient, but it could also be read it such that an error is required. – Thoughts about this item + what to implement? Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 libgomp.texi: Impl. status fix/addition libgomp/ChangeLog: * libgomp.texi (OpenMP 5.1 Impl. Status): Add two new minor items. (OpenMP 5.2 Impl. Status): Improve omp/omx/ompx wording. diff --git a/libgomp/libgomp.texi b/libgomp/libgomp.texi index 3dc467aade0..7db5fab580a 100644 --- a/libgomp/libgomp.texi +++ b/libgomp/libgomp.texi @@ -348,6 +348,9 @@ The OpenMP 4.5 specification is fully supported. @item Support @code{begin/end declare target} syntax in C/C++ @tab N @tab @item Pointer predetermined firstprivate getting initialized to address of matching mapped list item per 5.1, Sect. 2.21.7.2 @tab N @tab +@item @code{begin declare target} directive @tab N @tab +@item For Fortran, diagnose placing declarative before/between @code{USE}, + @code{IMPORT}, and @code{IMPLICIT} as invalid @tab N @tab @end multitable @@ -362,12 +365,13 @@ to address of matching mapped list item per 5.1, Sect. 2.21.7.2 @tab N @tab @tab N @tab @item @code{omp}/@code{ompx}/@code{omx} sentinels and @code{omp_}/@code{ompx_} namespaces @tab N/A - @tab warning for @code{omp/ompx} sentinels@footnote{@code{omp/ompx} - sentinels as C/C++ pragma and C++ attributes are warned for with + @tab warning for @code{ompx/omx} sentinels@footnote{The @code{ompx} + sentinel as C/C++ pragma and C++ attributes are warned for with @code{-Wunknown-pragmas} (implied by @code{-Wall}) and @code{-Wattributes} (enabled by default), respectively; for Fortran free-source code, there is - a warning enabled by default and for fixed-source code with - @code{-Wsurprising} (enabled by @code{-Wall})} + a warning enabled by default and, for fixed-source code, the @code{omx} + sentinel is warned for with with @code{-Wsurprising} (enabled by + @code{-Wall}). Unknown clauses are always rejected with an error.} @item Clauses on @code{end} directive can be on directive @tab N @tab @item Deprecation of no-argument @code{destroy} clause on @code{depobj} @tab N @tab