From patchwork Wed Aug 10 06:09:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Sayle X-Patchwork-Id: 56634 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1F1AB3858419 for ; Wed, 10 Aug 2022 06:09:21 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from server.nextmovesoftware.com (server.nextmovesoftware.com [162.254.253.69]) by sourceware.org (Postfix) with ESMTPS id DBEA93858419 for ; Wed, 10 Aug 2022 06:09:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DBEA93858419 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nextmovesoftware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nextmovesoftware.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nextmovesoftware.com; s=default; h=Content-Type:MIME-Version:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PWZGTttxovYzUAASg6erZshNps0vV4FLSvnxavvpK8M=; b=kvuQ5Z3L7+iGc3piEC5kc+QJhJ UQx8UmiN2zh6ijnSTw29kZtrSdmuWKl8UJAHaaCiJPF0YWgtctY/ex789+zlwzza6IzvCgzIV5khj vfdhUYLD8WmVGnwaLa2RTzrP2Bv5bLG+qeGOhIll3XSzxj8tBxu1M1Hv9BOho8/m87108YtpJk0Oq hVqJDiN6s6qSf60//Q+i+fbKxJQYf5xkfR8Ng1NwfeYvuSlCC35NHdwl0Iu/8zi1KTzW6gligTkKU CE3xuSc/jgcwdN7gVUSjkThEUZ+A/nS1HdKmZERiR1I5snROvfHR3DOmA35n35bKQNHLrhJZtQ63e ol+ZQMPQ==; Received: from host86-169-41-119.range86-169.btcentralplus.com ([86.169.41.119]:58107 helo=Dell) by server.nextmovesoftware.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oLets-0003XP-08 for gcc-patches@gcc.gnu.org; Wed, 10 Aug 2022 02:09:04 -0400 From: "Roger Sayle" To: Subject: [Committed] PR other/106575: Use "signed char" in new fold-eqandshift-4.c Date: Wed, 10 Aug 2022 07:09:02 +0100 Message-ID: <057e01d8ac7f$b0f48ab0$12dda010$@nextmovesoftware.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AdisfvdyB5HlT9qVTbWHC4lcdc1Frg== Content-Language: en-gb X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.nextmovesoftware.com X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - nextmovesoftware.com X-Get-Message-Sender-Via: server.nextmovesoftware.com: authenticated_id: roger@nextmovesoftware.com X-Authenticated-Sender: server.nextmovesoftware.com: roger@nextmovesoftware.com X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" My recently added testcase gcc.dg/fold-eqandshift-4.c, incorrectly assumed that "char" was "signed char", and hence fails on powerpc64 where this isn't the case. Fixed by making "signed char" explicit where needed in this test. Committed as obvious. 2022-08-10 Roger Sayle gcc/testsuite/ChangeLog * gcc.dg/fold-eqandshift-4.c: Use "signed char" explicitly. Apologies for the inconvenience. Roger diff --git a/gcc/testsuite/gcc.dg/fold-eqandshift-4.c b/gcc/testsuite/gcc.dg/fold-eqandshift-4.c index 42d5190703e..fbba438556e 100644 --- a/gcc/testsuite/gcc.dg/fold-eqandshift-4.c +++ b/gcc/testsuite/gcc.dg/fold-eqandshift-4.c @@ -1,14 +1,14 @@ /* { dg-do compile } */ /* { dg-options "-O2 -fdump-tree-optimized" } */ -int sr30eq00(char x) { return ((x >> 4) & 0x30) == 0; } -int sr30ne00(char x) { return ((x >> 4) & 0x30) != 0; } -int sr30eq20(char z) { return ((z >> 4) & 0x30) == 0x20; } -int sr30ne20(char z) { return ((z >> 4) & 0x30) != 0x20; } -int sr30eq30(char x) { return ((x >> 4) & 0x30) == 0x30; } -int sr30ne30(char x) { return ((x >> 4) & 0x30) != 0x30; } -int sr33eq33(char x) { return ((x >> 4) & 0x33) == 0x33; } -int sr33ne33(char x) { return ((x >> 4) & 0x33) != 0x33; } +int sr30eq00(signed char x) { return ((x >> 4) & 0x30) == 0; } +int sr30ne00(signed char x) { return ((x >> 4) & 0x30) != 0; } +int sr30eq20(signed char z) { return ((z >> 4) & 0x30) == 0x20; } +int sr30ne20(signed char z) { return ((z >> 4) & 0x30) != 0x20; } +int sr30eq30(signed char x) { return ((x >> 4) & 0x30) == 0x30; } +int sr30ne30(signed char x) { return ((x >> 4) & 0x30) != 0x30; } +int sr33eq33(signed char x) { return ((x >> 4) & 0x33) == 0x33; } +int sr33ne33(signed char x) { return ((x >> 4) & 0x33) != 0x33; } int ur30eq00(unsigned char z) { return ((z >> 4) & 0x30) == 0; } int ur30ne00(unsigned char z) { return ((z >> 4) & 0x30) != 0; }