From patchwork Fri Jul 15 14:53:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Ball X-Patchwork-Id: 56097 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 359333857400 for ; Fri, 15 Jul 2022 14:54:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 359333857400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1657896888; bh=gTdIxWj1/8IhSH2fdKOzaAClwItY9wlx+DglRPAFCh4=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=xWrsdn1T01EFBCfVbgP2/CmZZIszqi/T91yBdgOA9ojcWaS/+xwL45WjFHHHus0gv gKsbP1bhbKyts43SC0TOZkSW3VeqmLeBXeJ4VMUIpQuNc55CjNjT0Y9lb0wgZIRqDq AMwrHq63OtMzaipL4P+wrzf8AHMO6V4MKygQver0= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2059.outbound.protection.outlook.com [40.107.20.59]) by sourceware.org (Postfix) with ESMTPS id C07053857BBD for ; Fri, 15 Jul 2022 14:54:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C07053857BBD ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bQIv3F6UC0HX+yZaX7zEuI8H1stE8i2GpoYYJpYEcwC1BQZf6Irbrc2/LEqoQLlrw3R6TXTJ3PZZzmBdBQTTRDNOfdjLNKIQG4jPrp8Ro85wNyOQSHF9sjPMYXvVuyi4Zq2tvRBFRhpjcltJ/zIKmBlq0dt2Fw+zZCUg44YoIa4fdJzRgSGpVv8GLp1PCCetl0RDcSjJCobVDHABOdUZo6GTctCUIEJzmo+MitJQqZ2O+AiK4OwJeLdHYRhvR5QXkAY9rTzTXSGTWmydbMjVth6KWDAJ4Y7vvPm1dokE2ULbkdGKTxOcYesRbrsmY9hs8aDhXitbPkUYHrIweRtMxQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gTdIxWj1/8IhSH2fdKOzaAClwItY9wlx+DglRPAFCh4=; b=cMIz3DndgjGhG57BKxkw8161wuP8vyWfP9HsCBrvajz1ZiKDLIdqtiPNxyFzCmZ+yh/y/AGshHsN2xhinwa9Y0mozcH7lsDZgwhJsu/DBBDbCPHN62PiCAAN6DByVEccycJr+1pKmvXiGABkB81RtRJW/21qh+KN0CoX+MSQJVf2yRFrOX+FiwB3hV1B7gnXZx/Qp43G8B5/WKDwsllmuyDNWPPLCG0aJFwA6H/MT15hbDVHTo/ZSzMaAGhnbJIWNeOm0N+pfxt4vj8uI4g385+vrGNny+KH1FpkPDMk1c2c9v5AJes0n60Fd602iQID/d/itwX4zF6lJDCaJMJeiw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AM6P191CA0054.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::31) by DBBPR08MB4790.eurprd08.prod.outlook.com (2603:10a6:10:f4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Fri, 15 Jul 2022 14:54:14 +0000 Received: from AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::80) by AM6P191CA0054.outlook.office365.com (2603:10a6:209:7f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.11 via Frontend Transport; Fri, 15 Jul 2022 14:54:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT021.mail.protection.outlook.com (10.152.16.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Fri, 15 Jul 2022 14:54:13 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Fri, 15 Jul 2022 14:54:13 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7091662df482c0a4 X-CR-MTA-TID: 64aa7808 Received: from a63d3ad8c288.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5C1C84B7-DD53-4C76-9F4A-2F060FB8ED93.1; Fri, 15 Jul 2022 14:54:02 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a63d3ad8c288.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 15 Jul 2022 14:54:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eJRLt4tGTicLD9S79lVjTuu6T3rN9/0UVAzfoPB5x1QmqXpZ91E6Hm6a2vooSF8xkFlad5kwsDZIumEddRBnzdrGeymvoOoZyLXGV9SHMXxoXnlaf15xtuOOfv72t28eJWjsIvvl2xkKN8FA8l/vSp5vRxVm+e1zIlUyjvoTY+YjHUQGNkc6qcwtD1dK8ZNSOiVChDtws2i5ayXdzzexarhFAjxOxqmfjVJrLDV12c4I6eUB8jDxrQnb2eZXi6zikdJKoZ29EVz+bp2QJwaeyAQD/asZdkEkCs9IoAUpYW6wulIrIevhZRgXPA32V31R83DeZ8HQ3u8hmSwZ8EQTGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gTdIxWj1/8IhSH2fdKOzaAClwItY9wlx+DglRPAFCh4=; b=ejJDJyk/NIYPXt/QGA+Q6xo8EoZLYV3DuXoQjq85VCyUVH4gaxXsm7WgAH3CDs4WSr3YCQd4ZkbH6+QRkEAHnQSqSqDx48z0g93A6pWuuhRb/a0TF27RiAvrOBFLUlBp5wXxl73wQx7Yav4yZQtp5+lzao/SnanO6b0ywba6IIMLQ4R1fQFf+NpaZ7qJgXfsJECIdiB6YGJERVJmRw0Gb57E1zsjQ0+4ehtLeqq4L56hSeUuxpH6zTfgkoUctLUnTV0honcp3WndeL7hUA0s3bJXY3wyy65tS3UCD4cFgUOCBf7D/gTUowrYR9T5gXl81Qn1MbcJj87DmRs/Ob50mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB6957.eurprd08.prod.outlook.com (2603:10a6:10:2bc::10) by VI1PR0802MB2622.eurprd08.prod.outlook.com (2603:10a6:800:b0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Fri, 15 Jul 2022 14:53:59 +0000 Received: from DB9PR08MB6957.eurprd08.prod.outlook.com ([fe80::85cc:f440:1b09:5a7f]) by DB9PR08MB6957.eurprd08.prod.outlook.com ([fe80::85cc:f440:1b09:5a7f%5]) with mapi id 15.20.5438.015; Fri, 15 Jul 2022 14:53:59 +0000 Message-ID: Date: Fri, 15 Jul 2022 15:53:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: gcc-patches@gcc.gnu.org Subject: [PATCH] aarch64: Replace manual swapping idiom with std::swap in aarch64.cc X-ClientProxiedBy: LO4P123CA0530.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::13) To DB9PR08MB6957.eurprd08.prod.outlook.com (2603:10a6:10:2bc::10) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: ea8254e5-3ba2-4f07-c1b3-08da6671e230 X-MS-TrafficTypeDiagnostic: VI1PR0802MB2622:EE_|AM5EUR03FT021:EE_|DBBPR08MB4790:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PonAcBYNopBCUHsuY4VwgoIwvLRTCQNtSWRvavC0o4wx38dT5NSR+shU8fF59i4nUyyPFk20Xh3kIONiKbfkkosH7qg6u77McZFuHAOYRYs5Tj+kcccvGaQqw9adW8729eV+UTm4SJQjG3g+7VnmPJWApG8KVJLg+XV7XxSa26EF3aPTvYCi86XHZqnQ/E5MDoST9H4b3FOaINc+IM41NalgEo6yo5YXDZkJWEvppkcdBfD1NVLOpWNtIQeQJn7+WCW++PdMV921qx4ZNvZ7BavoZYTynWIIIk94Pn70jwgp5aRG9QUuVU18YjT+5AP+qK1aXU064AKkx9BCoshSI8Tspl1/b5ZljPX+51g3mQsGsWEXsAglNExWlGUqWGdN0GHyggRp5RkUHYUFfsyURYjqJNfew5VllonzX2MgN+NgpInzht5GTwhqS6N2YVsucGPT9NA8A9SsAi3lO+8T753LoWe1lLBEBzvc1DpprQSFxMCIdGQJ+Ti9qSvnWvoGdCBbfgn4ridbuO8f9yXXLxCVh0iMuMMv9ave1B5timyGk7UupRcf1Ei/Bm+R9St1KhOJYoFqEuSJxZKCHYEermGelo/nctf8XVneQPdwMonQe78xKCqE56m3AF1ILz0jaa/rJhM4hOKwdm08AYR+tHsbOL+CGqxU20qIvZCQ+4qko923As4MZRr9Ay3eaNh5AXyV5dp3uqmq7WBKf7W4e28H4XKzsDFP+KLqoh3cbzRC5Gc9uK5dgU8QD6TEDuL2Zp8q+hzpaI2zvdYtPnMb1sJbAlDCEa6kIjIvwKaNYiQUt+T7/4LJjWRzJrvvkOm5t1mu2jXr/aytqyWimfQMlg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB6957.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(346002)(39860400002)(136003)(366004)(396003)(6486002)(36756003)(6506007)(31686004)(6512007)(6916009)(26005)(316002)(6666004)(41300700001)(478600001)(66476007)(8676002)(4326008)(2616005)(66946007)(38100700002)(31696002)(66556008)(44832011)(8936002)(5660300002)(86362001)(2906002)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2622 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d237cfee-5b17-4edf-6ea9-08da6671d97f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MX8E3Ce132HDw2XjJ5SuZtaLDJ0MpUwCCC8dA8TJxA5jyf13nlx2e0/RjryWyAs/FiUKRW8/qPFcVofycn7fof653LGKL80JZPprLdKLvFOcV+0PgJ1ixJsrus935wMfcjrjqoxQ+rH69pUrStlAz0iduS5uWsz3Bd5scYDYwe+tPC/5Ly0IQqRBDCGDMDIRLugfFBoWVaNBIMebadIzLWMBdzUbubwM/MQeHX3D7rvdU9lUsAmzzF9ak0+BcgeCnIkRad6mUtGvyr+QTd8x7JKeNDsm6W4KBQYIbmJRzVJX0eM5p3GWpYWZGCt3/xgzAweHJwhiAloWBZY4cFz3M8dbvTicBvw+sQIZKp0daTEPRZ/G9NEguvn6/L9ykD/48zWde+73Jbmz728LROW9LoL3Kf27M/1ygkuAoNVfRtSlkan7XZJ3WBdkxOU2zbmAbGPL2Iy46fEX19m9kPmE4eCHS+4JKReorvO0w0DY3Lr3UoCgiauW/Hl+ePvJn/jo/XJJNYgo7TBtftPO7kUyBgoJ4r3mbQJVJuaHBHQtTs1jJbTDBQ7MWY8FpITboKy5l+uFOj2wQRWCyBBsGGEnk3+6rUPz/VozezTzzRMFUF6E6TRd9j+rECX7pD9LpbfXRh8zRE6Ps1mNMRhTZNcTil0m4Te1VKeR+/IRCjSBYaa7IpWG74SlLa9AOC/vTUXoCCPLgtSI/SNgWwcgztEj8LVpW7Y1RD3w/u6hdXN+nuaXBVsYbTLEbv2mwZuVYA7Nm9ES0CtOTeK/8DGW8OSuIkdKoBEXhFJmby7gQ7jsGV6SQt0zP1cSQGS/8jFFLOl03ZNyidRDy3JvpA+Q4/CSgH8JdCOkMZxRwLk2FXHpcKg= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(376002)(346002)(136003)(396003)(40470700004)(46966006)(36840700001)(186003)(47076005)(478600001)(6506007)(40480700001)(356005)(26005)(6666004)(40460700003)(2616005)(31696002)(41300700001)(8676002)(82740400003)(6512007)(81166007)(336012)(36756003)(36860700001)(4326008)(2906002)(44832011)(8936002)(31686004)(86362001)(5660300002)(70206006)(6916009)(70586007)(316002)(82310400005)(6486002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 14:54:13.8061 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ea8254e5-3ba2-4f07-c1b3-08da6671e230 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4790 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Ball via Gcc-patches From: Richard Ball Reply-To: Richard Ball Cc: richard.earnshaw@arm.com, marcus.shawcroft@arm.com, richard.sandiford@arm.com Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Replace manual swapping idiom with std::swap in aarch64.cc gcc/config/aarch64/aarch64.cc has a few manual swapping idioms of the form: x = in0, in0 = in1, in1 = x; The preferred way is using the standard: std::swap (in0, in1); We should just fix these to use std::swap. This will also allow us to eliminate the x temporary rtx. gcc/ChangeLog: * config/aarch64/aarch64.cc (aarch64_evpc_trn): Use std:swap. (aarch64_evpc_uzp): Likewise. (aarch64_evpc_zip): Likewise. diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc index d049f9a9819628a73bfd57114c3b89d848da7d9c..b75a032c2f2c55d71bcb6b4b6ef1bd7f42a97235 100644 --- a/gcc/config/aarch64/aarch64.cc +++ b/gcc/config/aarch64/aarch64.cc @@ -23498,7 +23498,7 @@ aarch64_evpc_trn (struct expand_vec_perm_d *d) { HOST_WIDE_INT odd; poly_uint64 nelt = d->perm.length (); - rtx out, in0, in1, x; + rtx out, in0, in1; machine_mode vmode = d->vmode; if (GET_MODE_UNIT_SIZE (vmode) > 8) @@ -23522,7 +23522,7 @@ aarch64_evpc_trn (struct expand_vec_perm_d *d) at the head of aarch64-sve.md for details. */ if (BYTES_BIG_ENDIAN && d->vec_flags == VEC_ADVSIMD) { - x = in0, in0 = in1, in1 = x; + std::swap (in0, in1); odd = !odd; } out = d->target; @@ -23592,7 +23592,7 @@ static bool aarch64_evpc_uzp (struct expand_vec_perm_d *d) { HOST_WIDE_INT odd; - rtx out, in0, in1, x; + rtx out, in0, in1; machine_mode vmode = d->vmode; if (GET_MODE_UNIT_SIZE (vmode) > 8) @@ -23615,7 +23615,7 @@ aarch64_evpc_uzp (struct expand_vec_perm_d *d) at the head of aarch64-sve.md for details. */ if (BYTES_BIG_ENDIAN && d->vec_flags == VEC_ADVSIMD) { - x = in0, in0 = in1, in1 = x; + std::swap (in0, in1); odd = !odd; } out = d->target; @@ -23631,7 +23631,7 @@ aarch64_evpc_zip (struct expand_vec_perm_d *d) { unsigned int high; poly_uint64 nelt = d->perm.length (); - rtx out, in0, in1, x; + rtx out, in0, in1; machine_mode vmode = d->vmode; if (GET_MODE_UNIT_SIZE (vmode) > 8) @@ -23656,7 +23656,7 @@ aarch64_evpc_zip (struct expand_vec_perm_d *d) at the head of aarch64-sve.md for details. */ if (BYTES_BIG_ENDIAN && d->vec_flags == VEC_ADVSIMD) { - x = in0, in0 = in1, in1 = x; + std::swap (in0, in1); high = !high; } out = d->target;