From patchwork Tue Jul 12 19:11:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Prathamesh Kulkarni X-Patchwork-Id: 55978 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8E48238460B3 for ; Tue, 12 Jul 2022 19:12:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8E48238460B3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1657653133; bh=Yt2MAStNlQZpkpLMRPyrnzlPIe8/YwGsrm1QCZ36EEM=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=YeXW+pbtk7DYpahrer44aRltW1tnWCQsfMD4TAmMip/VG0bEYmScSiNuD20BDUDFZ IBe2L3C+N+lAPSqGT1rWYQsPbn6nvWkz7oemHopy2RJ8wlvGExMUeK11z+ZnpkPYB7 zvFvjE3HozbHamupNlUisMznjlZ/eLhF92DW97BE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 28E853857C7D for ; Tue, 12 Jul 2022 19:11:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 28E853857C7D Received: by mail-ed1-x52b.google.com with SMTP id r18so11322038edb.9 for ; Tue, 12 Jul 2022 12:11:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Yt2MAStNlQZpkpLMRPyrnzlPIe8/YwGsrm1QCZ36EEM=; b=PFqiymGj/78iTySHInZM3/bW2zAYsh4oaHxkZUBs80/2uci7d4Foyg2G2pSPQVsSBT Q34hKrK6F9u/nJvrFGzAK7SppgO5hwAFiXr8BwZdaINcPyUiYIgtkiZBZAuCpFYGOPwi 4rj4uXAIw53cojwop0AXaZZmAm7fp644s2v6dKU7Fx2zBGjuZPwkhmqdofpcuvGEPN2+ ZZCduTenf6c2nMJq5RX7fOeC61mnr3gBPAx3s1SzBDcgaAzOICgN/i4YP+AWEAUIhgwV Sy4PbXivnbOaUciqKQqQYFkkZBoIpN23F0BMQpRECEV5+PpF8eLNozal+YfJo2+d20gc PhCg== X-Gm-Message-State: AJIora+Mv5GTBNt8kx0y9xsk89qRDRINftBj4ag4bHz7iZPZ7QdnE1PG 61E1gdaUhk8dJ7V69zgN5T/kY2VAUlb0MYkcH/15zqm/ecmtfYbT X-Google-Smtp-Source: AGRyM1tcNELIcOhPyAI85JfR7fpyrijmw4go7ZOBxOMelXDqkKpK1zGCb3nROk0j7OXH/n68ySRVrDEnE8rVRFbbV+A= X-Received: by 2002:a05:6402:3807:b0:435:20fb:318d with SMTP id es7-20020a056402380700b0043520fb318dmr33355494edb.272.1657653101504; Tue, 12 Jul 2022 12:11:41 -0700 (PDT) MIME-Version: 1.0 Date: Wed, 13 Jul 2022 00:41:04 +0530 Message-ID: Subject: ICE after folding svld1rq to vec_perm_expr duing forwprop To: gcc Patches , Richard Sandiford X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Prathamesh Kulkarni via Gcc-patches From: Prathamesh Kulkarni Reply-To: Prathamesh Kulkarni Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi Richard, For the following test: svint32_t f2(int a, int b, int c, int d) { int32x4_t v = (int32x4_t) {a, b, c, d}; return svld1rq_s32 (svptrue_b8 (), &v[0]); } The compiler emits following ICE with -O3 -mcpu=generic+sve: foo.c: In function ‘f2’: foo.c:4:11: error: non-trivial conversion in ‘view_convert_expr’ 4 | svint32_t f2(int a, int b, int c, int d) | ^~ svint32_t __Int32x4_t _7 = VIEW_CONVERT_EXPR<__Int32x4_t>(_8); during GIMPLE pass: forwprop dump file: foo.c.109t.forwprop2 foo.c:4:11: internal compiler error: verify_gimple failed 0xfda04a verify_gimple_in_cfg(function*, bool) ../../gcc/gcc/tree-cfg.cc:5568 0xe9371f execute_function_todo ../../gcc/gcc/passes.cc:2091 0xe93ccb execute_todo ../../gcc/gcc/passes.cc:2145 This happens because, after folding svld1rq_s32 to vec_perm_expr, we have: int32x4_t v; __Int32x4_t _1; svint32_t _9; vector(4) int _11; : _1 = {a_3(D), b_4(D), c_5(D), d_6(D)}; v_12 = _1; _11 = v_12; _9 = VEC_PERM_EXPR <_11, _11, { 0, 1, 2, 3, ... }>; return _9; During forwprop, simplify_permutation simplifies vec_perm_expr to view_convert_expr, and the end result becomes: svint32_t _7; __Int32x4_t _8; ;; basic block 2, loop depth 0 ;; pred: ENTRY _8 = {a_2(D), b_3(D), c_4(D), d_5(D)}; _7 = VIEW_CONVERT_EXPR<__Int32x4_t>(_8); return _7; ;; succ: EXIT which causes the error duing verify_gimple since VIEW_CONVERT_EXPR has incompatible types (svint32_t, int32x4_t). The attached patch disables simplification of VEC_PERM_EXPR in simplify_permutation, if lhs and rhs have non compatible types, which resolves ICE, but am not sure if it's the correct approach ? Alternatively, should we allow assignments from fixed-width to SVE vector, so the above VIEW_CONVERT_EXPR would result in dup ? Thanks, Prathamesh diff --git a/gcc/tree-ssa-forwprop.cc b/gcc/tree-ssa-forwprop.cc index 69567ab3275..be888f1c48e 100644 --- a/gcc/tree-ssa-forwprop.cc +++ b/gcc/tree-ssa-forwprop.cc @@ -2414,6 +2414,9 @@ simplify_permutation (gimple_stmt_iterator *gsi) if (TREE_CODE (op2) != VECTOR_CST) return 0; + if (!types_compatible_p (TREE_TYPE (gimple_get_lhs (stmt)), TREE_TYPE (op0))) + return 0; + if (TREE_CODE (op0) == VECTOR_CST) { code = VECTOR_CST;