From patchwork Thu Jul 7 16:49:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: fche at redhat dot com X-Patchwork-Id: 55851 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 20DDC385C402 for ; Thu, 7 Jul 2022 16:49:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20DDC385C402 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1657212544; bh=N+H0kNoRlML5AzFEqUpc5ncopIWdTj1FvNshBp2iSJE=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:From; b=MipEzZ14MFKdhzN99rn4SXI8hTKwoM8jG1gZhx91/ZImSz1yTwzORIIASbwjumSGT zgpOFO0qk9J4g66gSLMI3nxHOlJ/gJATgguBzrgCkg66gI5LrDsQsH2P3ehNhqE35H 7jw9N1LGayz+cwScM4XmyhRgkR26dDYMFJk/Vur4= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: by sourceware.org (Postfix, from userid 48) id 6EA9C3857410; Thu, 7 Jul 2022 16:49:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6EA9C3857410 To: libabigail@sourceware.org Subject: [Bug default/29302] xeres-c doesn't self compare Date: Thu, 07 Jul 2022 16:49:01 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: woodard at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: woodard at redhat dot com via Libabigail From: fche at redhat dot com Reply-To: woodard at redhat dot com Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" https://sourceware.org/bugzilla/show_bug.cgi?id=29302 --- Comment #3 from Ben Woodard --- The prototype patch seems to fix the problem with xerces-c, qt-virt-manager However it didn't seem to fix the problem with recoll which I would have classified in the same problem. I'm really not sure if that means that recoll has a different problem or if the solution is incomplete. $ fedabipkgdiff --self-compare -a --from fc36 recoll ======== comparing'librecoll-1.31.6.so' to itself wrongly yielded result: =========== Functions changes summary: 0 Removed, 2 Changed (46 filtered out), 0 Added functions Variables changes summary: 0 Removed, 0 Changed, 0 Added variable 2 functions with some indirect sub-type change: [C] 'method MimeHandlerExec::MimeHandlerExec(RclConfig*, const std::string&)' at mh_exec.cpp:64:1 has some indirect sub-type changes: implicit parameter 0 of type 'MimeHandlerExec*' has sub-type changes: in pointed to type 'class MimeHandlerExec' at mh_exec.h:46:1: type size hasn't changed 1 base class change: 'class RecollFilter' at mimehandler.h:31:1 changed: type size hasn't changed 10 member function insertions: 'method virtual void RecollFilter::set_docsize(int64_t)' at mimehandler.h:82:1, virtual at voffset 9/21 'method virtual bool RecollFilter::set_document_data(const std::string&, const char*, size_t)' at mimehandler.h:78:1, virtual at voffset 5/21 'method virtual bool RecollFilter::set_document_file(const std::string&, const std::string&)' at mimehandler.h:68:1, virtual at voffset 7/21 'method virtual bool RecollFilter::set_document_string(const std::string&, const std::string&)' at mimehandler.h:73:1, virtual at voffset 6/21 'method virtual bool RecollFilter::set_document_uri(const std::string&, const std::string&)' at mimehandler.h:63:1, virtual at voffset 8/21 'method virtual bool RecollFilter::set_property(Dijon::Filter::__anonymous_enum__1, const std::string&)' at mimehandler.h:44:1, virtual at voffset 4/21 'method virtual bool RecollFilter::skip_to_document(const std::string&)' at mimehandler.h:95:1, virtual at voffset 12/21 'method virtual RecollFilter::~RecollFilter(int)' at mimehandler.h:36:1 'method virtual RecollFilter::~RecollFilter(int)' at mimehandler.h:36:1 'method virtual RecollFilter::~RecollFilter(int)' at mimehandler.h:36:1 8 member function changes (7 filtered): 'method virtual RecollFilter::~RecollFilter(int)' has some sub-type changes: 'method virtual void RecollFilter::setConfig(RclConfig*)' has some sub-type changes: 'method virtual bool RecollFilter::set_property(Dijon::Filter::__anonymous_enum__1, const std::string&)' has some sub-type changes: 'method virtual bool RecollFilter::set_document_data(const std::string&, const char*, size_t)' has some sub-type changes: 'method virtual bool RecollFilter::set_document_string(const std::string&, const std::string&)' has some sub-type changes: 'method virtual void RecollFilter::set_docsize(int64_t)' has some sub-type changes: 'method virtual bool RecollFilter::skip_to_document(const std::string&)' has some sub-type changes: 'method virtual void RecollFilter::clear()' has some sub-type changes: no member function changes (7 filtered); [C] 'method virtual bool MimeHandlerExecMultiple::next_document()' at mh_execm.cpp:169:1 has some indirect sub-type changes: implicit parameter 0 of type 'MimeHandlerExecMultiple*' has sub-type changes: in pointed to type 'class MimeHandlerExecMultiple' at mh_execm.h:98:1: type size hasn't changed 1 base class change: 'class MimeHandlerExec' at mh_exec.h:46:1 changed: details were reported earlier 2 member function insertions: 'method virtual MimeHandlerExecMultiple::~MimeHandlerExecMultiple(int)' at mh_execm.h:109:1 'method virtual MimeHandlerExecMultiple::~MimeHandlerExecMultiple(int)' at mh_execm.h:109:1 no member function changes (5 filtered); ===SELF CHECK FAILED for 'librecoll-1.31.6.so' ==== SELF CHECK SUCCEEDED for 'recoll' ==== ==== SELF CHECK SUCCEEDED for 'recollindex' ==== ==== SELF CHECK SUCCEEDED for 'recollq' ==== Let me know if you want to close this one and have me file another one or if you want to address both issues in this one bug report diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc index 32a2cead..b71e94d7 100644 --- a/src/abg-dwarf-reader.cc +++ b/src/abg-dwarf-reader.cc @@ -14987,7 +14987,7 @@ build_function_decl(read_context& ctxt, result->set_symbol(fn_sym); string linkage_name = result->get_linkage_name(); if (linkage_name.empty() - || !fn_sym->get_alias_from_name(linkage_name)) + /*|| !fn_sym->get_alias_from_name(linkage_name)*/) result->set_linkage_name(fn_sym->get_name()); result->set_is_in_public_symbol_table(true); }