From patchwork Tue Jun 28 10:00:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 55478 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BA91E38356AA for ; Tue, 28 Jun 2022 10:01:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BA91E38356AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1656410466; bh=dyR36d1aaT4ESkW00YA2Vg2+y7C+w3htc+yJcX+mlbw=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=fRAyQqofGZPUHxqYJyXht1PRgsWwPGMynJ9GypwOURHQ8i/cNTYnlRe7onecg/zca WtT850cKu4Bx7O2QN2OOQ8Yvn4JjqfGWcIrN1aBckdk3X2bsJSXS8/EIQahOAbGYlq 3kxw6N5fjqt5bfWFqybjrvrC3L5rAugsMaQkbu5w= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id B0324383D824 for ; Tue, 28 Jun 2022 10:00:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B0324383D824 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 787B421CD1 for ; Tue, 28 Jun 2022 10:00:06 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 734312C141 for ; Tue, 28 Jun 2022 10:00:06 +0000 (UTC) Date: Tue, 28 Jun 2022 10:00:06 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH] middle-end/106053 - fold_sign_changed_comparison and large bools User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Message-Id: <20220628100106.BA91E38356AA@sourceware.org> The following fixes a latent issue in the match.pd variant of fold_sign_changed_comparison which replaces an unsigned integer comparison with a signed boolean comparison of the same precision despite the fact that we treat BOOLEAN_TYPEs as only having two valid values. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed to trunk sofar. 2022-06-28 Richard Biener PR middle-end/106053 * match.pd ((T)a == (T)b): Avoid folding away sign changes in a comparison if we'd truncate to a boolean. * gcc.target/i386/pr106053.c: New testcase. --- gcc/match.pd | 7 ++++- gcc/testsuite/gcc.target/i386/pr106053.c | 37 ++++++++++++++++++++++++ 2 files changed, 43 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr106053.c diff --git a/gcc/match.pd b/gcc/match.pd index 24cbbbb5bc1..c43c528424e 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -5542,7 +5542,12 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) && (TYPE_UNSIGNED (TREE_TYPE (@00)) == TYPE_UNSIGNED (TREE_TYPE (@0)) || cmp == NE_EXPR || cmp == EQ_EXPR) - && !POINTER_TYPE_P (TREE_TYPE (@00))) + && !POINTER_TYPE_P (TREE_TYPE (@00)) + /* (int)bool:32 != (int)uint is not the same as + bool:32 != (bool:32)uint since boolean types only have two valid + values independent of their precision. */ + && (TREE_CODE (TREE_TYPE (@00)) != BOOLEAN_TYPE + || TREE_CODE (TREE_TYPE (@10)) == BOOLEAN_TYPE)) /* ??? The special-casing of INTEGER_CST conversion was in the original code and here to avoid a spurious overflow flag on the resulting constant which fold_convert produces. */ diff --git a/gcc/testsuite/gcc.target/i386/pr106053.c b/gcc/testsuite/gcc.target/i386/pr106053.c new file mode 100644 index 00000000000..69baa3e5fd1 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr106053.c @@ -0,0 +1,37 @@ +/* { dg-do run { target lp64 } } */ +/* { dg-options "-O -fno-tree-fre -w -mno-avx" } */ + +typedef unsigned __attribute__((__vector_size__ (32))) v256u8; +typedef unsigned __attribute__((__vector_size__ (64))) v512u8; +typedef unsigned short u16; +typedef unsigned int u32; +typedef unsigned long long u64; +typedef unsigned long __attribute__((__vector_size__ (64))) v512u64; +typedef unsigned __int128 __attribute__((__vector_size__ (32))) v256u128; +unsigned u; +v512u64 foo0_v512u64_0; + +static inline v256u8 +foo (u32 u32_0, u64 u64_0, v256u128 v256u128_0) +{ + int o = __builtin_add_overflow_p (u64_0, 0, 0); + v512u64 v512u64_1 = + foo0_v512u64_0 & (u32) __builtin_sub_overflow_p (0, o, 0); + u64_0 |= u; + v256u128 v256u128_2 = u64_0 < v256u128_0; + v256u128 v256u128_3 = -v256u128_2 == u64_0 * u32_0; + v256u8 v256u8_r = ((union { + v512u8 a; v256u8 b[2]; + }) (v512u8) v512u64_1).b[0] + (v256u8) v256u128_3; + return v256u8_r; +} + +int +main (void) +{ + v256u8 x = foo (3095179400, 23725760132, (v256u128) { 2, 2 }); + for (unsigned i = 0; i < sizeof (x) / sizeof (x[0]); i++) + if (x[i]) + __builtin_abort (); + return 0; +}