From patchwork Mon Jun 20 15:23:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 55196 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 93F183851AA7 for ; Mon, 20 Jun 2022 15:24:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 93F183851AA7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1655738640; bh=skWLTAQUIr4HFLQtAwEukz0wX0L9F1ryI+QU4zap47A=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=AyYJhc5DZs1Mko1/IyWMT+h6J3F6bu0X/4CiFLtWaFyHaAXScCzSui9vTPeLzHyqR yVjR2xwCfgIHM/yiWzTu4/gs6BZiIuuBIiC5l91O+khemLKAeTGZ/d0NbsWj/BKCNw wV/4nxNXIumZOzs69rOUwuteNaUUg9e/5VaeQE9U= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0AB7D384D1B3 for ; Mon, 20 Jun 2022 15:23:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0AB7D384D1B3 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-38-HXJRgzEgM-2SEcnjeobSCw-1; Mon, 20 Jun 2022 11:23:43 -0400 X-MC-Unique: HXJRgzEgM-2SEcnjeobSCw-1 Received: by mail-qk1-f200.google.com with SMTP id u8-20020a05620a454800b006a74e6b39eeso13346794qkp.12 for ; Mon, 20 Jun 2022 08:23:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:organization:date:message-id :user-agent:mime-version; bh=skWLTAQUIr4HFLQtAwEukz0wX0L9F1ryI+QU4zap47A=; b=ZYJKMAU6KDxSXl8j3f0RGi71RKpPz1hb6yUCsHCQlhUMgmAQ6tNXOzpZk1+i0i55ik 9IPVbrbE1tbFdk3uwh6EoNtmdsZ5f0cUtsmaneU0QNxa+KgqQAoZsgZF0iOkWh6XLzOw 1InrkUhAp4imQoda+/rTjyLkwt49c0tA6yXdrwzD3gr/i3xB2EY1oyk2PFELsAmZ96pr 9zCYVEUzd+bPbRNjddoVc8BkWWWAi9gy11mDLzU8h00dv/rZ17UOu9opNcRKcoeL2WIQ gtCD06p0eNOynG1/d0EZJrhZROetg8Aq9AsvR9g6iJUxEwFOpTgJ6W4HsUgYHcV225JU h6BA== X-Gm-Message-State: AJIora87YIwErKbX9APiYwurrez+X3LArJmLiDpKVTsiHrkTpOWzZkRU EPjEdHZBL+9Uq2dLfyVu3s1829NdjWBjPWippNo4xVtyjPUd6Q9HbY9i1NfUQyyUuVbmlW5IZNP 5vUXf1maeLvY1OjrEEEylWX5Nf4rRQ5A02X+8PlKGrp5BxGMCfyIUGtNUqenIui3tKMBu X-Received: by 2002:ad4:5907:0:b0:470:4b8d:2898 with SMTP id ez7-20020ad45907000000b004704b8d2898mr1771341qvb.91.1655738622784; Mon, 20 Jun 2022 08:23:42 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ubciFdpAHL6wdvoN+O1tzWWaxDb3vl0nCykAd4w7ErUkLWIiBHUutHpNw2YRqvr30tDFCzYw== X-Received: by 2002:ad4:5907:0:b0:470:4b8d:2898 with SMTP id ez7-20020ad45907000000b004704b8d2898mr1771329qvb.91.1655738622518; Mon, 20 Jun 2022 08:23:42 -0700 (PDT) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id d84-20020a376857000000b006a77e6df09asm11318056qkc.24.2022.06.20.08.23.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jun 2022 08:23:42 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 874995800FC; Mon, 20 Jun 2022 17:23:40 +0200 (CEST) To: libabigail@sourceware.org Subject: [PATCH, applied] dwarf-reader: compare_dies sometimes compares empty formal parms Organization: Red Hat / France X-Operating-System: Fedora 37 X-URL: http://www.redhat.com Date: Mon, 20 Jun 2022 17:23:40 +0200 Message-ID: <87sfnzgxz7.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, compare_dies sometimes compares uninitialized DIE structs, which leads to junk down the road. Fixed thus. * src/abg-dwarf-reader.cc (compare_dies): Don't try to compare formal parameters if there is none. Signed-off-by: Dodji Seketeli Applied to master. --- src/abg-dwarf-reader.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc index d43364f1..5cbf3e44 100644 --- a/src/abg-dwarf-reader.cc +++ b/src/abg-dwarf-reader.cc @@ -10634,9 +10634,10 @@ compare_dies(const read_context& ctxt, bool l_type_is_void = !die_die_attribute(l, DW_AT_type, l_type); bool r_type_is_void = !die_die_attribute(r, DW_AT_type, r_type); if ((l_type_is_void != r_type_is_void) - || !compare_dies(ctxt, &l_type, &r_type, - aggregates_being_compared, - update_canonical_dies_on_the_fly)) + || (!l_type_is_void + && !compare_dies(ctxt, &l_type, &r_type, + aggregates_being_compared, + update_canonical_dies_on_the_fly))) result = false; } break;