From patchwork Fri Jun 17 15:05:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 55171 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 92DB6386F0D5 for ; Fri, 17 Jun 2022 15:05:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 92DB6386F0D5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1655478346; bh=mcAxHrVstSzPbpBVYBMFNRgaWIL5hOd5vctpa/XPrSY=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=p8S6qlTaQtRjSQhTOSTIRwvMhmC50nAOiTtsXBguD8Ijz9iX8sEob7T/UIZqXwVRO IENRfqXCGLDyPb44CCjauobvuTlzc0oJYUzcmzBuA+qTas+j7d0p/9hQZVLUV5O3l4 azQxB61Ftz0XSr5wfvzn2ERhj2Lar2Dn030PuO+k= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by sourceware.org (Postfix) with ESMTPS id 3B6D23857B82 for ; Fri, 17 Jun 2022 15:05:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3B6D23857B82 Received: by mail-qk1-x734.google.com with SMTP id d128so3333964qkg.8 for ; Fri, 17 Jun 2022 08:05:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=mcAxHrVstSzPbpBVYBMFNRgaWIL5hOd5vctpa/XPrSY=; b=b3oyeD3ga/6jmOzLl2G3Xt+KW1gz3sihLh51OlMhbaMex+z8Furs9S93OmyeRb+CSF SrTnN6HSox2544C1jBAKH+o7twnrn37T3Zp5vvkgehMTLBWLgK7w9gtIe+aFU31WHLGg N3KP7Gdp8quss94r7F3mRrvD/4cn4VHcbY3j6B4bTLvfNqW9HxclFXwMZK95P0CFA2Ds J3Y8rETNc/SuRO6cYrXNP4xUP5JXlaePFurJOw50jT7Xgt4l1hP7xz2XLKO5aJqvduhQ zbFnPa0i/4P69ZoRrwIbXm9a333zQ0yXg3r/rlH9INMBp+E94Xd7ofQ6YBB8fLcGv5j1 eXcg== X-Gm-Message-State: AJIora/p/i0Dg+dixYASrn6NrFvBtIqYFRrPBJrAtLLkGMoTXAPnbFfv zbCdK8bAhnwNGbg3T4sLNtOP5bum5Lx9a6vxNTPccC0aQAXniw== X-Google-Smtp-Source: AGRyM1tPCLciEJEXfyqb+TfLVq0NppVQvq6RXLUcRClbgfOCGPzLJpKUHh32lxxXoRQCRdDoNDL9nym+TLJdoJWYUDY= X-Received: by 2002:a05:620a:4102:b0:6a7:7885:32eb with SMTP id j2-20020a05620a410200b006a7788532ebmr7362745qko.328.1655478316341; Fri, 17 Jun 2022 08:05:16 -0700 (PDT) MIME-Version: 1.0 Date: Fri, 17 Jun 2022 17:05:04 +0200 Message-ID: Subject: [PATCH] i386: Fix assert in ix86_function_arg [PR105970] To: "gcc-patches@gcc.gnu.org" X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Uros Bizjak via Gcc-patches From: Uros Bizjak Reply-To: Uros Bizjak Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" The mode of pointer argument should equal ptr_mode, not Pmode. 2022-06-17 Uroš Bizjak gcc/ChangeLog: PR target/105970 * config/i386/i386.cc (ix86_function_arg): Assert that the mode of pointer argumet is equal to ptr_mode, not Pmode. gcc/testsuite/ChangeLog: PR target/105970 * gcc.target/i386/pr105970.c: New test. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Pushed to master. Uros. diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc index 3d189e124e4..f158cc3aaea 100644 --- a/gcc/config/i386/i386.cc +++ b/gcc/config/i386/i386.cc @@ -3348,7 +3348,7 @@ ix86_function_arg (cumulative_args_t cum_v, const function_arg_info &arg) if (POINTER_TYPE_P (arg.type)) { /* This is the pointer argument. */ - gcc_assert (TYPE_MODE (arg.type) == Pmode); + gcc_assert (TYPE_MODE (arg.type) == ptr_mode); /* It is at -WORD(AP) in the current frame in interrupt and exception handlers. */ reg = plus_constant (Pmode, arg_pointer_rtx, -UNITS_PER_WORD); diff --git a/gcc/testsuite/gcc.target/i386/pr105970.c b/gcc/testsuite/gcc.target/i386/pr105970.c new file mode 100644 index 00000000000..326486faebf --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr105970.c @@ -0,0 +1,6 @@ +/* PR target/105970 */ +/* { dg-do compile { target { ! ia32 } } } */ +/* { dg-require-effective-target maybe_x32 } */ +/* { dg-options "-mx32 -mgeneral-regs-only -maddress-mode=long" } */ + +#include "../../gcc.dg/torture/pr68037-1.c"