From patchwork Tue Jun 7 17:23:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Carlotti X-Patchwork-Id: 54905 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4CF623948A79 for ; Tue, 7 Jun 2022 17:24:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4CF623948A79 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1654622684; bh=TW6y1zcu+m+3MFoMit7paf/vMURDPephpm1Y2NOfGOg=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=gPkEgXgLU2TMhlbb0MMSJjo6Xmhe/5JFXCoYP7uBwq3XA4tcsWR9KdXjzqBD79DLS OSukCPsfMtSBQwoaWwwLQjEhyND0z8G3GV43rl8qAUmDLRKCZQaaM7tGFC+wWA4V6K qcnRtq0bJQSkm/lWVtQ2Vblsijyxmy9c+gV2JazQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2065.outbound.protection.outlook.com [40.107.104.65]) by sourceware.org (Postfix) with ESMTPS id 604B9394BE17 for ; Tue, 7 Jun 2022 17:24:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 604B9394BE17 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nUQzG3KVFBXPWvp+uTYkkYBDrTXqfqnDa/Ou8bn69trFs6BtLcUmVEFhh/64m2DVgV5GwgPPtBhhGHZjHtKp34tmHVzAcGU/AxnEyau+PaFV2cii0geBc41xwDBxG3u8aYMeECgis8yZFIcuL68PHQQTpKXzR3R5dAOCCqQDOHlAvMROA52bScgN+lwK1b3UgPYjim2yuR1dM7a9DP94z2yWO4nvoyjIpqYExOBVVt2u7OvyOJvNByv1qKGB2jKTqyUgyKrwzhEmKC3D1uolt2MnTrdLKwtOVBfDGdvJGDNEcYkqnDVFptdaKdsmQ0TpbvLGNSyW2yY/aLJZA8CEPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TW6y1zcu+m+3MFoMit7paf/vMURDPephpm1Y2NOfGOg=; b=huALMPQT1NR70/DWcQOp1UCLU3SRN55nYrmvRR6HDh4BeojWrGqsnLEe5g9AoE/GsMDWYczzx6q3bCRzR9CIRx/SPK1UgJs3maknUEiu1Q3zki13tvS2DhbSI6th99glSEAaC/VG/0BwsMNWtLK/LeSdIZ+qTArhdWA1XUzEKPYe9NW74eAfee0QCnjdieEu9BSrCudFV34XhJ+B9WgHIDddWEk9kJ0loh64Ef96/hIsQ5/Bh3o6tm07k/QePOzFa81cXP9NVoFpo3MlFTZtPZiorjyx7TbCC1aqWSo2u9XUXn7IcIi2xogALisNpJDx7G1ld3SpIYgSr09cQpzghA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB6PR07CA0103.eurprd07.prod.outlook.com (2603:10a6:6:2c::17) by AM6PR08MB3909.eurprd08.prod.outlook.com (2603:10a6:20b:8e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.15; Tue, 7 Jun 2022 17:24:06 +0000 Received: from DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2c:cafe::f9) by DB6PR07CA0103.outlook.office365.com (2603:10a6:6:2c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.4 via Frontend Transport; Tue, 7 Jun 2022 17:24:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT043.mail.protection.outlook.com (100.127.143.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12 via Frontend Transport; Tue, 7 Jun 2022 17:24:06 +0000 Received: ("Tessian outbound 6f53897bcd4e:v120"); Tue, 07 Jun 2022 17:24:05 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4ef94d0e1783b878 X-CR-MTA-TID: 64aa7808 Received: from fd1b2f263884.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 89C57453-7194-4C62-8B57-7D05C715657A.1; Tue, 07 Jun 2022 17:23:59 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fd1b2f263884.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Jun 2022 17:23:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CvJ2yKlX0V2nsrSkafPZZnVsU+9KerelF1dA5Tpr1xtONlbUoybPp1FVTUwAxeuWPRaGhrJ7xrEgWCeurMCn1IaAGZWyaQyVdWbL4hZCa3zvvlMh/HH20BrJ63+D/LL88L4vlXebVa81UCrqBOS9C5s6sYyg8TfzriWjgJ25YDWoe5OVWpXdhsl/abce1SDbU1Cr9mnazoj+VzakCAsnuPOq5P66VK6IHk8wZrmZby5bbJ/H+XzdHwriDa4rtRlhyPWIP1KTtaOh+8JQzK08bf9oBE9+Moaqq8gP1sI0PZ2Nw9ZTD1ARCEK254qZNjHDIl51/bh7gGVpllnacHTDtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TW6y1zcu+m+3MFoMit7paf/vMURDPephpm1Y2NOfGOg=; b=fbkIgmMmh0/0fvaFX0DCO5LdCSXEuGTjxSqtgl/oF2CbXXed2KqNOuxyZvfwIDngthWl1BB2y3lYncrbFbW0zJOYWSg2V7tHk6JJAcn85ME7j4NZwaRneo7Y80jsDHH+k8eYpBEbU/LRjqq+SUwcMGAYRaKN0vBBwST+9I/IwWBJr94JWRvg6IAzmFUHjVM4nvVMmif8J8kFALuCPd0/5HPhtoCcAgaOBBcvUtQ7O/XhYmDvlmkTUxdKoR7cbY8eLIDatIRh+dKFwh7h/RFhF4b0sw5kIbydzX6iAoXHaZxrlnzSQ8VltAPxT+jnsEJ/OtgstTT8ANzl3HYpgNzrnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from AS8PR08MB6678.eurprd08.prod.outlook.com (2603:10a6:20b:398::8) by VI1PR0801MB1870.eurprd08.prod.outlook.com (2603:10a6:800:85::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Tue, 7 Jun 2022 17:23:56 +0000 Received: from AS8PR08MB6678.eurprd08.prod.outlook.com ([fe80::687c:3c9c:f586:904e]) by AS8PR08MB6678.eurprd08.prod.outlook.com ([fe80::687c:3c9c:f586:904e%9]) with mapi id 15.20.5314.019; Tue, 7 Jun 2022 17:23:56 +0000 To: "gcc-patches@gcc.gnu.org" Subject: [PATCH] aarch64: Lower vcombine to GIMPLE Thread-Topic: [PATCH] aarch64: Lower vcombine to GIMPLE Thread-Index: AQHYepAgfaAy9RzTJEy+W2rhqdM4gQ== Date: Tue, 7 Jun 2022 17:23:56 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: 4a77ccdc-9536-0f57-4654-e5d88741f838 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 54497c01-0ca1-4e92-ecf9-08da48aa865a x-ms-traffictypediagnostic: VI1PR0801MB1870:EE_|DBAEUR03FT043:EE_|AM6PR08MB3909:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YX8m00CEcOdwgC7oE0h9Pp5hQuYHOSBkP6Gx+vPpODZsrizcPrbNfDIr6Y/SGuFipJF6Gt538WlR6bZc8d1LaT0mefgGt8RlbBD7fia5snIR5gdfJxJlmVj3cBvbFEaXq8e4y5vabG9c7qXeJHMm94z+mFHke34Kxafv1wFqXevmKBAINy1wI75GCfOc65ZuQYQlbJP6DhSwqBBjAtK64RxN+V4XxA+m6DhljlJIyZ3dsOj80yIB06D84nlvVi9jQudJY++VDvio1OlNhdhD93Y6b5DEjQ80SaBrI1KDCvtb+/5aVC4+PMiipQUhzDVDSUwdr197IXquCVRYJeDnRgJC6ntYpjL1myaA2CgxQnibR0e6hStZukpnHyHNtlpGe2a4qe/egHA6D1axw+dihU57QdQbfXEAoWq63DRSjhCt41TN0xSE7a9uutlS7KzETSWQxD3uJFWSAG9aTkjw0aTN1MWN2NmQ0sBdm1WiWJdhc+zORIhdrD3jdnfd9L/ubmRo5iqy/m/m6OFQAvtBBYCv/Ykm9HyIH73dvr6dXrjahrJZweV8XSPzbDuZDD2M2HyTOZVsC7GjLT026CGJ3mq5cKjGb6nmhL2v6pJjw4hdZYAlNuzVBkQQ3p96UW9Cb/vJBeaafmJraPg+2YmMVtNpFdzOZAnf5XHoe2oAbv5D9YJ1JL+Q7ktNFS9MB9dwXiy//5WUzejNUbpijx3s0EbpOEIEanJul0hzW3DA9phfs5tLzuE5UkXglqglOXXnr0BpUZ6AZ25dfH0Po6AphtptxOq1L1CQL8MGP/tDACQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB6678.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(122000001)(6916009)(84970400001)(66946007)(66556008)(8676002)(66446008)(66476007)(91956017)(64756008)(38100700002)(76116006)(186003)(8936002)(6506007)(7696005)(5660300002)(38070700005)(508600001)(9686003)(26005)(316002)(33656002)(71200400001)(55016003)(86362001)(2906002)(52536014); DIR:OUT; SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1870 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 398a46fc-2b4c-4992-7bf1-08da48aa8065 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cC8wx4pPHGGizeGWtHktfmSu9tK8phkx+c71gcUraQ9KDHxK2a8irf6qiCJNgSDBKUkJOzlcQQ26whra+DpepZxsyO+xKCc7bfrhJmzXuT6PxTH/e+Wm9K9EN3zSJeneSRfAuyD563UcDnG2nS99jIOV9wUq28jII+CFHLyGYil7yz0sHQFFcebA6e1GimQ86ktkuN5N20Aiif9TufqsQHrv/GZixMX53Sr7dLY3THtUxJ40m/AXC5GuyPYFZLhR3jg0EebIZjGVHS1UqUzf/Xg9YHT08S10FxZn9t7UBubviXWsLEeHO53uQsUmidrcyzOeZdp8RgAsQfvYiDRzmN2muJy9WZR5RJvnnkwBC8Xn0Xpxz0uCx2W/ZQr5D/YcIt+gQwKUZm710MJt59fzA/5WOmyLTETRj2bFElCySdsJRcsGiYyqc1Uyaue1pFDMCAqfVl0tInDNbeI/4/VS9jZhA4AWn9y0sE+cqubeR6JLX6GOxtj9Uux0WQz+jEIcC4NuICXr3gRPWlrX4Id9OmeGErA6zBDt5GLbb30eJREnQK5eJjN3C39C+8GD/ZY82b9OgfmTva5Uo7Rl7MjAQN26vpcrMWgbVOXF/PTDejpZuPXWrDu29yx2QBIVWIBUGK5B4MSvpbRjqTkeUNXH70RiciTzwOh76VdKnwv3Xx6i5f8arMpZATsGEXzbw5Ylm9Godvzj0TR3VXwMwQjR9uV520/jjLlr6B1AUjY4l7wHNtnCniNLA+paLKhRFSQbk6+JfK60xjyrtwaxS6l+MQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(55016003)(186003)(40460700003)(36860700001)(26005)(6916009)(9686003)(70586007)(52536014)(84970400001)(70206006)(8936002)(356005)(5660300002)(508600001)(8676002)(33656002)(86362001)(2906002)(81166007)(316002)(82310400005)(6506007)(7696005)(47076005)(336012); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2022 17:24:06.1936 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54497c01-0ca1-4e92-ecf9-08da48aa865a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3909 X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, KAM_DMARC_NONE, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Carlotti via Gcc-patches From: Andrew Carlotti Reply-To: Andrew Carlotti Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi all, This lowers vcombine intrinsics to a GIMPLE vector constructor, which enables better optimisation during GIMPLE passes. Bootstrapped and tested on aarch64-none-linux-gnu, and tested for aarch64_be-none-linux-gnu via cross-compilation. gcc/ * config/aarch64/aarch64-builtins.c (aarch64_general_gimple_fold_builtin): Add combine. gcc/testsuite/ * gcc.target/aarch64/advsimd-intrinsics/combine.c: New test. diff --git a/gcc/config/aarch64/aarch64-builtins.cc b/gcc/config/aarch64/aarch64-builtins.cc index 5217dbdb2ac78bba0a669d22af6d769d1fe91a3d..9d52fb8c5a48c9b743defb340a85fb20a1c8f014 100644 --- a/gcc/config/aarch64/aarch64-builtins.cc +++ b/gcc/config/aarch64/aarch64-builtins.cc @@ -2827,6 +2827,18 @@ aarch64_general_gimple_fold_builtin (unsigned int fcode, gcall *stmt, gimple_call_set_lhs (new_stmt, gimple_call_lhs (stmt)); break; + BUILTIN_VDC (BINOP, combine, 0, AUTO_FP) + BUILTIN_VD_I (BINOPU, combine, 0, NONE) + BUILTIN_VDC_P (BINOPP, combine, 0, NONE) + { + if (BYTES_BIG_ENDIAN) + std::swap(args[0], args[1]); + tree ret_type = TREE_TYPE (gimple_call_lhs (stmt)); + tree ctor = build_constructor_va (ret_type, 2, NULL_TREE, args[0], NULL_TREE, args[1]); + new_stmt = gimple_build_assign (gimple_call_lhs (stmt), ctor); + } + break; + /*lower store and load neon builtins to gimple. */ BUILTIN_VALL_F16 (LOAD1, ld1, 0, LOAD) BUILTIN_VDQ_I (LOAD1_U, ld1, 0, LOAD) diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/combine.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/combine.c new file mode 100644 index 0000000000000000000000000000000000000000..d08faf7a4a160a1e83428ed9b270731bbf7b8c8a --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/combine.c @@ -0,0 +1,18 @@ +/* { dg-do compile { target { aarch64*-*-* } } } */ +/* { dg-final { check-function-bodies "**" "" {-O[^0]} } } */ +/* { dg-skip-if "" { *-*-* } { "-fno-fat-lto-objects" } } */ + +#include + +/* +** foo: +** umov w0, v1\.s\[1\] +** ret +*/ + +int32_t foo (int32x2_t a, int32x2_t b) +{ + int32x4_t c = vcombine_s32(a, b); + return vgetq_lane_s32(c, 3); +} +