diff mbox series

Message ID CAFAZVkjTRjv7dcBqpBrFrU9zgY9fCJsmXKax7_2Erzx5NO7U_g@mail.gmail.com
State New
Headers
Series |

Commit Message

Bhuvan Feb. 11, 2026, 4:54 p.m. UTC 
  From d76155211b2656700b02c7f74f0dd2e42b1060c2 Mon Sep 17 00:00:00 2001
From: BhuvanB <bhuvanb1408@gmail.com>
Date: Wed, 11 Feb 2026 22:10:12 +0530
Subject: [PATCH] rtems: Move termios extension APIs to public header

Move rtems_termios_rxirq_occured() and rtems_termios_puts() to the
public termios.h header. These functions are part of the RTEMS termios
API extensions used by device drivers.

This resolves FIXME comments in RTEMS cpukit/include/rtems/termiostypes.h
requesting these functions be made public.

Signed-off-by: Bhuvan B <bhuvanb1408@gmail.com>
---
 newlib/libc/sys/rtems/include/termios.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Joel Sherrill Feb. 12, 2026, 3:03 p.m. UTC | #1 
This is RTEMS specific and should not move to a header in newlib.
Especially one from POSIX.

There are private headers for termios where this could go.

All patches to RTEMS should go through gitlab.rtems.org. If they are to
something like newlib or gcc, We have a mirror repository where we
review changes before they get submitted to newlib or gcc.

If you have questions, users.rtems.org or the RTEMS Discord are
the appropriate forums.

--joel

On Wed, Feb 11, 2026 at 10:55 AM Bhuvan <bhuvanb1408@gmail.com> wrote:

> From d76155211b2656700b02c7f74f0dd2e42b1060c2 Mon Sep 17 00:00:00 2001
> From: BhuvanB <bhuvanb1408@gmail.com>
> Date: Wed, 11 Feb 2026 22:10:12 +0530
> Subject: [PATCH] rtems: Move termios extension APIs to public header
>
> Move rtems_termios_rxirq_occured() and rtems_termios_puts() to the
> public termios.h header. These functions are part of the RTEMS termios
> API extensions used by device drivers.
>
> This resolves FIXME comments in RTEMS cpukit/include/rtems/termiostypes.h
> requesting these functions be made public.
>
> Signed-off-by: Bhuvan B <bhuvanb1408@gmail.com>
> ---
>  newlib/libc/sys/rtems/include/termios.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/newlib/libc/sys/rtems/include/termios.h
> b/newlib/libc/sys/rtems/include/termios.h
> index 9b808329a..db47a41b7 100644
> --- a/newlib/libc/sys/rtems/include/termios.h
> +++ b/newlib/libc/sys/rtems/include/termios.h
> @@ -42,6 +42,8 @@
>  #include <sys/_winsize.h>
>  #endif
>
> +struct rtems_termios_tty;
> +
>  #ifndef _PID_T_DECLARED
>  typedef __pid_t pid_t;
>  #define _PID_T_DECLARED
> @@ -86,6 +88,9 @@ int tcflow(int, int);
>  int tcflush(int, int);
>  int tcsendbreak(int, int);
>
> +void rtems_termios_rxirq_occured(struct rtems_termios_tty *);
> +void rtems_termios_puts(const void *, size_t, struct rtems_termios_tty *);
> +
>  #if __POSIX_VISIBLE >= 200112
>  pid_t tcgetsid(int);
>  #endif
> --
> 2.52.0
>
diff mbox series

Patch

diff --git a/newlib/libc/sys/rtems/include/termios.h
b/newlib/libc/sys/rtems/include/termios.h
index 9b808329a..db47a41b7 100644
--- a/newlib/libc/sys/rtems/include/termios.h
+++ b/newlib/libc/sys/rtems/include/termios.h
@@ -42,6 +42,8 @@ 
 #include <sys/_winsize.h>
 #endif

+struct rtems_termios_tty;
+
 #ifndef _PID_T_DECLARED
 typedef __pid_t pid_t;
 #define _PID_T_DECLARED
@@ -86,6 +88,9 @@  int tcflow(int, int);
 int tcflush(int, int);
 int tcsendbreak(int, int);

+void rtems_termios_rxirq_occured(struct rtems_termios_tty *);
+void rtems_termios_puts(const void *, size_t, struct rtems_termios_tty *);
+
 #if __POSIX_VISIBLE >= 200112
 pid_t tcgetsid(int);
 #endif