Fix v850 libgloss for c99/gcc-14
Commit Message
So the prior patch for sysnecv850 was in newlib. This time we're fixing
v850 bits in libgloss.
Like other patches submitted recently, this converts implicit ints to
explicit ints, adds a missing prototype and header includes.
OK for the trunk?
Jeff
Comments
Hi Jeff, please feel free to check in such similar patches in other
libgloss platforms. Are there any more?
I ask because it makes sense to hold off the snapshot until you are done.
-- Jeff J.
On Thu, Dec 21, 2023 at 3:09 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
> So the prior patch for sysnecv850 was in newlib. This time we're fixing
> v850 bits in libgloss.
>
>
> Like other patches submitted recently, this converts implicit ints to
> explicit ints, adds a missing prototype and header includes.
>
> OK for the trunk?
>
> Jeff
On 12/21/23 15:46, Jeff Johnston wrote:
> Hi Jeff, please feel free to check in such similar patches in other
> libgloss platforms. Are there any more?
We're about done with the trivial ones. And some of the stuff needs
cleanup in my local tree before submitting to be consistent (ex, don't
explicitly prototype something when we can just #include the right header).
Point being, I think things will be broken a bit longer with gcc-14, but
that's still months from release, so I don't think that's a major problem.
> I ask because it makes sense to hold off the snapshot until you are done.
I'd lean towards making your snapshot whenever is convenient for you and
the project rather than waiting for everything to be working with gcc-14.
Jeff
@@ -23,7 +23,7 @@ static void _do_dtors()
}
-void _exit (n)
+void _exit (int n)
{
/* Destructors should be done earlier because they need to be done before the
files are closed, but here is better than nowhere (and this balances the
@@ -9,7 +9,8 @@ int __trap0 (int function, int p1, int p2, int p3);
#define TRAP0(f, p1, p2, p3) __trap0(f, (int)(p1), (int)(p2), (int)(p3))
-_getpid (n)
+int
+_getpid (int n)
{
return 1;
}
@@ -9,8 +9,8 @@ int __trap0 (int function, int p1, int p2, int p3);
#define TRAP0(f, p1, p2, p3) __trap0(f, (int)(p1), (int)(p2), (int)(p3))
-_isatty (fd)
- int fd;
+int
+_isatty (int fd)
{
return 1;
}
@@ -10,6 +10,7 @@ int __trap0 (int function, int p1, int p2, int p3);
#define TRAP0(f, p1, p2, p3) __trap0(f, (int)(p1), (int)(p2), (int)(p3))
+int
_kill (pid, sig)
pid_t pid;
int sig;
@@ -9,6 +9,7 @@ int __trap0 (int function, int p1, int p2, int p3);
#define TRAP0(f, p1, p2, p3) __trap0(f, (int)(p1), (int)(p2), (int)(p3))
+int
_read (int file,
char *ptr,
int len)
@@ -2,6 +2,9 @@
#include <sys/types.h>
#include <sys/stat.h>
#include "sys/syscall.h"
+#include <stdlib.h>
+
+extern int _write (int, char *, int);
caddr_t
_sbrk (int incr)