diff mbox series

newlib/libc/include/time.h: Removed clock_id casts

Message ID 20241119043116.32472-2-aaron.nyholm@unfoldedeffective.com
State New
Headers
Series newlib/libc/include/time.h: Removed clock_id casts |

Commit Message

aaron.nyholm@unfoldedeffective.com Nov. 19, 2024, 4:21 a.m. UTC 
  From: Aaron Nyholm <aaron.nyholm@unfoldedeffective.com>

---
 newlib/libc/include/time.h | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

Joel Sherrill Nov. 19, 2024, 4:54 a.m. UTC | #1 
Perhe POSIX specification hese are just supposed to be constants. The cast
is unnecessary.

Ok to commit?

--joel

On Mon, Nov 18, 2024, 10:32 PM <aaron.nyholm@unfoldedeffective.com> wrote:

> From: Aaron Nyholm <aaron.nyholm@unfoldedeffective.com>
>
> ---
>  newlib/libc/include/time.h | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/newlib/libc/include/time.h b/newlib/libc/include/time.h
> index ed6cc70fe..ab3491341 100644
> --- a/newlib/libc/include/time.h
> +++ b/newlib/libc/include/time.h
> @@ -237,10 +237,10 @@ extern "C" {
>  /* Manifest Constants, P1003.1b-1993, p. 262 */
>
>  #if __GNU_VISIBLE
> -#define CLOCK_REALTIME_COARSE  ((clockid_t) 0)
> +#define CLOCK_REALTIME_COARSE  (0)
>  #endif
>
> -#define CLOCK_REALTIME         ((clockid_t) 1)
> +#define CLOCK_REALTIME         (1)
>
>  /* Manifest Constants, P1003.4b/D8, p. 55 */
>
> @@ -250,7 +250,7 @@ extern "C" {
>     the identifier of the CPU_time clock associated with the PROCESS
>     making the function call.  */
>
> -#define CLOCK_PROCESS_CPUTIME_ID ((clockid_t) 2)
> +#define CLOCK_PROCESS_CPUTIME_ID (2)
>
>  #endif
>
> @@ -260,7 +260,7 @@ extern "C" {
>      the identifier of the CPU_time clock associated with the THREAD
>      making the function call.  */
>
> -#define CLOCK_THREAD_CPUTIME_ID        ((clockid_t) 3)
> +#define CLOCK_THREAD_CPUTIME_ID        (3)
>
>  #endif
>
> @@ -270,21 +270,21 @@ extern "C" {
>   *  as a clock whose value cannot be set via clock_settime() and which
>   *  cannot have backward clock jumps. */
>
> -#define CLOCK_MONOTONIC                ((clockid_t) 4)
> +#define CLOCK_MONOTONIC                (4)
>
>  #endif
>
>  #if __GNU_VISIBLE
>
> -#define CLOCK_MONOTONIC_RAW    ((clockid_t) 5)
> +#define CLOCK_MONOTONIC_RAW    (5)
>
> -#define CLOCK_MONOTONIC_COARSE ((clockid_t) 6)
> +#define CLOCK_MONOTONIC_COARSE (6)
>
> -#define CLOCK_BOOTTIME         ((clockid_t) 7)
> +#define CLOCK_BOOTTIME         (7)
>
> -#define CLOCK_REALTIME_ALARM   ((clockid_t) 8)
> +#define CLOCK_REALTIME_ALARM   (8)
>
> -#define CLOCK_BOOTTIME_ALARM   ((clockid_t) 9)
> +#define CLOCK_BOOTTIME_ALARM   (9)
>
>  #endif
>
> --
> 2.46.2
>
>
Brian Inglis Nov. 19, 2024, 7:42 p.m. UTC | #2 
Maybe put both your comments into the patch header be applied, to document both 
the reason for the patch, and synchronization to upstream.

On 2024-11-18 21:54, Joel Sherrill wrote:
> Per the POSIX specification hese are just supposed to be constants. The cast is 
> unnecessary.
> 
> Ok to commit?
> 
> --joel
> 
> On Mon, Nov 18, 2024, 10:32 PM <aaron.nyholm@unfoldedeffective.com 
> <mailto:aaron.nyholm@unfoldedeffective.com>> wrote:
> 
>     From: Aaron Nyholm <aaron.nyholm@unfoldedeffective.com
>     <mailto:aaron.nyholm@unfoldedeffective.com>>
> 
>     ---
>       newlib/libc/include/time.h | 20 ++++++++++----------
>       1 file changed, 10 insertions(+), 10 deletions(-)
> 
>     diff --git a/newlib/libc/include/time.h b/newlib/libc/include/time.h
>     index ed6cc70fe..ab3491341 100644
>     --- a/newlib/libc/include/time.h
>     +++ b/newlib/libc/include/time.h
>     @@ -237,10 +237,10 @@ extern "C" {
>       /* Manifest Constants, P1003.1b-1993, p. 262 */
> 
>       #if __GNU_VISIBLE
>     -#define CLOCK_REALTIME_COARSE  ((clockid_t) 0)
>     +#define CLOCK_REALTIME_COARSE  (0)
>       #endif
> 
>     -#define CLOCK_REALTIME         ((clockid_t) 1)
>     +#define CLOCK_REALTIME         (1)
> 
>       /* Manifest Constants, P1003.4b/D8, p. 55 */
> 
>     @@ -250,7 +250,7 @@ extern "C" {
>          the identifier of the CPU_time clock associated with the PROCESS
>          making the function call.  */
> 
>     -#define CLOCK_PROCESS_CPUTIME_ID ((clockid_t) 2)
>     +#define CLOCK_PROCESS_CPUTIME_ID (2)
> 
>       #endif
> 
>     @@ -260,7 +260,7 @@ extern "C" {
>           the identifier of the CPU_time clock associated with the THREAD
>           making the function call.  */
> 
>     -#define CLOCK_THREAD_CPUTIME_ID        ((clockid_t) 3)
>     +#define CLOCK_THREAD_CPUTIME_ID        (3)
> 
>       #endif
> 
>     @@ -270,21 +270,21 @@ extern "C" {
>        *  as a clock whose value cannot be set via clock_settime() and which
>        *  cannot have backward clock jumps. */
> 
>     -#define CLOCK_MONOTONIC                ((clockid_t) 4)
>     +#define CLOCK_MONOTONIC                (4)
> 
>       #endif
> 
>       #if __GNU_VISIBLE
> 
>     -#define CLOCK_MONOTONIC_RAW    ((clockid_t) 5)
>     +#define CLOCK_MONOTONIC_RAW    (5)
> 
>     -#define CLOCK_MONOTONIC_COARSE ((clockid_t) 6)
>     +#define CLOCK_MONOTONIC_COARSE (6)
> 
>     -#define CLOCK_BOOTTIME         ((clockid_t) 7)
>     +#define CLOCK_BOOTTIME         (7)
> 
>     -#define CLOCK_REALTIME_ALARM   ((clockid_t) 8)
>     +#define CLOCK_REALTIME_ALARM   (8)
> 
>     -#define CLOCK_BOOTTIME_ALARM   ((clockid_t) 9)
>     +#define CLOCK_BOOTTIME_ALARM   (9)
> 
>       #endif
> 
>     -- 
>     2.46.2
>
Corinna Vinschen Nov. 19, 2024, 9:06 p.m. UTC | #3 
Hi guys,

I agree with Brian in that the reasoning for the change should be added
to the commit message.  A source code comment is not necessary.


Thanks,
Corinna


On Nov 19 12:42, brian.inglis@systematicsw.ab.ca wrote:
> Maybe put both your comments into the patch header be applied, to document
> both the reason for the patch, and synchronization to upstream.
> 
> On 2024-11-18 21:54, Joel Sherrill wrote:
> > Per the POSIX specification hese are just supposed to be constants. The
> > cast is unnecessary.
> > 
> > Ok to commit?
> > 
> > --joel
> > 
> > On Mon, Nov 18, 2024, 10:32 PM <aaron.nyholm@unfoldedeffective.com
> > <mailto:aaron.nyholm@unfoldedeffective.com>> wrote:
> > 
> >     From: Aaron Nyholm <aaron.nyholm@unfoldedeffective.com
> >     <mailto:aaron.nyholm@unfoldedeffective.com>>
> > 
> >     ---
> >       newlib/libc/include/time.h | 20 ++++++++++----------
> >       1 file changed, 10 insertions(+), 10 deletions(-)
> > 
> >     diff --git a/newlib/libc/include/time.h b/newlib/libc/include/time.h
> >     index ed6cc70fe..ab3491341 100644
> >     --- a/newlib/libc/include/time.h
> >     +++ b/newlib/libc/include/time.h
> >     @@ -237,10 +237,10 @@ extern "C" {
> >       /* Manifest Constants, P1003.1b-1993, p. 262 */
> > 
> >       #if __GNU_VISIBLE
> >     -#define CLOCK_REALTIME_COARSE  ((clockid_t) 0)
> >     +#define CLOCK_REALTIME_COARSE  (0)
> >       #endif
> > 
> >     -#define CLOCK_REALTIME         ((clockid_t) 1)
> >     +#define CLOCK_REALTIME         (1)
> > 
> >       /* Manifest Constants, P1003.4b/D8, p. 55 */
> > 
> >     @@ -250,7 +250,7 @@ extern "C" {
> >          the identifier of the CPU_time clock associated with the PROCESS
> >          making the function call.  */
> > 
> >     -#define CLOCK_PROCESS_CPUTIME_ID ((clockid_t) 2)
> >     +#define CLOCK_PROCESS_CPUTIME_ID (2)
> > 
> >       #endif
> > 
> >     @@ -260,7 +260,7 @@ extern "C" {
> >           the identifier of the CPU_time clock associated with the THREAD
> >           making the function call.  */
> > 
> >     -#define CLOCK_THREAD_CPUTIME_ID        ((clockid_t) 3)
> >     +#define CLOCK_THREAD_CPUTIME_ID        (3)
> > 
> >       #endif
> > 
> >     @@ -270,21 +270,21 @@ extern "C" {
> >        *  as a clock whose value cannot be set via clock_settime() and which
> >        *  cannot have backward clock jumps. */
> > 
> >     -#define CLOCK_MONOTONIC                ((clockid_t) 4)
> >     +#define CLOCK_MONOTONIC                (4)
> > 
> >       #endif
> > 
> >       #if __GNU_VISIBLE
> > 
> >     -#define CLOCK_MONOTONIC_RAW    ((clockid_t) 5)
> >     +#define CLOCK_MONOTONIC_RAW    (5)
> > 
> >     -#define CLOCK_MONOTONIC_COARSE ((clockid_t) 6)
> >     +#define CLOCK_MONOTONIC_COARSE (6)
> > 
> >     -#define CLOCK_BOOTTIME         ((clockid_t) 7)
> >     +#define CLOCK_BOOTTIME         (7)
> > 
> >     -#define CLOCK_REALTIME_ALARM   ((clockid_t) 8)
> >     +#define CLOCK_REALTIME_ALARM   (8)
> > 
> >     -#define CLOCK_BOOTTIME_ALARM   ((clockid_t) 9)
> >     +#define CLOCK_BOOTTIME_ALARM   (9)
> > 
> >       #endif
> > 
> >     --     2.46.2
> > 
> 
> 
> -- 
> Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada
> 
> La perfection est atteinte                   Perfection is achieved
> non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
> mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
>                                 -- Antoine de Saint-Exupéry
diff mbox series

Patch

diff --git a/newlib/libc/include/time.h b/newlib/libc/include/time.h
index ed6cc70fe..ab3491341 100644
--- a/newlib/libc/include/time.h
+++ b/newlib/libc/include/time.h
@@ -237,10 +237,10 @@  extern "C" {
 /* Manifest Constants, P1003.1b-1993, p. 262 */
 
 #if __GNU_VISIBLE
-#define CLOCK_REALTIME_COARSE	((clockid_t) 0)
+#define CLOCK_REALTIME_COARSE	(0)
 #endif
 
-#define CLOCK_REALTIME		((clockid_t) 1)
+#define CLOCK_REALTIME		(1)
 
 /* Manifest Constants, P1003.4b/D8, p. 55 */
 
@@ -250,7 +250,7 @@  extern "C" {
    the identifier of the CPU_time clock associated with the PROCESS
    making the function call.  */
 
-#define CLOCK_PROCESS_CPUTIME_ID ((clockid_t) 2)
+#define CLOCK_PROCESS_CPUTIME_ID (2)
 
 #endif
 
@@ -260,7 +260,7 @@  extern "C" {
     the identifier of the CPU_time clock associated with the THREAD
     making the function call.  */
 
-#define CLOCK_THREAD_CPUTIME_ID	((clockid_t) 3)
+#define CLOCK_THREAD_CPUTIME_ID	(3)
 
 #endif
 
@@ -270,21 +270,21 @@  extern "C" {
  *  as a clock whose value cannot be set via clock_settime() and which
  *  cannot have backward clock jumps. */
 
-#define CLOCK_MONOTONIC		((clockid_t) 4)
+#define CLOCK_MONOTONIC		(4)
 
 #endif
 
 #if __GNU_VISIBLE
 
-#define CLOCK_MONOTONIC_RAW	((clockid_t) 5)
+#define CLOCK_MONOTONIC_RAW	(5)
 
-#define CLOCK_MONOTONIC_COARSE	((clockid_t) 6)
+#define CLOCK_MONOTONIC_COARSE	(6)
 
-#define CLOCK_BOOTTIME		((clockid_t) 7)
+#define CLOCK_BOOTTIME		(7)
 
-#define CLOCK_REALTIME_ALARM	((clockid_t) 8)
+#define CLOCK_REALTIME_ALARM	(8)
 
-#define CLOCK_BOOTTIME_ALARM	((clockid_t) 9)
+#define CLOCK_BOOTTIME_ALARM	(9)
 
 #endif