diff mbox series

Use ldflags instead of LDFLAGS in newlib.exp

Message ID 20240820111128.1594372-1-ykolerov@synopsys.com
State New
Headers
Series Use ldflags instead of LDFLAGS in newlib.exp |

Commit Message

Yuriy Kolerov Aug. 20, 2024, 11:11 a.m. UTC 
  From: Claudiu Zissulescu <claziss@gmail.com>

This variable was accidentally renamed earlier. It must be
ldflags according to DejaGNU documentation.

Signed-off-by: Claudiu Zissulescu <claziss@gmail.com>
---
 newlib/testsuite/lib/newlib.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Corinna Vinschen Aug. 21, 2024, 9:18 a.m. UTC | #1 
On Aug 20 14:11, Yuriy.Kolerov@synopsys.com wrote:
> From: Claudiu Zissulescu <claziss@gmail.com>
> 
> This variable was accidentally renamed earlier. It must be
> ldflags according to DejaGNU documentation.
> 
> Signed-off-by: Claudiu Zissulescu <claziss@gmail.com>
> ---
>  newlib/testsuite/lib/newlib.exp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/newlib/testsuite/lib/newlib.exp b/newlib/testsuite/lib/newlib.exp
> index 8b43d2e5d..f1df40e52 100644
> --- a/newlib/testsuite/lib/newlib.exp
> +++ b/newlib/testsuite/lib/newlib.exp
> @@ -66,13 +66,13 @@ proc newlib_target_compile { source dest type options } {
>  	    [target_info needs_status_wrapper] != "0" && \
>  	    [info exists gluefile] } {
>  	lappend options "libs=$gluefile"
> -	lappend options "LDFLAGS=$wrap_flags"
> +	lappend options "ldflags=$wrap_flags"
>      }
>  
>      if [string match $host_triplet $target_triplet] then {
>  	if [string match "i686-pc-linux-gnu" $host_triplet] then {
>  	    lappend options "libs=$objdir/crt0.o -lc -lgcc"
> -	    lappend options "LDFLAGS=-nostdlib -L$objdir/.libs [newlib_include_flags]"
> +	    lappend options "ldflags=-nostdlib -L$objdir/.libs [newlib_include_flags]"
>  	}
>      }
>  
> -- 
> 2.34.1

Pushed.

Thanks,
Corinna
diff mbox series

Patch

diff --git a/newlib/testsuite/lib/newlib.exp b/newlib/testsuite/lib/newlib.exp
index 8b43d2e5d..f1df40e52 100644
--- a/newlib/testsuite/lib/newlib.exp
+++ b/newlib/testsuite/lib/newlib.exp
@@ -66,13 +66,13 @@  proc newlib_target_compile { source dest type options } {
 	    [target_info needs_status_wrapper] != "0" && \
 	    [info exists gluefile] } {
 	lappend options "libs=$gluefile"
-	lappend options "LDFLAGS=$wrap_flags"
+	lappend options "ldflags=$wrap_flags"
     }
 
     if [string match $host_triplet $target_triplet] then {
 	if [string match "i686-pc-linux-gnu" $host_triplet] then {
 	    lappend options "libs=$objdir/crt0.o -lc -lgcc"
-	    lappend options "LDFLAGS=-nostdlib -L$objdir/.libs [newlib_include_flags]"
+	    lappend options "ldflags=-nostdlib -L$objdir/.libs [newlib_include_flags]"
 	}
     }