libc/include/sys/_default_fcntl.h: O_RSYNC and O_DSYNC are POSIX

Message ID 20240629205907.16215-1-joel@rtems.org
State New
Headers
Series libc/include/sys/_default_fcntl.h: O_RSYNC and O_DSYNC are POSIX |

Commit Message

Joel Sherrill June 29, 2024, 8:59 p.m. UTC
  These should not be in a Cygewin conditional.
---
 newlib/libc/include/sys/_default_fcntl.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
  

Comments

Corinna Vinschen July 3, 2024, 11:14 a.m. UTC | #1
On Jun 29 15:59, Joel Sherrill wrote:
> These should not be in a Cygewin conditional.
> ---
>  newlib/libc/include/sys/_default_fcntl.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/newlib/libc/include/sys/_default_fcntl.h b/newlib/libc/include/sys/_default_fcntl.h
> index ce721fa23..148e97dd2 100644
> --- a/newlib/libc/include/sys/_default_fcntl.h
> +++ b/newlib/libc/include/sys/_default_fcntl.h
> @@ -71,11 +71,12 @@ extern "C" {
>  #define	O_DIRECT	_FDIRECT
>  #endif
>  
> +#define O_DSYNC         _FSYNC
> +#define O_RSYNC         _FSYNC
> +
>  #if defined (__CYGWIN__)
>  #define O_BINARY	_FBINARY
>  #define O_TEXT		_FTEXT
> -#define O_DSYNC         _FSYNC
> -#define O_RSYNC         _FSYNC
>  
>  /* Linux-specific flags */
>  #if __GNU_VISIBLE
> -- 
> 2.24.4

LGTM, please push.

Thanks,
Corinna
  
Joel Sherrill July 3, 2024, 2 p.m. UTC | #2
Merged. Thanks.

--joel

On Wed, Jul 3, 2024 at 6:15 AM Corinna Vinschen <vinschen@redhat.com> wrote:

> On Jun 29 15:59, Joel Sherrill wrote:
> > These should not be in a Cygewin conditional.
> > ---
> >  newlib/libc/include/sys/_default_fcntl.h | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/newlib/libc/include/sys/_default_fcntl.h
> b/newlib/libc/include/sys/_default_fcntl.h
> > index ce721fa23..148e97dd2 100644
> > --- a/newlib/libc/include/sys/_default_fcntl.h
> > +++ b/newlib/libc/include/sys/_default_fcntl.h
> > @@ -71,11 +71,12 @@ extern "C" {
> >  #define      O_DIRECT        _FDIRECT
> >  #endif
> >
> > +#define O_DSYNC         _FSYNC
> > +#define O_RSYNC         _FSYNC
> > +
> >  #if defined (__CYGWIN__)
> >  #define O_BINARY     _FBINARY
> >  #define O_TEXT               _FTEXT
> > -#define O_DSYNC         _FSYNC
> > -#define O_RSYNC         _FSYNC
> >
> >  /* Linux-specific flags */
> >  #if __GNU_VISIBLE
> > --
> > 2.24.4
>
> LGTM, please push.
>
> Thanks,
> Corinna
>
>
  

Patch

diff --git a/newlib/libc/include/sys/_default_fcntl.h b/newlib/libc/include/sys/_default_fcntl.h
index ce721fa23..148e97dd2 100644
--- a/newlib/libc/include/sys/_default_fcntl.h
+++ b/newlib/libc/include/sys/_default_fcntl.h
@@ -71,11 +71,12 @@  extern "C" {
 #define	O_DIRECT	_FDIRECT
 #endif
 
+#define O_DSYNC         _FSYNC
+#define O_RSYNC         _FSYNC
+
 #if defined (__CYGWIN__)
 #define O_BINARY	_FBINARY
 #define O_TEXT		_FTEXT
-#define O_DSYNC         _FSYNC
-#define O_RSYNC         _FSYNC
 
 /* Linux-specific flags */
 #if __GNU_VISIBLE