[v3,2/2] libgloss: pru: Trim crt0-minrt.o

  Strip a few more instructions from crt0-minrt.S:
  - Remove "halt" and rely on the infinite loop after main()'s return.
  - Remove main()'s argc and argv argument initialization.  Host loader
    does not set them, and typical firmware does not use them, either.
  - Remove the __dso_handle symbol.

This should be safe because the default crt0.S is fully standards
compliant.  Whereas crt0-minrt.S has been documented from the beginning
to intentionally miss features in order to reduce firmware size, while
still enabling typical PRU firmware to operate.

Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
---
 libgloss/pru/crt0-minrt.S | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)
  

On Thu, Jan 04, 2024 at 07:19:52PM +0200, Dimitar Dimitrov wrote:
> Strip a few more instructions from crt0-minrt.S:
>   - Remove "halt" and rely on the infinite loop after main()'s return.
>   - Remove main()'s argc and argv argument initialization.  Host loader
>     does not set them, and typical firmware does not use them, either.
>   - Remove the __dso_handle symbol.
> 
> This should be safe because the default crt0.S is fully standards
> compliant.  Whereas crt0-minrt.S has been documented from the beginning
> to intentionally miss features in order to reduce firmware size, while
> still enabling typical PRU firmware to operate.
> 
> Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
> ---
>  libgloss/pru/crt0-minrt.S | 15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)

Ping.

Regards,
Dimitar
  

should you be listed in newlib/MAINTAINERS for pru ?
-mike
  

On Sat, Jan 20, 2024 at 08:46:36AM -0500, Mike Frysinger wrote:
> should you be listed in newlib/MAINTAINERS for pru ?
> -mike

Yes, I would be honoured.

I've been running and monitoring CI for the GNU toolchain for PRU,
including newlib, for a few years.  And I intend to continue doing so.

Thanks,
Dimitar
  

On 20 Jan 2024 17:15, Dimitar Dimitrov wrote:
> On Sat, Jan 20, 2024 at 08:46:36AM -0500, Mike Frysinger wrote:
> > should you be listed in newlib/MAINTAINERS for pru ?
> 
> Yes, I would be honoured.
> 
> I've been running and monitoring CI for the GNU toolchain for PRU,
> including newlib, for a few years.  And I intend to continue doing so.

send a patch for Corinna & Jeff to approve :)

do you have push access to newlib now ?  might be worth asking for that too
so you can be added to the "write privileges after getting approval" section.
-mike
  

On Jan 20 13:57, Mike Frysinger wrote:
> On 20 Jan 2024 17:15, Dimitar Dimitrov wrote:
> > On Sat, Jan 20, 2024 at 08:46:36AM -0500, Mike Frysinger wrote:
> > > should you be listed in newlib/MAINTAINERS for pru ?
> > 
> > Yes, I would be honoured.
> > 
> > I've been running and monitoring CI for the GNU toolchain for PRU,
> > including newlib, for a few years.  And I intend to continue doing so.
> 
> send a patch for Corinna & Jeff to approve :)
> 
> do you have push access to newlib now ?  might be worth asking for that too
> so you can be added to the "write privileges after getting approval" section.
> -mike

libgloss isn't my playfield, so I was deferring this to Jeff.
Personally I have no problems with that.

For the time being, I was trying to merge the patches but the
first patch to the build system already fails to apply cleanly.
ANy chance to regenerate it relative to current main?


Thanks,
Corinna
  

On 22 Jan 2024 11:04, Corinna Vinschen wrote:
> On Jan 20 13:57, Mike Frysinger wrote:
> > On 20 Jan 2024 17:15, Dimitar Dimitrov wrote:
> > > On Sat, Jan 20, 2024 at 08:46:36AM -0500, Mike Frysinger wrote:
> > > > should you be listed in newlib/MAINTAINERS for pru ?
> > > 
> > > Yes, I would be honoured.
> > > 
> > > I've been running and monitoring CI for the GNU toolchain for PRU,
> > > including newlib, for a few years.  And I intend to continue doing so.
> > 
> > send a patch for Corinna & Jeff to approve :)
> > 
> > do you have push access to newlib now ?  might be worth asking for that too
> > so you can be added to the "write privileges after getting approval" section.
> 
> libgloss isn't my playfield, so I was deferring this to Jeff.

any value in carving out a more specific libgloss/MAINTAINERS ?
i'd be happy to be a "global" maintainer there ... just not in newlib :).
-mike
  

On Mon, Jan 22, 2024 at 5:04 AM Corinna Vinschen <vinschen@redhat.com>
wrote:

> On Jan 20 13:57, Mike Frysinger wrote:
> > On 20 Jan 2024 17:15, Dimitar Dimitrov wrote:
> > > On Sat, Jan 20, 2024 at 08:46:36AM -0500, Mike Frysinger wrote:
> > > > should you be listed in newlib/MAINTAINERS for pru ?
> > >
> > > Yes, I would be honoured.
> > >
> > > I've been running and monitoring CI for the GNU toolchain for PRU,
> > > including newlib, for a few years.  And I intend to continue doing so.
> >
> > send a patch for Corinna & Jeff to approve :)
> >
> > do you have push access to newlib now ?  might be worth asking for that
> too
> > so you can be added to the "write privileges after getting approval"
> section.
> > -mike
>
> libgloss isn't my playfield, so I was deferring this to Jeff.
> Personally I have no problems with that.
>

I'm fine too.  I'll add Dimitar for pru to newlib/MAINTAINERS file.  I
don't offhand know the process for
getting push access to newlib.


> For the time being, I was trying to merge the patches but the
> first patch to the build system already fails to apply cleanly.
> ANy chance to regenerate it relative to current main?
>
>
> Thanks,
> Corinna
>
>
  

On Jan 22 12:27, Mike Frysinger wrote:
> On 22 Jan 2024 11:04, Corinna Vinschen wrote:
> > On Jan 20 13:57, Mike Frysinger wrote:
> > > On 20 Jan 2024 17:15, Dimitar Dimitrov wrote:
> > > > On Sat, Jan 20, 2024 at 08:46:36AM -0500, Mike Frysinger wrote:
> > > > > should you be listed in newlib/MAINTAINERS for pru ?
> > > > 
> > > > Yes, I would be honoured.
> > > > 
> > > > I've been running and monitoring CI for the GNU toolchain for PRU,
> > > > including newlib, for a few years.  And I intend to continue doing so.
> > > 
> > > send a patch for Corinna & Jeff to approve :)
> > > 
> > > do you have push access to newlib now ?  might be worth asking for that too
> > > so you can be added to the "write privileges after getting approval" section.
> > 
> > libgloss isn't my playfield, so I was deferring this to Jeff.
> 
> any value in carving out a more specific libgloss/MAINTAINERS ?
> i'd be happy to be a "global" maintainer there ... just not in newlib :).

That sounds really good to me.  Jeff?


Corinna
  

On Tue, Jan 23, 2024 at 4:04 AM Corinna Vinschen <vinschen@redhat.com>
wrote:

> On Jan 22 12:27, Mike Frysinger wrote:
> > On 22 Jan 2024 11:04, Corinna Vinschen wrote:
> > > On Jan 20 13:57, Mike Frysinger wrote:
> > > > On 20 Jan 2024 17:15, Dimitar Dimitrov wrote:
> > > > > On Sat, Jan 20, 2024 at 08:46:36AM -0500, Mike Frysinger wrote:
> > > > > > should you be listed in newlib/MAINTAINERS for pru ?
> > > > >
> > > > > Yes, I would be honoured.
> > > > >
> > > > > I've been running and monitoring CI for the GNU toolchain for PRU,
> > > > > including newlib, for a few years.  And I intend to continue doing
> so.
> > > >
> > > > send a patch for Corinna & Jeff to approve :)
> > > >
> > > > do you have push access to newlib now ?  might be worth asking for
> that too
> > > > so you can be added to the "write privileges after getting approval"
> section.
> > >
> > > libgloss isn't my playfield, so I was deferring this to Jeff.
> >
> > any value in carving out a more specific libgloss/MAINTAINERS ?
> > i'd be happy to be a "global" maintainer there ... just not in newlib :).
>
> That sounds really good to me.  Jeff?
>
>
I agree.

-- Jeff J.



> Corinna
>
>