Message ID | 0d476ceb-d413-4f68-953a-3b9a4634fff8@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <newlib-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3B35E38618F4 for <patchwork@sourceware.org>; Thu, 14 Dec 2023 19:26:31 +0000 (GMT) X-Original-To: newlib@sourceware.org Delivered-To: newlib@sourceware.org Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id BA7C6385C6DD for <newlib@sourceware.org>; Thu, 14 Dec 2023 19:26:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA7C6385C6DD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BA7C6385C6DD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::529 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702581982; cv=none; b=WhaJfmrRzkUX44g0VdzKss++fVLz6TGEfv+toCKDeNgArd/CM9kcF5AbrsyPRML6NqHOVO1Wym7SDTRmwvFzM17n871Ir2wIE+DwBxbJj3SglwXjwuXdcZIOxeJlYWNhvP7dSyQ97fA+HSSCZH3SeJ7IRlgS9CZ3AYeIjjdpczw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702581982; c=relaxed/simple; bh=Xd1wpe9d3IzcJ35cL4w4U+Vg9QQd9rr94oaCIiaouI4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=UM7lOnJjIlaL/hXs0mehJe6LybVJqsejUFRbvtJb+e9fK8rA99a7T94VxJMrylmoeXn6dHwG7PREQaggzZ5o9/fQ8L+pi/SDu6/TDb6prkxJTRy9GkFtOivYsqzF8OmJtBWbr0vCGky7XLn7c/xHUABcOQ+vNoVBkGJL8dYBLjY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-5c68b5cf14bso4768348a12.0 for <newlib@sourceware.org>; Thu, 14 Dec 2023 11:26:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702581979; x=1703186779; darn=sourceware.org; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=j99a5qpdpfMml/8VzJS5cQzqa45Xgb6DqmgGi958aH0=; b=MAQ6OuC8fHyIxgfxto6cq9g1MnAc8JAqLlmVUo9PY7T1MurNIHVKzSfhYFsm+0ua3n +2I8o6TpqcEMa4tMkvrFJigLNL8HIiPGa5h3BlsmmmJKPfFfyW+9ZYAcef8jcwA2S0rt SZ0j/O/0GKD5/mu3pgZdB98HiMA4PMSz2kuHVnJMNZtHnLyQ+pBjVQ4qia+N6slimHJW Fj/DZGtITi1UEpExG1OeQKcrRsTBYZAIVOjli2if7BnGcmY9YeAAMfo01x53mXr/S25k 5/Ryvmkcvz0ChxgfTTWr6Le5VXECjoPNtBTQV/O47GXfK/1oYgwuH4cj3jV4tDsNEVS2 ojBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702581979; x=1703186779; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j99a5qpdpfMml/8VzJS5cQzqa45Xgb6DqmgGi958aH0=; b=X25q8nzj6WXwBqk1FZzfaRH0nrR+S0zt3l500O1DYvg9USORx0RuZs6HhbM6AaqxhF THT9nQwb7IFGXbrXhF01euJxqgq9yz6rLCxNbEL/QzA+ogU/stnFY3nP3OH2fEuSEpf+ m8K7wMXdHRSYIsxo0J6IWq6Auzx8KIGzHSuZZVG6AHlNKn4nICf8k86Ihi71zEP2wwhS sol7yNEmWEiMfLFNtMKDrXf6usL6ADj+LO/l1Ny2eeIPtWcvt0XHMXlFKKwFWSpRcCEW +gV1M9IWisMN/Xy+HVNRi1umlJ7N5kJqeWo0QVoP33op4JVjizjFhhObwO5QoOuqOhH+ 1S5Q== X-Gm-Message-State: AOJu0Yyafv11YNGGFB79unjBFHbAr02K508i3m9topbZ7gah4Rw/KpAU Z8tV8FQxg5PrqPUfaX+DmLsgdGz+kfk= X-Google-Smtp-Source: AGHT+IFcYNiV7j0Qj9z6pSLIODJVZbLgRWqzL/fVwLZSNM9LT2uofD2AeleEXsav4PmMpbNNfuQ7ug== X-Received: by 2002:a17:90b:1b46:b0:28a:2429:6cd0 with SMTP id nv6-20020a17090b1b4600b0028a24296cd0mr4925491pjb.93.1702581979083; Thu, 14 Dec 2023 11:26:19 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id nb14-20020a17090b35ce00b0028ad536ea86sm1201252pjb.48.2023.12.14.11.26.17 for <newlib@sourceware.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Dec 2023 11:26:18 -0800 (PST) Content-Type: multipart/mixed; boundary="------------KqR0bklzj6Ez7YOwMRWNxDWs" Message-ID: <0d476ceb-d413-4f68-953a-3b9a4634fff8@gmail.com> Date: Thu, 14 Dec 2023 12:26:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: newlib@sourceware.org From: Jeff Law <jeffreyalaw@gmail.com> Subject: Fix moxie libgloss issues with c99 X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Newlib mailing list <newlib.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/newlib>, <mailto:newlib-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/newlib/> List-Post: <mailto:newlib@sourceware.org> List-Help: <mailto:newlib-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/newlib>, <mailto:newlib-request@sourceware.org?subject=subscribe> Errors-To: newlib-bounces+patchwork=sourceware.org@sourceware.org |
Series |
Fix moxie libgloss issues with c99
|
|
Commit Message
Jeff Law
Dec. 14, 2023, 7:26 p.m. UTC
Two libgloss issues specific to moxie-elf that show up build with GCC trunk. First, putnum.c uses "print" without a prototype. So I added one based on the function's definition in print.c. Second sim-inbyte.c uses read, which comes from unistd.h, so this adds a suitable #include. OK for the trunk? Jeff diff --git a/libgloss/frv/putnum.c b/libgloss/frv/putnum.c
Comments
Please go ahead. -- Jeff J. On Thu, Dec 14, 2023 at 2:26 PM Jeff Law <jeffreyalaw@gmail.com> wrote: > > Two libgloss issues specific to moxie-elf that show up build with GCC > trunk. > > First, putnum.c uses "print" without a prototype. So I added one based > on the function's definition in print.c. Second sim-inbyte.c uses read, > which comes from unistd.h, so this adds a suitable #include. > > OK for the trunk? > > Jeff
diff --git a/libgloss/moxie/putnum.c b/libgloss/moxie/putnum.c index 0f7e89453..9af5b4d4c 100644 --- a/libgloss/moxie/putnum.c +++ b/libgloss/moxie/putnum.c @@ -14,6 +14,8 @@ */ #include "glue.h" +void print (char *); + /* * putnum -- print a 32 bit number in hex */ diff --git a/libgloss/moxie/sim-inbyte.c b/libgloss/moxie/sim-inbyte.c index 1e7466a8d..57d058741 100644 --- a/libgloss/moxie/sim-inbyte.c +++ b/libgloss/moxie/sim-inbyte.c @@ -14,6 +14,8 @@ * they apply. */ +#include <unistd.h> + int inbyte () {