[v4,0/2] aarch64: Sync with ARM-software/optimized-routines

Message ID 20231005122030.81381-1-sebastian.huber@embedded-brains.de
Headers
Series aarch64: Sync with ARM-software/optimized-routines |

Message

Sebastian Huber Oct. 5, 2023, 12:20 p.m. UTC
  This patch set synchronizes AArch64-specific files with the

https://github.com/ARM-software/optimized-routines

upstream.

Sebastian Huber (2):
  aarch64: Sync with ARM-software/optimized-routines
  aarch64: Import memrchr.S

v3:

Use latest commit.

v4:

Update COPYING.NEWLIB.

Sebastian Huber (2):
  aarch64: Sync with ARM-software/optimized-routines
  aarch64: Import memrchr.S

 COPYING.NEWLIB                             | 250 ++++++++++++
 newlib/Makefile.in                         |  40 ++
 newlib/libc/machine/aarch64/Makefile.inc   |   2 +
 newlib/libc/machine/aarch64/asmdefs.h      | 106 +++++
 newlib/libc/machine/aarch64/memchr.S       |  73 ++--
 newlib/libc/machine/aarch64/memcmp.S       | 311 ++++++++-------
 newlib/libc/machine/aarch64/memcpy.S       | 272 +++++++------
 newlib/libc/machine/aarch64/memrchr-stub.c |  11 +
 newlib/libc/machine/aarch64/memrchr.S      | 115 ++++++
 newlib/libc/machine/aarch64/memset.S       | 194 ++-------
 newlib/libc/machine/aarch64/stpcpy.S       |  36 +-
 newlib/libc/machine/aarch64/strchr.S       | 107 ++---
 newlib/libc/machine/aarch64/strchrnul.S    |  90 ++---
 newlib/libc/machine/aarch64/strcmp.S       | 282 +++++++------
 newlib/libc/machine/aarch64/strcpy.S       | 437 ++++++---------------
 newlib/libc/machine/aarch64/strlen.S       | 319 +++++++--------
 newlib/libc/machine/aarch64/strncmp.S      | 323 ++++++++-------
 newlib/libc/machine/aarch64/strnlen.S      | 256 ++++--------
 newlib/libc/machine/aarch64/strrchr.S      |  86 ++--
 19 files changed, 1644 insertions(+), 1666 deletions(-)
 create mode 100644 newlib/libc/machine/aarch64/asmdefs.h
 create mode 100644 newlib/libc/machine/aarch64/memrchr-stub.c
 create mode 100644 newlib/libc/machine/aarch64/memrchr.S
  

Comments

Richard Earnshaw Oct. 5, 2023, 3:35 p.m. UTC | #1
On 05/10/2023 13:20, Sebastian Huber wrote:
> This patch set synchronizes AArch64-specific files with the
> 
> https://github.com/ARM-software/optimized-routines
> 
> upstream.
> 
> Sebastian Huber (2):
>   aarch64: Sync with ARM-software/optimized-routines
>   aarch64: Import memrchr.S
> 
> v3:
> 
> Use latest commit.
> 
> v4:
> 
> Update COPYING.NEWLIB.
> 
> Sebastian Huber (2):
>   aarch64: Sync with ARM-software/optimized-routines
>   aarch64: Import memrchr.S
> 
>  COPYING.NEWLIB                             | 250 ++++++++++++
>  newlib/Makefile.in                         |  40 ++
>  newlib/libc/machine/aarch64/Makefile.inc   |   2 +
>  newlib/libc/machine/aarch64/asmdefs.h      | 106 +++++
>  newlib/libc/machine/aarch64/memchr.S       |  73 ++--
>  newlib/libc/machine/aarch64/memcmp.S       | 311 ++++++++-------
>  newlib/libc/machine/aarch64/memcpy.S       | 272 +++++++------
>  newlib/libc/machine/aarch64/memrchr-stub.c |  11 +
>  newlib/libc/machine/aarch64/memrchr.S      | 115 ++++++
>  newlib/libc/machine/aarch64/memset.S       | 194 ++-------
>  newlib/libc/machine/aarch64/stpcpy.S       |  36 +-
>  newlib/libc/machine/aarch64/strchr.S       | 107 ++---
>  newlib/libc/machine/aarch64/strchrnul.S    |  90 ++---
>  newlib/libc/machine/aarch64/strcmp.S       | 282 +++++++------
>  newlib/libc/machine/aarch64/strcpy.S       | 437 ++++++---------------
>  newlib/libc/machine/aarch64/strlen.S       | 319 +++++++--------
>  newlib/libc/machine/aarch64/strncmp.S      | 323 ++++++++-------
>  newlib/libc/machine/aarch64/strnlen.S      | 256 ++++--------
>  newlib/libc/machine/aarch64/strrchr.S      |  86 ++--
>  19 files changed, 1644 insertions(+), 1666 deletions(-)
>  create mode 100644 newlib/libc/machine/aarch64/asmdefs.h
>  create mode 100644 newlib/libc/machine/aarch64/memrchr-stub.c
>  create mode 100644 newlib/libc/machine/aarch64/memrchr.S
> 

These are OK.

R.
  
Kinsey Moore Oct. 26, 2023, 9:55 p.m. UTC | #2
Hi,
It looks like this update has caused a duplicate symbol in the generated libc.a due to the added alias to memmove in newlib/libc/machine/aarch64/memcpy.S. To maintain a closer match to the upstream optimized-routines repository, I'd recommend emptying newlib/libc/machine/aarch64/memmove.S if it needs to remain in place or removing it from the build entirely.

Thanks,
Kinsey

-----Original Message-----
From: Newlib <newlib-bounces+kinsey.moore=oarcorp.com@sourceware.org> On Behalf Of Richard Earnshaw (lists)
Sent: Thursday, October 5, 2023 10:36 AM
To: Sebastian Huber <sebastian.huber@embedded-brains.de>; newlib@sourceware.org
Subject: Re: [PATCH v4 0/2] aarch64: Sync with ARM-software/optimized-routines

On 05/10/2023 13:20, Sebastian Huber wrote:
> This patch set synchronizes AArch64-specific files with the
> 
> https://github.com/ARM-software/optimized-routines
> 
> upstream.
> 
> Sebastian Huber (2):
>   aarch64: Sync with ARM-software/optimized-routines
>   aarch64: Import memrchr.S
> 
> v3:
> 
> Use latest commit.
> 
> v4:
> 
> Update COPYING.NEWLIB.
> 
> Sebastian Huber (2):
>   aarch64: Sync with ARM-software/optimized-routines
>   aarch64: Import memrchr.S
> 
>  COPYING.NEWLIB                             | 250 ++++++++++++
>  newlib/Makefile.in                         |  40 ++
>  newlib/libc/machine/aarch64/Makefile.inc   |   2 +
>  newlib/libc/machine/aarch64/asmdefs.h      | 106 +++++
>  newlib/libc/machine/aarch64/memchr.S       |  73 ++--
>  newlib/libc/machine/aarch64/memcmp.S       | 311 ++++++++-------
>  newlib/libc/machine/aarch64/memcpy.S       | 272 +++++++------
>  newlib/libc/machine/aarch64/memrchr-stub.c |  11 +
>  newlib/libc/machine/aarch64/memrchr.S      | 115 ++++++
>  newlib/libc/machine/aarch64/memset.S       | 194 ++-------
>  newlib/libc/machine/aarch64/stpcpy.S       |  36 +-
>  newlib/libc/machine/aarch64/strchr.S       | 107 ++---
>  newlib/libc/machine/aarch64/strchrnul.S    |  90 ++---
>  newlib/libc/machine/aarch64/strcmp.S       | 282 +++++++------
>  newlib/libc/machine/aarch64/strcpy.S       | 437 ++++++---------------
>  newlib/libc/machine/aarch64/strlen.S       | 319 +++++++--------
>  newlib/libc/machine/aarch64/strncmp.S      | 323 ++++++++-------
>  newlib/libc/machine/aarch64/strnlen.S      | 256 ++++--------
>  newlib/libc/machine/aarch64/strrchr.S      |  86 ++--
>  19 files changed, 1644 insertions(+), 1666 deletions(-)
>  create mode 100644 newlib/libc/machine/aarch64/asmdefs.h
>  create mode 100644 newlib/libc/machine/aarch64/memrchr-stub.c
>  create mode 100644 newlib/libc/machine/aarch64/memrchr.S
> 

These are OK.

R.