| Message ID | bug-26127-9487@http.sourceware.org/bugzilla/ |
|---|---|
| State | Dropped |
| Headers |
Return-Path: <libabigail-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DEAD0386F800; Wed, 17 Jun 2020 07:43:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DEAD0386F800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1592379819; bh=GGIRzLxvH1d4NJyAsI7k2Zi+OaxnTQqLELXKWwMI+Iw=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=ITICSLDpU2AIbGdzOcWFZSlJWaZhnRm/CxlSifUNyLI+3LqYp27J7z9AsaI0pZ6c1 td2hK1Zd+eJRvaoONZTpFh8wvIZgsfNP5gr0CyHn70IloPhCvTcEBGjQs/ixYBRxj4 p1vdVM+VclXw8iIXzvitvS3LUUAgmOPDAzTdyh3s= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: by sourceware.org (Postfix, from userid 48) id BB6783851C0C; Wed, 17 Jun 2020 07:43:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB6783851C0C To: libabigail@sourceware.org Subject: [Bug default/26127] New: abidw --annotate emits incomplete function types Date: Wed, 17 Jun 2020 07:43:38 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: gprocida+abigail at google dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc target_milestone Message-ID: <bug-26127-9487@http.sourceware.org/bugzilla/> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org> List-Unsubscribe: <http://sourceware.org/mailman/options/libabigail>, <mailto:libabigail-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libabigail/> List-Help: <mailto:libabigail-request@sourceware.org?subject=help> List-Subscribe: <http://sourceware.org/mailman/listinfo/libabigail>, <mailto:libabigail-request@sourceware.org?subject=subscribe> From: gprocida+abigail at google dot com via Libabigail <libabigail@sourceware.org> Reply-To: gprocida+abigail at google dot com <sourceware-bugzilla@sourceware.org> Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" <libabigail-bounces@sourceware.org> |
| Series |
[Bug,default/26127] New: abidw --annotate emits incomplete function types
|
|
Commit Message
fche at redhat dot com
June 17, 2020, 7:43 a.m. UTC
https://sourceware.org/bugzilla/show_bug.cgi?id=26127
Bug ID: 26127
Summary: abidw --annotate emits incomplete function types
Product: libabigail
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: default
Assignee: dodji at redhat dot com
Reporter: gprocida+abigail at google dot com
CC: libabigail at sourceware dot org
Target Milestone: ---
This issue is similar to https://sourceware.org/bugzilla/show_bug.cgi?id=25986
in that incorrect function types are being emitted.
For example,
tests/data/test-annotate/test20-pr19025-libvtkParallelCore-6.1.so.abi contains
<!-- void ()* -->
<pointer-type-def type-id='type-id-342' size-in-bits='64'
id='type-id-343'/>
but this should be
<!-- std::basic_ostream<char, std::char_traits<char> >&
(std::basic_ostream<char, std::char_traits<char> >&)* -->
<pointer-type-def type-id='type-id-342' size-in-bits='64'
id='type-id-343'/>
Here's a "fix" which might help determine the root cause.
commit af00b1f690e6a1541be513d50d2c426cb7659fcf (HEAD -> bad-annotation)
Author: Giuliano Procida <gprocida@google.com>
Date: Tue Jun 16 23:30:09 2020 +0100
Bodge to fix abidw --annotate function types.
Signed-off-by: Giuliano Procida <gprocida@google.com>
Comments
https://sourceware.org/bugzilla/show_bug.cgi?id=26127
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2020-06-17
Ever confirmed|0 |1
Status|UNCONFIRMED |ASSIGNED
https://sourceware.org/bugzilla/show_bug.cgi?id=26127
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #1 from dodji at redhat dot com ---
This problem should hopefully be fixed in the master branch by commit
https://sourceware.org/git/?p=libabigail.git;a=commit;h=a5d02b95a673651f2009faeefdc394078c251a7e.
Thank you for reporting this problem and sorry for the inconvenience.
diff --git a/src/abg-ir.cc b/src/abg-ir.cc index 5e2506a2..2da3f8a5 100644 --- a/src/abg-ir.cc +++ b/src/abg-ir.cc @@ -11762,6 +11762,8 @@ type_base::get_canonical_type_for(type_base_sptr t) if (!t) return t; + t->get_pretty_representation(); + environment* env = t->get_environment(); ABG_ASSERT(env);